Micrsoft.DelegatedNetwork RP RestAPI spec #10404

tamilmani1989 · 2020-08-10T22:20:27Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-08-10T22:20:31Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-08-10T22:20:44Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-08-10T22:21:59Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-08-10T22:27:42Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-10T22:27:56Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from a4c5b66 with merge commit 07243fe. SDK Automation 13.0.17.20200807.2
️✔️preview/delegatednetwork/mgmt/2020-08-08-preview [View full logs] [Release SDK Changes]
- preview.delegatednetwork.mgmt.2020-08-08-preview.zip

openapi-sdkautomation · 2020-08-10T22:28:08Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from a4c5b66 with merge commit 07243fe. SDK Automation 13.0.17.20200807.2

⚠️sdk/DelegatedNetwork/mgmt-2020-08-08-preview [View full logs] [Release SDK Changes]

[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-mgmt-delegatednetwork: MavenReportException: Error while creating archive: 
[mvn] [ERROR] Exit code: 1 - javadoc: error - Illegal package name: "com.microsoft.azure.management.delegatednetwork.2020-08-08-preview"
[mvn] [ERROR] 
[mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
[mvn] [ERROR] 
[mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/DelegatedNetwork/mgmt-2020-08-08-preview/target/apidocs' dir.
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

openapi-sdkautomation · 2020-08-10T22:28:11Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from a4c5b66 with merge commit 07243fe. SDK Automation 13.0.17.20200807.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-08-10T22:28:19Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from a4c5b66 with merge commit 07243fe. SDK Automation 13.0.17.20200807.2

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.DelegatedNetwork [View full logs] [Release SDK Changes]
No Artifact Generated.

openapi-sdkautomation · 2020-08-10T22:28:36Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from a4c5b66 with merge commit 07243fe. SDK Automation 13.0.17.20200807.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-08-10T22:29:11Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-10T22:29:12Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-08-10T22:39:09Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-10T22:58:01Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-10T23:54:06Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-10T23:59:24Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T00:06:24Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T00:17:02Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T00:32:04Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T01:12:18Z

Azure Pipelines successfully started running 1 pipeline(s).

ravbhatnagar

@tamilmani1989 - adding comments for delegatedSUbnet APIs only, since the controller type was already reviewed by Chirag and Marcin.

ravbhatnagar · 2020-08-19T17:54:56Z

...resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json

+      }
+    }
+  },
+  "paths": {


missing Patch which is a requirement

ravbhatnagar · 2020-08-19T17:55:48Z

...resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json

+            "in": "body",
+            "required": true,
+            "schema": {
+              "$ref": "#/definitions/DelegatedSubnetParameters"


request body and response body must use the same model.

why is that requirement? response body can have state saying succeeded or failed and request body doesn't need that.

i saw few existing RPs using different request and response body

ravbhatnagar · 2020-08-19T17:56:58Z

...resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json

+        "x-ms-long-running-operation": true
+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworks/{vnetName}/subnets/{subnetName}/providers/Microsoft.DelegatedNetwork/delegatedSubnet": {


this path wont work with ARM. You need a {name} segment to indicate the name of the delegatedSubnet

and then add a GET api to list all delegatedSubnets under a subnet.

pluralize the resource type name so delegatedSubnets

this path wont work with ARM. You need a {name} segment to indicate the name of the delegatedSubnet

can we give same subnet name?

and then add a GET api to list all delegatedSubnets under a subnet.

subnet is same here and the only thing is its delegated. so there won't be any list of delegated subnets under subnet

azure-pipelines · 2020-08-19T21:06:36Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-19T21:19:34Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-19T22:40:36Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-19T22:45:10Z

Azure Pipelines successfully started running 1 pipeline(s).

ravbhatnagar

looks good, signing off from ARM side.

azure-pipelines · 2020-08-19T22:48:18Z

Azure Pipelines successfully started running 1 pipeline(s).

tamilmani1989 · 2020-08-19T23:14:55Z

@NullMDR its good to merge now

azure-pipelines · 2020-08-19T23:33:30Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-19T23:48:05Z

Azure Pipelines successfully started running 1 pipeline(s).

...resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json

azure-pipelines · 2020-08-20T03:02:43Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-20T03:14:05Z

Azure Pipelines successfully started running 1 pipeline(s).

Micrsoft.DelegatedNetwork RP restapi spec

c5caef4

openapi-assignment-bot bot assigned PhoenixHe-NV Aug 10, 2020

updated version

9b063ca

openapi-sdkautomation bot mentioned this pull request Aug 10, 2020

[AutoPR Microsoft.Azure.Management.DelegatedNetwork] Micrsoft.DelegatedNetwork RP RestAPI spec AzureSDKAutomation/azure-sdk-for-net#1506

Closed

added default error response

f2b161e

added list api and fixed other issues

52ddc7e

fixed copy paste error

a1d88ea

updated operation response spec

a973678

fixed errorresposne and styling issues

434a7a6

updated operation response

4af2675

updated operation response spec

7ba1958

tamilmani1989 added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Aug 18, 2020

ravbhatnagar reviewed Aug 19, 2020

View reviewed changes

ravbhatnagar added the ARMChangesRequested label Aug 19, 2020

Addressed feedback comments

c8a281d

fixed issue

e9489b6

added list api for new resource

b469ea1

added isDataAction back

81f6fb6

ravbhatnagar reviewed Aug 19, 2020

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 19, 2020

prettier fix

8cdba1c

tamilmani1989 removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 19, 2020

updated to array

1eae403

updated list url

87c1f06

xseeseesee reviewed Aug 20, 2020

View reviewed changes

...resource-manager/Microsoft.DelegatedNetwork/preview/2020-08-08-preview/DelegatedNetwork.json Outdated Show resolved Hide resolved

updated the name as per recommendation

135b5d6

updated operation id

a4c5b66

PhoenixHe-NV merged commit 07243fe into Azure:master Aug 20, 2020

Micrsoft.DelegatedNetwork RP RestAPI spec #10404

Micrsoft.DelegatedNetwork RP RestAPI spec #10404

Uh oh!

Conversation

tamilmani1989 commented Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-pipeline-app bot commented Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Staging] Swagger Validation Report

Uh oh!

azure-pipelines bot commented Aug 10, 2020

Uh oh!

azuresdkci commented Aug 10, 2020

Uh oh!

openapi-sdkautomation bot commented Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Azure CLI Extension Generation - Release

Uh oh!

openapi-sdkautomation bot commented Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python-track2 - Release

Uh oh!

openapi-sdkautomation bot commented Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Trenton Generation - Release

Uh oh!

azure-pipelines bot commented Aug 10, 2020

Uh oh!

azure-pipelines bot commented Aug 10, 2020

Uh oh!

azure-pipelines bot commented Aug 10, 2020

Uh oh!

azure-pipelines bot commented Aug 10, 2020

Uh oh!

azure-pipelines bot commented Aug 11, 2020

Uh oh!

azure-pipelines bot commented Aug 11, 2020

Uh oh!

azure-pipelines bot commented Aug 11, 2020

Uh oh!

azure-pipelines bot commented Aug 11, 2020

Uh oh!

ravbhatnagar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tamilmani1989 Aug 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

tamilmani1989 commented Aug 10, 2020 •

edited

Loading

openapi-pipeline-app bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 10, 2020 •

edited

Loading

tamilmani1989 Aug 19, 2020 •

edited

Loading