-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Adding optional backup storage redundancy parameter to 2020-02-02-preview ManagedInstance swagger #10398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding optional backup storage redundancy parameter to 2020-02-02-preview ManagedInstance swagger #10398
Conversation
Merging azure-rest-api-specs master to petrajkogit/azure-rest-api-specs
Merging with original
[Staging] Swagger Validation Report
❌ |
| Rule | Message |
|---|---|
1041 - AddedPropertyInResponse |
The new version has a new property 'backupStorageRedundancy' in response that was not found in the old version. New: Microsoft.Sql/preview/2020-02-02-preview/managedInstances.json#L386:7 Old: Microsoft.Sql/preview/2020-02-02-preview/managedInstances.json#L386:7 |
️️✔️LintDiff [Detail]
️✔️Validation passes for LintDiff.
️️✔️Avocado [Detail]
️✔️Validation passes for Avocado.
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-js - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
azure-sdk-for-net - Release
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Can one of the admins verify this patch? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@qianwens Hi, could you take a look at this changes, since they are urgent for GA of the feature? I see that there are some failing checks that detect BreakingChange due to addition to new parameter. This is optional parameter in PUT request. However, since this is API in preview version, and documentation is not yet public, I wonder how we proceed this cases when Breaking change is detected? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-resource-manager-schemas - Release
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Breaking change approved due to it is preview version. |
…view ManagedInstance swagger (Azure#10398) * Adding backupStorageRedundancy params to swagger * Fix for backupStorageRedundancy param mutability * Fix example response * Fix for x-ms-mutability for param * revert previous commit, since backupStorageRedundancy is valid only in PUT request Co-authored-by: Perica Trajkov <[email protected]>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.