-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Fix discriminator issues in storagecache 2020-03-01 #10392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix discriminator issues in storagecache 2020-03-01 #10392
Conversation
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please do not merge this PR until the service team approved this. Thanks |
azure-sdk-for-java - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
Azure CLI Extension Generation - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Can one of the admins verify this patch? |
|
Looks good, thank you. |
azure-resource-manager-schemas - Release
|
* Fix issues * Fix
|
@ArcturusZhang and others It's a bit concerning to see a breaking change in a stable version of Open API specs without any explanation. Would you be so kind as to explain why this change was made and what was the process of approving the breakage? |
|
Hi @mikhailshilkov this breaking change is to revert one problematic breaking change introduced by #8606 . In this PR, we nullified the problematic part - which is a breaking change when introduced in, and hence to get rid of it will cause another breaking change. If we compare the content in this PR with a version before PR #8606, there should be no breaking changes. |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.