-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Update delete pe connection to long running #10387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update delete pe connection to long running #10387
Conversation
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Can one of the admins verify this patch? |
|
HI @zhaomuzhi could you please fix the CIs (Model Validation and Prettier)? And also, the removal of |
Thanks Dapeng for the reminder. The removal of 'allOf' is desired because the PrivateEndpointConnection doesn't have identities and all other stuff. But it does have id, type, name in it. So I will add them in the new iteration. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-resource-manager-schemas - Release
|
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
As identified in the automated checks there are breaking changes, Please follow Azure Breaking changes approval request form as defined @Breaking Change Process |
They are not a breaking change to our python sdk(currently we only support python sdk). It's more like a correction. Because the PrivateEndpointConnection never supports Identity, Sku all that stuff in our services, so when I try to autorest with the current swagger, I found the issue therefore made this change. Hope it explains better the motivation of the breaking change |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.