Skip to content

Fix identity in servicebus swagger #10380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Fix identity in servicebus swagger #10380

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8257530
Fix identity in servicebus
ArcturusZhang Aug 7, 2020
5f6fca8
Principal ID and tenant ID should be readonly
ArcturusZhang Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .../resource-manager/Microsoft.ServiceBus/preview/2018-01-01-preview/servicebus-preview.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,6 +956,10 @@
"x-ms-client-flatten": true,
"$ref": "#/definitions/SBNamespaceProperties",
"description": "Properties of the namespace."
},
"identity": {
"$ref": "#/definitions/Identity",
"description": "Properties of BYOK Identity description"
}
},
"allOf": [
Expand Down Expand Up @@ -998,10 +1002,6 @@
"type": "boolean",
"description": "Enabling this property creates a Premium Service Bus Namespace in regions supported availability zones."
},
"identity": {
"$ref": "#/definitions/Identity",
"description": "Properties of BYOK Identity description"
},
"encryption": {
"$ref": "#/definitions/Encryption",
"description": "Properties of BYOK Encryption description"
Expand Down Expand Up @@ -1291,10 +1291,12 @@
"properties": {
"principalId": {
"type": "string",
"readOnly": true,
"description": "ObjectId from the KeyVault"
},
"tenantId": {
"type": "string",
"readOnly": true,
"description": "TenantId from the KeyVault"
},
"type": {
Expand Down