Skip to content

Conversation

@ihvo
Copy link
Contributor

@ihvo ihvo commented Aug 1, 2020

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 1, 2020

[Staging] Swagger Validation Report

BreakingChange: 89 Errors, 0 Warnings [Detail] [Expand] Only 10 items are listed, please refer to log for more details.
Rule Message
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'code' renamed or removed?
New: common-types/resource-management/v2/types.json#L273:7
Old: common-types/resource-management/v1/types.json#L273:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'details' renamed or removed?
New: common-types/resource-management/v2/types.json#L273:7
Old: common-types/resource-management/v1/types.json#L273:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'message' renamed or removed?
New: common-types/resource-management/v2/types.json#L273:7
Old: common-types/resource-management/v1/types.json#L273:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'target' renamed or removed?
New: common-types/resource-management/v2/types.json#L273:7
Old: common-types/resource-management/v1/types.json#L273:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'details' renamed or removed?
New: common-types/resource-management/v2/types.json#L273:7
Old: common-types/resource-management/v1/types.json#L273:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'additionalInfo' renamed or removed?
New: common-types/resource-management/v2/types.json#L273:7
Old: common-types/resource-management/v1/types.json#L273:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'details' renamed or removed?
New: common-types/resource-management/v2/types.json#L273:7
Old: common-types/resource-management/v1/types.json#L273:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'code' renamed or removed?
New: common-types/resource-management/v2/types.json#L273:7
Old: common-types/resource-management/v1/types.json#L273:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'message' renamed or removed?
New: common-types/resource-management/v2/types.json#L273:7
Old: common-types/resource-management/v1/types.json#L273:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'target' renamed or removed?
New: common-types/resource-management/v2/types.json#L273:7
Old: common-types/resource-management/v1/types.json#L273:7
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@ihvo ihvo requested a review from stack111 August 1, 2020 01:02
@ihvo ihvo added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 1, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 1, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 1, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 1, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 1, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 2366370 with merge commit 336325a. SDK Automation 13.0.17.20200807.2
  • ️✔️@azure/arm-maps [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/mapsManagementClient.js → ./dist/arm-maps.js...
    [npmPack] created ./dist/arm-maps.js in 251ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 9.2kB   esm/operations/accounts.js               
    [npmPack] npm notice 754B    esm/models/accountsMappers.js            
    [npmPack] npm notice 62.5kB  dist/arm-maps.js                         
    [npmPack] npm notice 22.0kB  dist/arm-maps.min.js                     
    [npmPack] npm notice 6.7kB   esm/operations/creators.js               
    [npmPack] npm notice 706B    esm/models/creatorsMappers.js            
    [npmPack] npm notice 345B    esm/models/index.js                      
    [npmPack] npm notice 465B    esm/operations/index.js                  
    [npmPack] npm notice 19.4kB  esm/models/mappers.js                    
    [npmPack] npm notice 1.5kB   esm/operations/maps.js                   
    [npmPack] npm notice 1.7kB   esm/mapsManagementClient.js              
    [npmPack] npm notice 2.5kB   esm/mapsManagementClientContext.js       
    [npmPack] npm notice 516B    esm/models/mapsMappers.js                
    [npmPack] npm notice 2.1kB   esm/models/parameters.js                 
    [npmPack] npm notice 7.0kB   esm/operations/privateAtlases.js         
    [npmPack] npm notice 727B    esm/models/privateAtlasesMappers.js      
    [npmPack] npm notice 974B    rollup.config.js                         
    [npmPack] npm notice 1.6kB   package.json                             
    [npmPack] npm notice 457B    tsconfig.json                            
    [npmPack] npm notice 4.0kB   esm/operations/accounts.d.ts.map         
    [npmPack] npm notice 5.5kB   esm/operations/accounts.js.map           
    [npmPack] npm notice 403B    esm/models/accountsMappers.d.ts.map      
    [npmPack] npm notice 416B    esm/models/accountsMappers.js.map        
    [npmPack] npm notice 141.1kB dist/arm-maps.js.map                     
    [npmPack] npm notice 19.4kB  dist/arm-maps.min.js.map                 
    [npmPack] npm notice 3.0kB   esm/operations/creators.d.ts.map         
    [npmPack] npm notice 3.9kB   esm/operations/creators.js.map           
    [npmPack] npm notice 380B    esm/models/creatorsMappers.d.ts.map      
    [npmPack] npm notice 393B    esm/models/creatorsMappers.js.map        
    [npmPack] npm notice 7.5kB   esm/models/index.d.ts.map                
    [npmPack] npm notice 202B    esm/operations/index.d.ts.map            
    [npmPack] npm notice 126B    esm/models/index.js.map                  
    [npmPack] npm notice 217B    esm/operations/index.js.map              
    [npmPack] npm notice 1.6kB   esm/models/mappers.d.ts.map              
    [npmPack] npm notice 11.5kB  esm/models/mappers.js.map                
    [npmPack] npm notice 646B    esm/operations/maps.d.ts.map             
    [npmPack] npm notice 892B    esm/operations/maps.js.map               
    [npmPack] npm notice 722B    esm/mapsManagementClient.d.ts.map        
    [npmPack] npm notice 876B    esm/mapsManagementClient.js.map          
    [npmPack] npm notice 506B    esm/mapsManagementClientContext.d.ts.map 
    [npmPack] npm notice 1.4kB   esm/mapsManagementClientContext.js.map   
    [npmPack] npm notice 229B    esm/models/mapsMappers.d.ts.map          
    [npmPack] npm notice 242B    esm/models/mapsMappers.js.map            
    [npmPack] npm notice 494B    esm/models/parameters.d.ts.map           
    [npmPack] npm notice 1.5kB   esm/models/parameters.js.map             
    [npmPack] npm notice 3.0kB   esm/operations/privateAtlases.d.ts.map   
    [npmPack] npm notice 3.9kB   esm/operations/privateAtlases.js.map     
    [npmPack] npm notice 395B    esm/models/privateAtlasesMappers.d.ts.map
    [npmPack] npm notice 408B    esm/models/privateAtlasesMappers.js.map  
    [npmPack] npm notice 3.3kB   README.md                                
    [npmPack] npm notice 11.0kB  esm/operations/accounts.d.ts             
    [npmPack] npm notice 20.0kB  src/operations/accounts.ts               
    [npmPack] npm notice 444B    esm/models/accountsMappers.d.ts          
    [npmPack] npm notice 754B    src/models/accountsMappers.ts            
    [npmPack] npm notice 8.5kB   esm/operations/creators.d.ts             
    [npmPack] npm notice 14.8kB  src/operations/creators.ts               
    [npmPack] npm notice 396B    esm/models/creatorsMappers.d.ts          
    [npmPack] npm notice 702B    src/models/creatorsMappers.ts            
    [npmPack] npm notice 20.9kB  esm/models/index.d.ts                    
    [npmPack] npm notice 149B    esm/operations/index.d.ts                
    [npmPack] npm notice 20.1kB  src/models/index.ts                      
    [npmPack] npm notice 433B    src/operations/index.ts                  
    [npmPack] npm notice 2.1kB   esm/models/mappers.d.ts                  
    [npmPack] npm notice 15.8kB  src/models/mappers.ts                    
    [npmPack] npm notice 1.1kB   esm/operations/maps.d.ts                 
    [npmPack] npm notice 2.4kB   src/operations/maps.ts                   
    [npmPack] npm notice 1.1kB   esm/mapsManagementClient.d.ts            
    [npmPack] npm notice 1.6kB   src/mapsManagementClient.ts              
    [npmPack] npm notice 798B    esm/mapsManagementClientContext.d.ts     
    [npmPack] npm notice 2.3kB   src/mapsManagementClientContext.ts       
    [npmPack] npm notice 206B    esm/models/mapsMappers.d.ts              
    [npmPack] npm notice 490B    src/models/mapsMappers.ts                
    [npmPack] npm notice 548B    esm/models/parameters.d.ts               
    [npmPack] npm notice 2.0kB   src/models/parameters.ts                 
    [npmPack] npm notice 8.9kB   esm/operations/privateAtlases.d.ts       
    [npmPack] npm notice 15.4kB  src/operations/privateAtlases.ts         
    [npmPack] npm notice 417B    esm/models/privateAtlasesMappers.d.ts    
    [npmPack] npm notice 717B    src/models/privateAtlasesMappers.ts      
    [npmPack] npm notice 1.1kB   LICENSE.txt                              
    [npmPack] npm notice === Tarball Details === 
    [npmPack] npm notice name:          @azure/arm-maps                         
    [npmPack] npm notice version:       1.1.0                                   
    [npmPack] npm notice filename:      azure-arm-maps-1.1.0.tgz                
    [npmPack] npm notice package size:  56.3 kB                                 
    [npmPack] npm notice unpacked size: 514.2 kB                                
    [npmPack] npm notice shasum:        774f21228c7e60d5c61be36968b04fc273495b86
    [npmPack] npm notice integrity:     sha512-5Jb0o0zu3ZD6A[...]H0Vc/p69Yv3aQ==

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 1, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 2366370 with merge commit 336325a. SDK Automation 13.0.17.20200807.2
  • ⚠️azure-mgmt-maps [View full logs]  [Release SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-maps
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-maps
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 69.461% size of original (original: 15796 chars, delta: 10972 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model MapsAccount has a new parameter system_data
    [ChangeLog]   - Model MapsAccount has a new parameter properties
    [ChangeLog]   - Added operation group MapsOperationsOperations
    [ChangeLog]   - Added operation group CreatorsOperations
    [ChangeLog]   - Added operation group PrivateAtlasesOperations
    [ChangeLog] 
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Parameter location of model MapsAccount is now required
    [ChangeLog]   - Removed operation AccountsOperations.list_operations
    [ChangeLog]   - Removed operation AccountsOperations.move

@ihvo ihvo changed the title [Hub Generated] Review request for Microsoft.Maps to add version preview/2020-02-01-preview [Hub Generated] Review request for Microsoft.Maps to add Creator resource under version preview/2020-02-01-preview Aug 1, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 1, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@ihvo
Copy link
Contributor Author

ihvo commented Aug 1, 2020

Private Atlas resource will be renamed to Creator. This change adds Creator operations to replace existing Private Atlas operations. We will deprecate Private Atlas later. Both resource types exist in the same "preview" API version.

Copy link
Contributor

@stack111 stack111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left feedback offline - looks good, only questions for me are about current version and retirement of accounts/privateAtlases.

@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 4, 2020
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed off from ARM side with a non-blocking comment. Please take a look.

@ruowan
Copy link
Member

ruowan commented Aug 4, 2020

Hi, Pls fix linter error.

@ihvo
Copy link
Contributor Author

ihvo commented Aug 4, 2020

Hi @ruowan, linter errors suggest that new APIs should use the standard response message. I have referenced types from common-types/resource-management/v1/types.json#/definitions/ErrorResponse which have the same structure as required in https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.

So, expected response schema is compliant with guidelines. Is that a tool issue? Or am I missing something?
Could you please advise?

@ruowan
Copy link
Member

ruowan commented Aug 5, 2020

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 5, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 5, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@ihvo
Copy link
Contributor Author

ihvo commented Aug 5, 2020

You could reference v2 types, v2 has fixed this issue. Here is a link https://github.com/Azure/azure-rest-api-specs/blob/master/specification/common-types/resource-management/v2/types.json.

Hi @ruowan, after referencing v2 type I've got PropertyRemoved failures. Is linter getting diff to the last commit or to master?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ruowan ruowan added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 7, 2020
@ruowan
Copy link
Member

ruowan commented Aug 7, 2020

Thanks for your feedback. It's actually a false positive. We will fix our tools later.

Could you pls change all v1 to v2? The only difference between v1 and v2 is /definitions/ErrorResponse. Your service is a preview version. If no customer impact, better to migrate it to v2. We allow this kind of breaking change.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ihvo
Copy link
Contributor Author

ihvo commented Aug 11, 2020

Thanks for your feedback. It's actually a false positive. We will fix our tools later.

Could you pls change all v1 to v2? The only difference between v1 and v2 is /definitions/ErrorResponse. Your service is a preview version. If no customer impact, better to migrate it to v2. We allow this kind of breaking change.

Confirmed that v2 matches what our RP actually returns. Updated all references to v2 types.

@ruowan , could you please complete this PR?

@ruowan ruowan merged commit 336325a into Azure:master Aug 11, 2020
@ihvo ihvo deleted the dev-maps-Microsoft.Maps-2020-02-01-preview branch August 11, 2020 17:05
innosam pushed a commit to innosam/azure-rest-api-specs that referenced this pull request Aug 17, 2020
…urce under version preview/2020-02-01-preview (Azure#10319)

* Adding operations for Maps Creator resource.

* Fixing typo.

* Adds suppression to readme

* Adds suppression to readme

* Adds suppression to readme

* Adds suppression to readme

* Resolving linter errors.

* Minor update.

* Updating all reference to v2 schema.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants