-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[Hub Generated] Review request for Microsoft.Maps to add Creator resource under version preview/2020-02-01-preview #10319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Maps to add Creator resource under version preview/2020-02-01-preview #10319
Conversation
[Staging] Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
❌ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Can one of the admins verify this patch? |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Private Atlas resource will be renamed to Creator. This change adds Creator operations to replace existing Private Atlas operations. We will deprecate Private Atlas later. Both resource types exist in the same "preview" API version. |
stack111
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left feedback offline - looks good, only questions for me are about current version and retirement of accounts/privateAtlases.
...ication/maps/resource-manager/Microsoft.Maps/preview/2020-02-01-preview/maps-management.json
Show resolved
Hide resolved
majastrz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed off from ARM side with a non-blocking comment. Please take a look.
|
Hi, Pls fix linter error. |
|
Hi @ruowan, linter errors suggest that new APIs should use the standard response message. I have referenced types from common-types/resource-management/v1/types.json#/definitions/ErrorResponse which have the same structure as required in https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. So, expected response schema is compliant with guidelines. Is that a tool issue? Or am I missing something? |
|
You could reference v2 types, v2 has fixed this issue. Here is a link https://github.com/Azure/azure-rest-api-specs/blob/master/specification/common-types/resource-management/v2/types.json. |
…github.com/ihvo/azure-rest-api-specs into dev-maps-Microsoft.Maps-2020-02-01-preview
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-net - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Hi @ruowan, after referencing v2 type I've got PropertyRemoved failures. Is linter getting diff to the last commit or to master? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
hi @ruowan , I'm using v1/types.json on existing APIs, with no changes to them. I'm using v2/types.json only on added APis. Could you please take a look today? |
|
Thanks for your feedback. It's actually a false positive. We will fix our tools later. Could you pls change all v1 to v2? The only difference between v1 and v2 is |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Confirmed that v2 matches what our RP actually returns. Updated all references to v2 types. @ruowan , could you please complete this PR? |
…urce under version preview/2020-02-01-preview (Azure#10319) * Adding operations for Maps Creator resource. * Fixing typo. * Adds suppression to readme * Adds suppression to readme * Adds suppression to readme * Adds suppression to readme * Resolving linter errors. * Minor update. * Updating all reference to v2 schema.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on PR review process.