Add appearance/multi-page selection feature for v3.1-preview.2 #10267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You don't have permission to trigger SDK Automation. |
[Staging] Swagger Validation Report
️✔️ |
Contributor
|
Can one of the admins verify this patch? |
Contributor
Author
No, we don't support open-ended range. |
shijiayuan
changed the title
lmazuel
reviewed
Aug 4, 2020
specification/cognitiveservices/data-plane/ComputerVision/preview/v3.1-preview.2/Ocr.json
Outdated
Show resolved
Hide resolved
lmazuel
reviewed
Aug 4, 2020
specification/cognitiveservices/data-plane/ComputerVision/preview/v3.1-preview.2/Ocr.json
Outdated
Show resolved
Hide resolved
|
@lmazuel, just to be sure, the python SDK check may be redundant because this is a next version up preview API? Or will the check take care of that as part of the process? |
johanste
reviewed
Aug 19, 2020
| "enum": [ | ||
| "handwriting", | ||
| "print", | ||
| null |
Member
There was a problem hiding this comment.
This is invalid openapi/swagger - null is not a string. The valid enum values should be "handwriting" and "print" - and if you don't know, you either have another sentinel value in the enum (e.g. unknown), or you simply omit the key/value pair (e.g. make the style property optional.
johanste
reviewed
Aug 19, 2020
| "x-ms-parameter-location": "method", | ||
| "type": "array", | ||
| "items": { | ||
| "type": "integer", |
Member
There was a problem hiding this comment.
Since you can specify ranges (e.g. 2-7), the data type of the parameter should be string. You may include a pattern to describe the valid values more precisely.
Contributor
Author
There was a problem hiding this comment.
Thanks, I have added pattern for it.
johanste
reviewed
Aug 19, 2020
specification/cognitiveservices/data-plane/ComputerVision/preview/v3.1-preview.2/Ocr.json
Show resolved
Hide resolved
johanste
reviewed
Aug 19, 2020
| "type": "array", | ||
| "items": { | ||
| "type": "string", | ||
| "pattern": "(^[0-9]+-[0-9]+$)|(^[0-9]+$)" |
Member
There was a problem hiding this comment.
This would not allow you to specify open ended ranges (e.g. 8- to get all pages starting with page 8)
Contributor
Author
There was a problem hiding this comment.
Actually I think we're agreed with that we don't have open ended ranges in Pages in the meeting. We only have two formats: one is "2,3,4", another is "2-4".
Member
There was a problem hiding this comment.
If that is what the service supports, then this is (a) correct representation. If the service does support open ranges, then we'd have to update the pattern.
johanste
approved these changes
Aug 19, 2020
johanste
added
the
Approved-OkToMerge
Contributor
Author
|
@johanste I don't have permission to trigger SDK Automation and it's blocking the merge. I have joined the Azure group but the SDK Python is still waiting for status. Could you please help to add comment *** /openapibot sdkautomation *** to authorize it? Thanks! |
|
/azp run automation - sdk |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java - Release
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
|
azure-sdk-for-js - Release
|
azure-resource-manager-schemas - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Aug 20, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.