Skip to content

[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01#10229

Closed
thramu wants to merge 22 commits intoAzure:masterfrom
thramu:dev-cost-management-Microsoft.CostManagement-2019-11-01
Closed

[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01#10229
thramu wants to merge 22 commits intoAzure:masterfrom
thramu:dev-cost-management-Microsoft.CostManagement-2019-11-01

Conversation

@thramu
Copy link
Contributor

@thramu thramu commented Jul 22, 2020

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 22, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
LintDiff: 4 Errors, 2 Warnings [Detail] [Expand]
Rule Message
R3030 - PathResourceProviderMatchNamespace The last resource provider 'Microsoft.CostManagement, Microsoft.Billing' doesn't match the namespace.
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L35
R4005 - UniqueXmsEnumName Must not have duplicate name of x-ms-enum extension , make sure every x-ms-enum name unique. The duplicate x-ms-enum name is statustype
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L2989
R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1142
R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1207
⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'generatereservationdetailsreport' in:'GenerateReservationDetailsReport_ByBillingAccountId'. Consider updating the operationId
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1106
⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'generatereservationdetailsreport' in:'GenerateReservationDetailsReport_ByBillingProfileId'. Consider updating the operationId
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1168
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2020

azure-sdk-for-java

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2020

azure-sdk-for-go

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2020

azure-sdk-for-python

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 68928fc with merge commit eb077a2699e761e3b28107bd48073750dd4b2b12. SDK Automation 13.0.17.20200619.4
  • ⚠️azure-mgmt-costmanagement [View full logs
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-costmanagement
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-costmanagement
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    No file is changed.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2020

Trenton Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2020

azure-sdk-for-python-track2

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2020

azure-sdk-for-js

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2020

azure-sdk-for-net

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2020

Azure CLI Extension Generation

  • Installation instruction for service costmanagement [Preview Changes]
    az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/10229/azure-cli-extensions/Azure/azure-cli-extensions/costmanagement/costmanagement-0.1.0-py3-none-any.whl
⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 68928fc with merge commit eb077a2699e761e3b28107bd48073750dd4b2b12. Azure CLI Automation 13.0.17.20200619.4
    Only show 100 items here, please refer to log for details.
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigTimePeriod' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigDataset' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigDatasetConfiguration' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigAggregation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigSorting' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigGrouping' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigComparisonExpression' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ProxyResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DismissAlertPayload' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ForecastDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryTimePeriod' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryDataset' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryDatasetConfiguration' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryAggregation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryGrouping' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryComparisonExpression' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (Modeler/MissingType): The schema 'AlertProperties-details-resourceGroupFilterItem' has no type or format information whatsoever. Location:
    [AutoRest] WARNING (Modeler/MissingType): The schema 'AlertProperties-details-resourceFilterItem' has no type or format information whatsoever. Location:
    [AutoRest] WARNING (Modeler/MissingType): The schema 'AlertProperties-details-meterFilterItem' has no type or format information whatsoever. Location:
    [AutoRest] WARNING (Modeler/MissingType): The schema 'QueryProperties-rows-itemsItem' has no type or format information whatsoever. Location:
    [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
    [AutoRest] 
    [AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
    [AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
    [AutoRest] --------------------------------------------------------
    [AutoRest]   test-scenario:
    [AutoRest]     - name: /Alerts/get/BillingAccountAlerts
    [AutoRest]     - name: /Alerts/get/BillingProfileAlerts
    [AutoRest]     - name: /Alerts/get/DepartmentAlerts
    [AutoRest]     - name: /Alerts/get/EnrollmentAccountAlerts
    [AutoRest]     - name: /Alerts/get/ExternalBillingAccountAlerts
    [AutoRest]     - name: /Alerts/get/ExternalSubscriptionAlerts
    [AutoRest]     - name: /Alerts/get/InvoiceSectionAlerts
    [AutoRest]     - name: /Alerts/get/ResourceGroupAlerts
    [AutoRest]     - name: /Alerts/get/ResourceGroupAlerts
    [AutoRest]     - name: /Alerts/get/SubscriptionAlerts
    [AutoRest]     - name: /Alerts/get/SubscriptionAlerts
    [AutoRest]     - name: /Alerts/patch/ResourceGroupAlerts
    [AutoRest]     - name: /Alerts/patch/SubscriptionAlerts
    [AutoRest]     - name: /Dimensions/get/BillingAccountDimensionsList-Legacy
    [AutoRest]     - name: /Dimensions/get/BillingAccountDimensionsList-Modern
    [AutoRest]     - name: /Dimensions/get/BillingAccountDimensionsListExpandAndTop-Legacy
    [AutoRest]     - name: /Dimensions/get/BillingAccountDimensionsListExpandAndTop-Modern
    [AutoRest]     - name: /Dimensions/get/BillingAccountDimensionsListWithFilter-Legacy
    [AutoRest]     - name: /Dimensions/get/BillingAccountDimensionsListWithFilter-Modern
    [AutoRest]     - name: /Dimensions/get/BillingProfileDimensionsList-Modern
    [AutoRest]     - name: /Dimensions/get/BillingProfileDimensionsListExpandAndTop-Modern
    [AutoRest]     - name: /Dimensions/get/BillingProfileDimensionsListWithFilter-Modern
    [AutoRest]     - name: /Dimensions/get/CustomerDimensionsList-Modern
    [AutoRest]     - name: /Dimensions/get/CustomerDimensionsListExpandAndTop-Modern
    [AutoRest]     - name: /Dimensions/get/CustomerDimensionsListWithFilter-Modern
    [AutoRest]     - name: /Dimensions/get/DepartmentDimensionsList-Legacy
    [AutoRest]     - name: /Dimensions/get/DepartmentDimensionsListExpandAndTop-Legacy
    [AutoRest]     - name: /Dimensions/get/DepartmentDimensionsListWithFilter-Legacy
    [AutoRest]     - name: /Dimensions/get/EnrollmentAccountDimensionsList-Legacy
    [AutoRest]     - name: /Dimensions/get/EnrollmentAccountDimensionsListExpandAndTop-Legacy
    [AutoRest]     - name: /Dimensions/get/EnrollmentAccountDimensionsListWithFilter-Legacy
    [AutoRest]     - name: /Dimensions/get/ExternalBillingAccountDimensionList
    [AutoRest]     - name: /Dimensions/get/ExternalSubscriptionDimensionList
    [AutoRest]     - name: /Dimensions/get/InvoiceSectionDimensionsList-Modern
    [AutoRest]     - name: /Dimensions/get/InvoiceSectionDimensionsListExpandAndTop-Modern
    [AutoRest]     - name: /Dimensions/get/InvoiceSectionDimensionsListWithFilter-Modern
    [AutoRest]     - name: /Dimensions/get/ManagementGroupDimensionsList-Legacy
    [AutoRest]     - name: /Dimensions/get/ManagementGroupDimensionsListExpandAndTop-Legacy
    [AutoRest]     - name: /Dimensions/get/ManagementGroupDimensionsListWithFilter-Legacy
    [AutoRest]     - name: /Dimensions/get/ResourceGroupDimensionsList-Legacy
    [AutoRest]     - name: /Dimensions/get/SubscriptionDimensionsList-Legacy
    [AutoRest]     - name: /Exports/put/ExportCreateOrUpdateByBillingAccount
    [AutoRest]     - name: /Exports/put/ExportCreateOrUpdateByDepartment
    [AutoRest]     - name: /Exports/put/ExportCreateOrUpdateByEnrollmentAccount
    [AutoRest]     - name: /Exports/put/ExportCreateOrUpdateByManagementGroup
    [AutoRest]     - name: /Exports/put/ExportCreateOrUpdateByResourceGroup
    [AutoRest]     - name: /Exports/put/ExportCreateOrUpdateBySubscription
    [AutoRest]     - name: /Exports/get/ExportGetByBillingAccount
    [AutoRest]     - name: /Exports/get/ExportGetByDepartment
    [AutoRest]     - name: /Exports/get/ExportGetByEnrollmentAccount
    [AutoRest]     - name: /Exports/get/ExportGetByManagementGroup
    [AutoRest]     - name: /Exports/get/ExportGetByResourceGroup
    [AutoRest]     - name: /Exports/get/ExportGetBySubscription
    [AutoRest]     - name: /Exports/get/ExportRunHistoryGetByBillingAccount
    [AutoRest]     - name: /Exports/get/ExportRunHistoryGetByDepartment
    [AutoRest]     - name: /Exports/get/ExportRunHistoryGetByEnrollmentAccount
    [AutoRest]     - name: /Exports/get/ExportRunHistoryGetByManagementGroup
    [AutoRest]     - name: /Exports/get/ExportRunHistoryGetByResourceGroup
    [AutoRest]     - name: /Exports/get/ExportRunHistoryGetBySubscription
    [AutoRest]     - name: /Exports/get/ExportsGetByBillingAccount
    [AutoRest]     - name: /Exports/get/ExportsGetByDepartment
    [AutoRest]     - name: /Exports/get/ExportsGetByEnrollmentAccount
    [AutoRest]     - name: /Exports/get/ExportsGetByManagementGroup
    [AutoRest]     - name: /Exports/get/ExportsGetByResourceGroup
    [AutoRest]     - name: /Exports/get/ExportsGetBySubscription
    [AutoRest]     - name: /Exports/post/ExportRunByBillingAccount
  • ⚠️costmanagement [View full logs
    No file is changed.

@openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 22, 2020
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pilor pilor added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 23, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@thramu thramu closed this Jul 24, 2020
@thramu thramu reopened this Jul 24, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ChenTanyi
Copy link
Contributor

@thramu do you still work on it for CI failed?

@ghost
Copy link

ghost commented Dec 27, 2020

Hi, @thramu. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@ghost ghost added the no-recent-activity label Dec 27, 2020
@ghost ghost closed this Mar 22, 2021
@ghost
Copy link

ghost commented Mar 22, 2021

Hi, @thramu. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee @ChenTanyi.

@thramu
Copy link
Contributor Author

thramu commented Nov 17, 2021

@ChenTanyi Can you please merge this PR?

@ChenTanyi
Copy link
Contributor

@thramu Please reopen it and fix the CI failed first.

@JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 29, 2021
@ghost ghost removed the no-recent-activity label Nov 29, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments