corrent codegen params #10199

changlong-liu · 2020-07-20T05:14:12Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-07-20T05:14:16Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-07-20T05:14:29Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-07-20T05:15:53Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-20T05:15:54Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-20T05:15:54Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 131e378 with merge commit ac0629c. SDK Automation 13.0.17.20200619.4

️✔️@azure/arm-azurestackhci [View full logs] [Release SDK Changes]

azure-arm-azurestackhci-1.0.0.tgz

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/azureStackHCIClient.js → ./dist/arm-azurestackhci.js...
[npmPack] created ./dist/arm-azurestackhci.js in 192ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/[email protected]
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 37.2kB dist/arm-azurestackhci.js              
[npmPack] npm notice 12.5kB dist/arm-azurestackhci.min.js          
[npmPack] npm notice 1.5kB  esm/azureStackHCIClient.js             
[npmPack] npm notice 2.5kB  esm/azureStackHCIClientContext.js      
[npmPack] npm notice 8.2kB  esm/operations/clusters.js             
[npmPack] npm notice 601B   esm/models/clustersMappers.js          
[npmPack] npm notice 345B   esm/models/index.js                    
[npmPack] npm notice 409B   esm/operations/index.js                
[npmPack] npm notice 13.7kB esm/models/mappers.js                  
[npmPack] npm notice 1.5kB  esm/operations/operations.js           
[npmPack] npm notice 493B   esm/models/operationsMappers.js        
[npmPack] npm notice 1.9kB  esm/models/parameters.js               
[npmPack] npm notice 991B   rollup.config.js                       
[npmPack] npm notice 1.7kB  package.json                           
[npmPack] npm notice 457B   tsconfig.json                          
[npmPack] npm notice 81.1kB dist/arm-azurestackhci.js.map          
[npmPack] npm notice 12.2kB dist/arm-azurestackhci.min.js.map      
[npmPack] npm notice 648B   esm/azureStackHCIClient.d.ts.map       
[npmPack] npm notice 742B   esm/azureStackHCIClient.js.map         
[npmPack] npm notice 504B   esm/azureStackHCIClientContext.d.ts.map
[npmPack] npm notice 1.4kB  esm/azureStackHCIClientContext.js.map  
[npmPack] npm notice 3.6kB  esm/operations/clusters.d.ts.map       
[npmPack] npm notice 5.1kB  esm/operations/clusters.js.map         
[npmPack] npm notice 308B   esm/models/clustersMappers.d.ts.map    
[npmPack] npm notice 321B   esm/models/clustersMappers.js.map      
[npmPack] npm notice 5.2kB  esm/models/index.d.ts.map              
[npmPack] npm notice 158B   esm/operations/index.d.ts.map          
[npmPack] npm notice 126B   esm/models/index.js.map                
[npmPack] npm notice 173B   esm/operations/index.js.map            
[npmPack] npm notice 934B   esm/models/mappers.d.ts.map            
[npmPack] npm notice 8.0kB  esm/models/mappers.js.map              
[npmPack] npm notice 659B   esm/operations/operations.d.ts.map     
[npmPack] npm notice 906B   esm/operations/operations.js.map       
[npmPack] npm notice 238B   esm/models/operationsMappers.d.ts.map  
[npmPack] npm notice 251B   esm/models/operationsMappers.js.map    
[npmPack] npm notice 445B   esm/models/parameters.d.ts.map         
[npmPack] npm notice 1.3kB  esm/models/parameters.js.map           
[npmPack] npm notice 3.2kB  README.md                              
[npmPack] npm notice 1.0kB  esm/azureStackHCIClient.d.ts           
[npmPack] npm notice 1.5kB  src/azureStackHCIClient.ts             
[npmPack] npm notice 794B   esm/azureStackHCIClientContext.d.ts    
[npmPack] npm notice 2.3kB  src/azureStackHCIClientContext.ts      
[npmPack] npm notice 8.8kB  esm/operations/clusters.d.ts           
[npmPack] npm notice 16.9kB src/operations/clusters.ts             
[npmPack] npm notice 291B   esm/models/clustersMappers.d.ts        
[npmPack] npm notice 585B   src/models/clustersMappers.ts          
[npmPack] npm notice 13.7kB esm/models/index.d.ts                  
[npmPack] npm notice 93B    esm/operations/index.d.ts              
[npmPack] npm notice 13.3kB src/models/index.ts                    
[npmPack] npm notice 377B   src/operations/index.ts                
[npmPack] npm notice 1.1kB  esm/models/mappers.d.ts                
[npmPack] npm notice 11.0kB src/models/mappers.ts                  
[npmPack] npm notice 1.1kB  esm/operations/operations.d.ts         
[npmPack] npm notice 2.3kB  src/operations/operations.ts           
[npmPack] npm notice 183B   esm/models/operationsMappers.d.ts      
[npmPack] npm notice 461B   src/models/operationsMappers.ts        
[npmPack] npm notice 480B   esm/models/parameters.d.ts             
[npmPack] npm notice 1.8kB  src/models/parameters.ts               
[npmPack] npm notice 1.1kB  LICENSE.txt                            
[npmPack] npm notice === Tarball Details === 
[npmPack] npm notice name:          @azure/arm-azurestackhci                
[npmPack] npm notice version:       1.0.0                                   
[npmPack] npm notice filename:      azure-arm-azurestackhci-1.0.0.tgz       
[npmPack] npm notice package size:  39.4 kB                                 
[npmPack] npm notice unpacked size: 290.6 kB                                
[npmPack] npm notice shasum:        8c8c96fe830233215121b825abbd892131137ac6
[npmPack] npm notice integrity:     sha512-AcrR1bTkiecUh[...]Blyvta/ZUQCxg==
[npmPack] npm notice total files:   59                                      
[npmPack] npm notice

openapi-sdkautomation · 2020-07-20T05:15:55Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 131e378 with merge commit ac0629c. SDK Automation 13.0.17.20200619.4
```
[azure-mgmt-azurestackhci][ChangeLog] WARNING: Failed to generate ChangeLog.
```

⚠️azure-mgmt-azurestackhci [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-azurestackhci
[build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-azurestackhci
[build_conf] INFO:packaging_tools:Template done azure-mgmt-azurestackhci
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
Not exact 2 reports found:
code_reports/latest/report.json
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

openapi-sdkautomation · 2020-07-20T05:15:55Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 131e378 with merge commit ac0629c. SDK Automation 13.0.17.20200619.4
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-07-20T05:15:55Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-20T05:15:56Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-20T05:15:59Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 131e378 with merge commit ac0629c. SDK Automation 13.0.17.20200619.4
️✔️preview/azurestackhci/mgmt/2020-03-01-preview [View full logs] [Release SDK Changes]
- preview.azurestackhci.mgmt.2020-03-01-preview.zip

azuresdkci · 2020-07-20T05:16:39Z

Can one of the admins verify this patch?

sudhirap · 2020-07-20T17:45:33Z

specification/azurestackhci/resource-manager/readme.typescript.md

-  package-name: "azurestackhci"
-  output-folder: "$(typescript-sdks-folder)/packages/azurestackhci"
+  package-name: "@azure/arm-azurestackhci"
+  output-folder: "$(typescript-sdks-folder)/sdk/azurestackhci/azurestackhci"


Should this be output-folder: "$(typescript-sdks-folder)/sdk/azurestackhci/arm-azurestackhci"?

sudhirap

Please change output-folder: "$(typescript-sdks-folder)/sdk/azurestackhci/azurestackhci" to output-folder: "$(typescript-sdks-folder)/sdk/azurestackhci/arm-azurestackhci". The rest look good.

azure-pipelines · 2020-07-21T02:07:14Z

Azure Pipelines successfully started running 1 pipeline(s).

changlong-liu · 2020-07-21T02:09:48Z

Hi @njuCZ , I corrected the JS output folder @sudhirap mentioned in commit 131e378.
Would you help to merge this PR? Thank you!

* corrent codegen params * correct output folder

corrent codegen params

26ac8fe

changlong-liu requested a review from mbialecka July 20, 2020 05:14

openapi-assignment-bot bot assigned njuCZ Jul 20, 2020

This was referenced Jul 20, 2020

[AutoPR @azure/arm-azurestackhci] corrent codegen params AzureSDKAutomation/azure-sdk-for-js#1564

Closed

[AutoPR azure-mgmt-azurestackhci] corrent codegen params AzureSDKAutomation/azure-sdk-for-python#1627

Closed

changlong-liu requested a review from sudhirap July 20, 2020 05:20

sudhirap reviewed Jul 20, 2020

View reviewed changes

sudhirap approved these changes Jul 20, 2020

View reviewed changes

correct output folder

131e378

njuCZ merged commit ac0629c into Azure:master Jul 21, 2020

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

corrent codegen params (Azure#10199)

9e45fdd

* corrent codegen params * correct output folder

corrent codegen params #10199

corrent codegen params #10199

Uh oh!

Conversation

changlong-liu commented Jul 20, 2020

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-pipeline-app bot commented Jul 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Staging] Swagger Validation Report

Uh oh!

azure-pipelines bot commented Jul 20, 2020

Uh oh!

openapi-sdkautomation bot commented Jul 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Trenton Generation - Release

Uh oh!

openapi-sdkautomation bot commented Jul 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Azure CLI Extension Generation - Release

Uh oh!

openapi-sdkautomation bot commented Jul 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Jul 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Jul 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Jul 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Jul 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python-track2 - Release

Uh oh!

openapi-sdkautomation bot commented Jul 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

azuresdkci commented Jul 20, 2020

Uh oh!

sudhirap Jul 20, 2020

Choose a reason for hiding this comment

Uh oh!

sudhirap left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Jul 21, 2020

Uh oh!

changlong-liu commented Jul 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

openapi-pipeline-app bot commented Jul 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 20, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 20, 2020 •

edited

Loading