Skip to content

Conversation

@jaysterp
Copy link
Member

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 16, 2020

[Staging] Swagger Validation Report

BreakingChange: 8 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1041 - AddedPropertyInResponse The new version has a new property 'location' in response that was not found in the old version.
New: Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json#L1807:7
Old: Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json#L1807:7
1041 - AddedPropertyInResponse The new version has a new property 'location' in response that was not found in the old version.
New: Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json#L1807:7
Old: Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json#L1807:7
1041 - AddedPropertyInResponse The new version has a new property 'location' in response that was not found in the old version.
New: Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json#L1807:7
Old: Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json#L1807:7
1041 - AddedPropertyInResponse The new version has a new property 'location' in response that was not found in the old version.
New: Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json#L1807:7
Old: Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json#L1807:7
1041 - AddedPropertyInResponse The new version has a new property 'location' in response that was not found in the old version.
New: Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json#L2043:7
Old: Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json#L2039:7
1041 - AddedPropertyInResponse The new version has a new property 'location' in response that was not found in the old version.
New: Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json#L2043:7
Old: Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json#L2039:7
1041 - AddedPropertyInResponse The new version has a new property 'location' in response that was not found in the old version.
New: Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json#L2043:7
Old: Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json#L2039:7
1041 - AddedPropertyInResponse The new version has a new property 'location' in response that was not found in the old version.
New: Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json#L2043:7
Old: Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json#L2039:7
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 16, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 16, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 16, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 16, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 16, 2020

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 9b674d4 with merge commit c43fbcc. SDK Automation 13.0.17.20200619.4
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-02-01-preview'} in label v2018_02_01_preview
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2018-02-01-preview based on label v2018_02_01_preview
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-09-01'} in label v2018_09_01
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2018-09-01 based on label v2018_09_01
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-04-01'} in label v2019_04_01
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-04-01 based on label v2019_04_01
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2019-05-01'} in label v2019_05_01
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01 based on label v2019_05_01
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-05-01-preview'} in label v2019_05_01_preview
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01-preview based on label v2019_05_01_preview
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01-preview', '2019-05-01', '2019-05-01-preview'} in label v2019_06_01_preview
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-06-01-preview based on label v2019_06_01_preview
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2019-12-01-preview', '2019-06-01-preview', '2019-05-01-preview'} in label v2019_12_01_preview
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-12-01-preview based on label v2019_12_01_preview
  • ️✔️azure-mgmt-containerregistry [View full logs]  [Release SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-containerregistry
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-containerregistry
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-02-01-preview'} in label v2018_02_01_preview
    [after_scripts|python] WARNING:__main__:Guessing you want 2018-02-01-preview based on label v2018_02_01_preview
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-09-01'} in label v2018_09_01
    [after_scripts|python] WARNING:__main__:Guessing you want 2018-09-01 based on label v2018_09_01
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-04-01'} in label v2019_04_01
    [after_scripts|python] WARNING:__main__:Guessing you want 2019-04-01 based on label v2019_04_01
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2019-05-01'} in label v2019_05_01
    [after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01 based on label v2019_05_01
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-05-01-preview'} in label v2019_05_01_preview
    [after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01-preview based on label v2019_05_01_preview
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01-preview', '2019-05-01', '2019-05-01-preview'} in label v2019_06_01_preview
    [after_scripts|python] WARNING:__main__:Guessing you want 2019-06-01-preview based on label v2019_06_01_preview
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-12-01-preview', '2019-06-01-preview', '2019-05-01-preview'} in label v2019_12_01_preview
    [after_scripts|python] WARNING:__main__:Guessing you want 2019-12-01-preview based on label v2019_12_01_preview
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 0.241% size of original (original: 120624 chars, delta: 291 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model ExportPipeline has a new parameter location
    [ChangeLog]   - Model ImportPipeline has a new parameter location

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 16, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 9b674d4 with merge commit c43fbcc. SDK Automation 13.0.17.20200619.4
  • ️✔️@azure/arm-containerregistry [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/containerRegistryManagementClient.js → ./dist/arm-containerregistry.js...
    [npmPack] created ./dist/arm-containerregistry.js in 653ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 12.3kB  esm/operations/agentPools.js                         
    [npmPack] npm notice 1.9kB   esm/models/agentPoolsMappers.js                      
    [npmPack] npm notice 409.0kB dist/arm-containerregistry.js                        
    [npmPack] npm notice 143.6kB dist/arm-containerregistry.min.js                    
    [npmPack] npm notice 2.5kB   esm/containerRegistryManagementClient.js             
    [npmPack] npm notice 2.6kB   esm/containerRegistryManagementClientContext.js      
    [npmPack] npm notice 9.0kB   esm/operations/exportPipelines.js                    
    [npmPack] npm notice 1.8kB   esm/models/exportPipelinesMappers.js                 
    [npmPack] npm notice 9.0kB   esm/operations/importPipelines.js                    
    [npmPack] npm notice 1.8kB   esm/models/importPipelinesMappers.js                 
    [npmPack] npm notice 345B    esm/models/index.js                                  
    [npmPack] npm notice 781B    esm/operations/index.js                              
    [npmPack] npm notice 145.5kB esm/models/mappers.js                                
    [npmPack] npm notice 2.3kB   esm/operations/operations.js                         
    [npmPack] npm notice 572B    esm/models/operationsMappers.js                      
    [npmPack] npm notice 6.4kB   esm/models/parameters.js                             
    [npmPack] npm notice 8.8kB   esm/operations/pipelineRuns.js                       
    [npmPack] npm notice 1.8kB   esm/models/pipelineRunsMappers.js                    
    [npmPack] npm notice 9.7kB   esm/operations/privateEndpointConnections.js         
    [npmPack] npm notice 1.9kB   esm/models/privateEndpointConnectionsMappers.js      
    [npmPack] npm notice 26.3kB  esm/operations/registries.js                         
    [npmPack] npm notice 2.3kB   esm/models/registriesMappers.js                      
    [npmPack] npm notice 11.4kB  esm/operations/replications.js                       
    [npmPack] npm notice 1.9kB   esm/models/replicationsMappers.js                    
    [npmPack] npm notice 1.0kB   rollup.config.js                                     
    [npmPack] npm notice 9.1kB   esm/operations/runs.js                               
    [npmPack] npm notice 1.9kB   esm/models/runsMappers.js                            
    [npmPack] npm notice 11.2kB  esm/operations/scopeMaps.js                          
    [npmPack] npm notice 1.8kB   esm/models/scopeMapsMappers.js                       
    [npmPack] npm notice 12.0kB  esm/operations/taskRuns.js                           
    [npmPack] npm notice 1.9kB   esm/models/taskRunsMappers.js                        
    [npmPack] npm notice 12.0kB  esm/operations/tasks.js                              
    [npmPack] npm notice 2.2kB   esm/models/tasksMappers.js                           
    [npmPack] npm notice 10.9kB  esm/operations/tokens.js                             
    [npmPack] npm notice 1.8kB   esm/models/tokensMappers.js                          
    [npmPack] npm notice 15.1kB  esm/operations/webhooks.js                           
    [npmPack] npm notice 2.0kB   esm/models/webhooksMappers.js                        
    [npmPack] npm notice 1.8kB   package.json                                         
    [npmPack] npm notice 457B    tsconfig.json                                        
    [npmPack] npm notice 3.3kB   esm/operations/agentPools.d.ts.map                   
    [npmPack] npm notice 5.9kB   esm/operations/agentPools.js.map                     
    [npmPack] npm notice 1.1kB   esm/models/agentPoolsMappers.d.ts.map                
    [npmPack] npm notice 1.1kB   esm/models/agentPoolsMappers.js.map                  
    [npmPack] npm notice 722.9kB dist/arm-containerregistry.js.map                    
    [npmPack] npm notice 104.2kB dist/arm-containerregistry.min.js.map                
    [npmPack] npm notice 1.1kB   esm/containerRegistryManagementClient.d.ts.map       
    [npmPack] npm notice 1.6kB   esm/containerRegistryManagementClient.js.map         
    [npmPack] npm notice 501B    esm/containerRegistryManagementClientContext.d.ts.map
    [npmPack] npm notice 1.4kB   esm/containerRegistryManagementClientContext.js.map  
    [npmPack] npm notice 2.4kB   esm/operations/exportPipelines.d.ts.map              
    [npmPack] npm notice 4.2kB   esm/operations/exportPipelines.js.map                
    [npmPack] npm notice 1.1kB   esm/models/exportPipelinesMappers.d.ts.map           
    [npmPack] npm notice 1.1kB   esm/models/exportPipelinesMappers.js.map             
    [npmPack] npm notice 2.4kB   esm/operations/importPipelines.d.ts.map              
    [npmPack] npm notice 4.2kB   esm/operations/importPipelines.js.map                
    [npmPack] npm notice 1.1kB   esm/models/importPipelinesMappers.d.ts.map           
    [npmPack] npm notice 1.1kB   esm/models/importPipelinesMappers.js.map             
    [npmPack] npm notice 53.2kB  esm/models/index.d.ts.map                            
    [npmPack] npm notice 420B    esm/operations/index.d.ts.map                        
    [npmPack] npm notice 126B    esm/models/index.js.map                              
    [npmPack] npm notice 435B    esm/operations/index.js.map                          
    [npmPack] npm notice 7.3kB   esm/models/mappers.d.ts.map                          
    [npmPack] npm notice 81.6kB  esm/models/mappers.js.map                            
    [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map                   
    [npmPack] npm notice 1.4kB   esm/operations/operations.js.map                     
    [npmPack] npm notice 254B    esm/models/operationsMappers.d.ts.map                
    [npmPack] npm notice 267B    esm/models/operationsMappers.js.map                  
    [npmPack] npm notice 1.2kB   esm/models/parameters.d.ts.map                       
    [npmPack] npm notice 4.8kB   esm/models/parameters.js.map                         
    [npmPack] npm notice 2.4kB   esm/operations/pipelineRuns.d.ts.map                 
    [npmPack] npm notice 4.2kB   esm/operations/pipelineRuns.js.map                   
    [npmPack] npm notice 1.1kB   esm/models/pipelineRunsMappers.d.ts.map              
    [npmPack] npm notice 1.1kB   esm/models/pipelineRunsMappers.js.map                
    [npmPack] npm notice 2.5kB   esm/operations/privateEndpointConnections.d.ts.map   
    [npmPack] npm notice 4.2kB   esm/operations/privateEndpointConnections.js.map     
    [npmPack] npm notice 1.1kB   esm/models/privateEndpointConnectionsMappers.d.ts.map
    [npmPack] npm notice 1.1kB   esm/models/privateEndpointConnectionsMappers.js.map  
    [npmPack] npm notice 7.4kB   esm/operations/registries.d.ts.map                   
    [npmPack] npm notice 13.1kB  esm/operations/registries.js.map                     
    [npmPack] npm notice 1.3kB   esm/models/registriesMappers.d.ts.map                
    [npmPack] npm notice 1.3kB   esm/models/registriesMappers.js.map                  
    [npmPack] npm notice 2.8kB   esm/operations/replications.d.ts.map                 
    [npmPack] npm notice 5.3kB   esm/operations/replications.js.map                   
    [npmPack] npm notice 1.1kB   esm/models/replicationsMappers.d.ts.map              
    [npmPack] npm notice 1.1kB   esm/models/replicationsMappers.js.map                
    [npmPack] npm notice 2.9kB   esm/operations/runs.d.ts.map                         
    [npmPack] npm notice 4.8kB   esm/operations/runs.js.map                           

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 16, 2020

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@jaysterp
Copy link
Member Author

@fengzhou-msft we are introducing this change because our existing create flow for exportPipeline and importPipeline is broken for SDK users due to errors from Managed Identity. These are proxy resources that are onboarded to managed identity, however they were initially released without a Location property due to ARM's API contract that proxy resources will inherit location from their parent tracked resource, which in this case is a registry. ARM routes the requests for these proxy resources to the parent location RP endpoint. See ARM wiki. However, for MI-enabled proxy resources, ARM explicitly looks for Location in the request body in order to route to the MI RP. With no Location provided, ARM cannot route the request to MI and PUT fails with IdentityServiceUnavailble. We are hoping this change can be included in the existing preview API version as the current create flow for these resources is broken. @mnltejaswini

@fengzhou-msft fengzhou-msft added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 21, 2020
@fengzhou-msft
Copy link
Member

Is the PR ready to merge?

@jaysterp
Copy link
Member Author

jaysterp commented Jul 22, 2020

@fengzhou-msft our deployment was on hold due to the recent Azure deployment freeze but we will be ready to merge on Thursday.

@jaysterp
Copy link
Member Author

@fengzhou-msft ready to merge. Thanks!

@fengzhou-msft fengzhou-msft merged commit c43fbcc into Azure:master Jul 26, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 26, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants