[Microsoft.ApiManagement][2019-12-01] Content management resources#10080
[Microsoft.ApiManagement][2019-12-01] Content management resources#10080raych1 merged 13 commits intoAzure:masterfrom azaslonov:master
Conversation
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-net - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
|
|
Can one of the admins verify this patch? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@azaslonov , please fix the CI check failures. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@raych1 all is green now. Thanks for looking into this. |
majastrz
left a comment
There was a problem hiding this comment.
As per https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md, evolutionary changes should be added in a new API version.
@majastrz this is ARM KPI Swagger completeness. The API is being used by customers in 2019-12-01 and we missed to document it. GET/SUBSCRIPTIONS/RESOURCEGROUPS/PROVIDERS/MICROSOFT.APIMANAGEMENT/SERVICE/CONTENTTYPES/CONTENTITEMS/ You can refer to task - https://msazure.visualstudio.com/Unified%20Platform%20KPIs/_workitems/edit/3598671 |
Makes sense. This week's ARM reviewer (@chiragg4u) will take a look. |
| "title", | ||
| "permalink", | ||
| "documentId" | ||
| ] |
There was a problem hiding this comment.
This looks like the swagger definition for this object will this be returned to the user?
There was a problem hiding this comment.
Yes, this is the schema for ContentItem defined by a customer.
| }, | ||
| "ContentItemContractProperties": { | ||
| "properties": {}, | ||
| "additionalProperties": true |
There was a problem hiding this comment.
The definition is open, how will SDK/clients be able to parse this and make sense of the response?
There was a problem hiding this comment.
I assume they will parse it as a string, they don't need to make sense of it. It is basically content.
chiragg4u
left a comment
There was a problem hiding this comment.
Minor comments based on responses, changes are approved.
…zure#10080) * [Microsoft.ApiManagement][2019-12-01] Content management resources * Fixes.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.