Skip to content

[Microsoft.ApiManagement][2019-12-01] Content management resources#10080

Merged
raych1 merged 13 commits intoAzure:masterfrom
azaslonov:master
Jul 16, 2020
Merged

[Microsoft.ApiManagement][2019-12-01] Content management resources#10080
raych1 merged 13 commits intoAzure:masterfrom
azaslonov:master

Conversation

@azaslonov
Copy link
Member

@azaslonov azaslonov commented Jul 9, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 9, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 9, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 78db523 with merge commit 292c41f. SDK Automation 13.0.17.20200619.4
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityStateByOperation' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityStateByApi' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityStateByProduct' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityState' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'CheckEntityExists' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'CheckEntityExists' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
  • ️✔️Microsoft.Azure.Management.ApiManagement [View full logs]  [Release SDK Changes]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 78db523 with merge commit 292c41f. SDK Automation 13.0.17.20200619.4
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_state_by_operation' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_state_by_api' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_state_by_product' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_state' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'check_entity_exists' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'check_entity_exists' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
  • ⚠️azure-mgmt-apimanagement [View full logs]  [Release SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-apimanagement
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-apimanagement
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 1.214% size of original (original: 235176 chars, delta: 2855 chars)
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Operation SubscriptionOperations.create_or_update has a new signature
    [ChangeLog]   - Operation SubscriptionOperations.update has a new signature
    [ChangeLog]   - Operation UserConfirmationPasswordOperations.send has a new signature
    [ChangeLog]   - Operation UserOperations.delete has a new signature
    [ChangeLog]   - Operation UserOperations.create_or_update has a new signature

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 78db523 with merge commit 292c41f. SDK Automation 13.0.17.20200619.4
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityStateByOperation' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityStateByApi' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityStateByProduct' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityState' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'checkEntityExists' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'checkEntityExists' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
  • ️✔️@azure/arm-apimanagement [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/apiManagementClient.js → ./dist/arm-apimanagement.js...
    [npmPack] created ./dist/arm-apimanagement.js in 1.7s
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/arm-apimanagement@6.0.0
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 12.2kB  esm/operations/api.js                                  
    [npmPack] npm notice 9.6kB   esm/operations/apiDiagnostic.js                        
    [npmPack] npm notice 2.6kB   esm/models/apiDiagnosticMappers.js                     
    [npmPack] npm notice 2.0kB   esm/operations/apiExport.js                            
    [npmPack] npm notice 466B    esm/models/apiExportMappers.js                         
    [npmPack] npm notice 9.4kB   esm/operations/apiIssue.js                             
    [npmPack] npm notice 8.8kB   esm/operations/apiIssueAttachment.js                   
    [npmPack] npm notice 2.6kB   esm/models/apiIssueAttachmentMappers.js                
    [npmPack] npm notice 8.7kB   esm/operations/apiIssueComment.js                      
    [npmPack] npm notice 2.6kB   esm/models/apiIssueCommentMappers.js                   
    [npmPack] npm notice 2.6kB   esm/models/apiIssueMappers.js                          
    [npmPack] npm notice 5.8kB   esm/apiManagementClient.js                             
    [npmPack] npm notice 2.6kB   esm/apiManagementClientContext.js                      
    [npmPack] npm notice 2.4kB   esm/operations/apiManagementOperations.js              
    [npmPack] npm notice 468B    esm/models/apiManagementOperationsMappers.js           
    [npmPack] npm notice 21.7kB  esm/operations/apiManagementService.js                 
    [npmPack] npm notice 2.8kB   esm/models/apiManagementServiceMappers.js              
    [npmPack] npm notice 2.8kB   esm/operations/apiManagementServiceSkus.js             
    [npmPack] npm notice 515B    esm/models/apiManagementServiceSkusMappers.js          
    [npmPack] npm notice 2.9kB   esm/models/apiMappers.js                               
    [npmPack] npm notice 9.6kB   esm/operations/apiOperation.js                         
    [npmPack] npm notice 2.6kB   esm/models/apiOperationMappers.js                      
    [npmPack] npm notice 7.9kB   esm/operations/apiOperationPolicy.js                   
    [npmPack] npm notice 2.6kB   esm/models/apiOperationPolicyMappers.js                
    [npmPack] npm notice 7.1kB   esm/operations/apiPolicy.js                            
    [npmPack] npm notice 2.6kB   esm/models/apiPolicyMappers.js                         
    [npmPack] npm notice 2.8kB   esm/operations/apiProduct.js                           
    [npmPack] npm notice 2.5kB   esm/models/apiProductMappers.js                        
    [npmPack] npm notice 9.5kB   esm/operations/apiRelease.js                           
    [npmPack] npm notice 2.6kB   esm/models/apiReleaseMappers.js                        
    [npmPack] npm notice 2.8kB   esm/operations/apiRevision.js                          
    [npmPack] npm notice 473B    esm/models/apiRevisionMappers.js                       
    [npmPack] npm notice 9.9kB   esm/operations/apiSchema.js                            
    [npmPack] npm notice 2.6kB   esm/models/apiSchemaMappers.js                         
    [npmPack] npm notice 8.5kB   esm/operations/apiTagDescription.js                    
    [npmPack] npm notice 2.7kB   esm/models/apiTagDescriptionMappers.js                 
    [npmPack] npm notice 9.3kB   esm/operations/apiVersionSet.js                        
    [npmPack] npm notice 2.6kB   esm/models/apiVersionSetMappers.js                     
    [npmPack] npm notice 1.2MB   dist/arm-apimanagement.js                              
    [npmPack] npm notice 449.8kB dist/arm-apimanagement.min.js                          
    [npmPack] npm notice 10.4kB  esm/operations/authorizationServer.js                  
    [npmPack] npm notice 2.7kB   esm/models/authorizationServerMappers.js               
    [npmPack] npm notice 10.1kB  esm/operations/backend.js                              
    [npmPack] npm notice 2.6kB   esm/models/backendMappers.js                           
    [npmPack] npm notice 8.8kB   esm/operations/cache.js                                
    [npmPack] npm notice 2.6kB   esm/models/cacheMappers.js                             
    [npmPack] npm notice 7.9kB   esm/operations/certificate.js                          
    [npmPack] npm notice 2.6kB   esm/models/certificateMappers.js                       
    [npmPack] npm notice 6.8kB   esm/operations/delegationSettings.js                   
    [npmPack] npm notice 2.6kB   esm/models/delegationSettingsMappers.js                
    [npmPack] npm notice 9.1kB   esm/operations/diagnostic.js                           
    [npmPack] npm notice 2.6kB   esm/models/diagnosticMappers.js                        
    [npmPack] npm notice 9.0kB   esm/operations/emailTemplate.js                        
    [npmPack] npm notice 2.6kB   esm/models/emailTemplateMappers.js                     
    [npmPack] npm notice 12.7kB  esm/operations/gateway.js                              
    [npmPack] npm notice 6.5kB   esm/operations/gatewayApi.js                           
    [npmPack] npm notice 2.5kB   esm/models/gatewayApiMappers.js                        
    [npmPack] npm notice 8.6kB   esm/operations/gatewayHostnameConfiguration.js         
    [npmPack] npm notice 2.7kB   esm/models/gatewayHostnameConfigurationMappers.js      
    [npmPack] npm notice 2.7kB   esm/models/gatewayMappers.js                           
    [npmPack] npm notice 8.9kB   esm/operations/group.js                                
    [npmPack] npm notice 2.6kB   esm/models/groupMappers.js                             
    [npmPack] npm notice 6.1kB   esm/operations/groupUser.js                            
    [npmPack] npm notice 2.5kB   esm/models/groupUserMappers.js                         
    [npmPack] npm notice 10.6kB  esm/operations/identityProvider.js                     
    [npmPack] npm notice 2.7kB   esm/models/identityProviderMappers.js                  
    [npmPack] npm notice 345B    esm/models/index.js                                    
    [npmPack] npm notice 2.5kB   esm/operations/index.js                                
    [npmPack] npm notice 3.8kB   esm/operations/issue.js                                
    [npmPack] npm notice 2.5kB   esm/models/issueMappers.js                             
    [npmPack] npm notice 8.9kB   esm/operations/logger.js                               
    [npmPack] npm notice 2.6kB   esm/models/loggerMappers.js                            
    [npmPack] npm notice 304.2kB esm/models/mappers.js                                  
    [npmPack] npm notice 13.2kB  esm/operations/namedValue.js                           
    [npmPack] npm notice 2.7kB   esm/models/namedValueMappers.js                        
    [npmPack] npm notice 3.4kB   esm/operations/networkStatus.js                        
    [npmPack] npm notice 515B    esm/models/networkStatusMappers.js                     
    [npmPack] npm notice 5.0kB   esm/operations/notification.js                         
    [npmPack] npm notice 2.5kB   esm/models/notificationMappers.js                      
    [npmPack] npm notice 5.9kB   esm/operations/notificationRecipientEmail.js           
    [npmPack] npm notice 2.5kB   esm/models/notificationRecipientEmailMappers.js        
    [npmPack] npm notice 5.9kB   esm/operations/notificationRecipientUser.js            
    [npmPack] npm notice 2.5kB   esm/models/notificationRecipientUserMappers.js         
    [npmPack] npm notice 10.4kB  esm/operations/openIdConnectProvider.js                
    [npmPack] npm notice 2.7kB   esm/models/openIdConnectProviderMappers.js             
    [npmPack] npm notice 2.9kB   esm/operations/operationOperations.js                  
    [npmPack] npm notice 856B    esm/models/operationOperationsMappers.js               

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 10, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@raych1
Copy link
Member

raych1 commented Jul 10, 2020

@azaslonov , please fix the CI check failures.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azaslonov
Copy link
Member Author

@raych1 all is green now. Thanks for looking into this.

Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md, evolutionary changes should be added in a new API version.

@solankisamir
Copy link
Member

solankisamir commented Jul 13, 2020

As per https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md, evolutionary changes should be added in a new API version.

@majastrz this is ARM KPI Swagger completeness. The API is being used by customers in 2019-12-01 and we missed to document it.

GET/SUBSCRIPTIONS/RESOURCEGROUPS/PROVIDERS/MICROSOFT.APIMANAGEMENT/SERVICE/CONTENTTYPES/CONTENTITEMS/

You can refer to task - https://msazure.visualstudio.com/Unified%20Platform%20KPIs/_workitems/edit/3598671
/cc @azaslonov

@majastrz
Copy link
Member

As per https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md, evolutionary changes should be added in a new API version.

@majastrz this is ARM KPI Swagger completeness. The API is being used by customers in 2019-12-01 and we missed to document it.

GET/SUBSCRIPTIONS/RESOURCEGROUPS/PROVIDERS/MICROSOFT.APIMANAGEMENT/SERVICE/CONTENTTYPES/CONTENTITEMS/

You can refer to task - https://msazure.visualstudio.com/Unified%20Platform%20KPIs/_workitems/edit/3598671
/cc @azaslonov

Makes sense. This week's ARM reviewer (@chiragg4u) will take a look.

"title",
"permalink",
"documentId"
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the swagger definition for this object will this be returned to the user?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is the schema for ContentItem defined by a customer.

},
"ContentItemContractProperties": {
"properties": {},
"additionalProperties": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition is open, how will SDK/clients be able to parse this and make sense of the response?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume they will parse it as a string, they don't need to make sense of it. It is basically content.

@chiragg4u chiragg4u added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 15, 2020
@chiragg4u chiragg4u self-requested a review July 15, 2020 21:23
Copy link
Contributor

@chiragg4u chiragg4u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments based on responses, changes are approved.

@raych1 raych1 merged commit 292c41f into Azure:master Jul 16, 2020
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
…zure#10080)

* [Microsoft.ApiManagement][2019-12-01] Content management resources

* Fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments