Update CDN default api version to 2020-04-15. #10026

fore5fire · 2020-07-02T17:24:05Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
- adding/removing APIs.
- adding/removing properties.
- adding/removing API-version.
- adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-pipeline-app · 2020-07-02T17:24:09Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-07-02T17:24:22Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-07-02T17:34:22Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-02T17:34:56Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 21736a1 with merge commit af6cd68. SDK Automation 13.0.17.20200619.4
️✔️cdn/mgmt/2015-06-01 [View full logs] [Release SDK Changes]
- cdn.mgmt.2015-06-01.zip
️✔️cdn/mgmt/2016-04-02 [View full logs] [Release SDK Changes]
- cdn.mgmt.2016-04-02.zip
️✔️cdn/mgmt/2016-10-02 [View full logs] [Release SDK Changes]
- cdn.mgmt.2016-10-02.zip
️✔️cdn/mgmt/2017-04-02 [View full logs] [Release SDK Changes]
- cdn.mgmt.2017-04-02.zip
️✔️cdn/mgmt/2017-10-12 [View full logs] [Release SDK Changes]
- cdn.mgmt.2017-10-12.zip
️✔️cdn/mgmt/2019-04-15 [View full logs] [Release SDK Changes]
- cdn.mgmt.2019-04-15.zip
️✔️preview/cdn/mgmt/2020-04-15 [View full logs] [Release SDK Changes]
- preview.cdn.mgmt.2020-04-15.zip

openapi-sdkautomation · 2020-07-02T17:35:03Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 21736a1 with merge commit af6cd68. SDK Automation 13.0.17.20200619.4
️✔️sdk/cdn/mgmt-v2020_04_15 [View full logs] [Release SDK Changes]

openapi-sdkautomation · 2020-07-02T17:35:19Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 21736a1 with merge commit af6cd68. SDK Automation 13.0.17.20200619.4

️✔️@azure/arm-cdn [View full logs] [Release SDK Changes]

azure-arm-cdn-4.2.0.tgz

Only show 100 items here, please refer to log for details.

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/cdnManagementClient.js → ./dist/arm-cdn.js...
[npmPack] created ./dist/arm-cdn.js in 499ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/[email protected]
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 317.4kB dist/arm-cdn.js                                   
[npmPack] npm notice 115.9kB dist/arm-cdn.min.js                               
[npmPack] npm notice 5.3kB   esm/cdnManagementClient.js                        
[npmPack] npm notice 3.0kB   esm/cdnManagementClientContext.js                 
[npmPack] npm notice 12.5kB  esm/operations/customDomains.js                   
[npmPack] npm notice 2.9kB   esm/models/customDomainsMappers.js                
[npmPack] npm notice 2.2kB   esm/operations/edgeNodes.js                       
[npmPack] npm notice 2.8kB   esm/models/edgeNodesMappers.js                    
[npmPack] npm notice 25.6kB  esm/operations/endpoints.js                       
[npmPack] npm notice 2.9kB   esm/models/endpointsMappers.js                    
[npmPack] npm notice 345B    esm/models/index.js                               
[npmPack] npm notice 665B    esm/operations/index.js                           
[npmPack] npm notice 2.4kB   esm/operations/managedRuleSets.js                 
[npmPack] npm notice 2.8kB   esm/models/managedRuleSetsMappers.js              
[npmPack] npm notice 127.9kB esm/models/mappers.js                             
[npmPack] npm notice 2.2kB   esm/operations/operations.js                      
[npmPack] npm notice 475B    esm/models/operationsMappers.js                   
[npmPack] npm notice 12.8kB  esm/operations/originGroups.js                    
[npmPack] npm notice 2.8kB   esm/models/originGroupsMappers.js                 
[npmPack] npm notice 12.3kB  esm/operations/origins.js                         
[npmPack] npm notice 2.8kB   esm/models/originsMappers.js                      
[npmPack] npm notice 3.2kB   esm/models/parameters.js                          
[npmPack] npm notice 9.6kB   esm/operations/policies.js                        
[npmPack] npm notice 2.8kB   esm/models/policiesMappers.js                     
[npmPack] npm notice 15.7kB  esm/operations/profiles.js                        
[npmPack] npm notice 2.8kB   esm/models/profilesMappers.js                     
[npmPack] npm notice 2.5kB   esm/operations/resourceUsageOperations.js         
[npmPack] npm notice 477B    esm/models/resourceUsageOperationsMappers.js      
[npmPack] npm notice 971B    rollup.config.js                                  
[npmPack] npm notice 1.6kB   package.json                                      
[npmPack] npm notice 457B    tsconfig.json                                     
[npmPack] npm notice 553.9kB dist/arm-cdn.js.map                               
[npmPack] npm notice 79.1kB  dist/arm-cdn.min.js.map                           
[npmPack] npm notice 2.1kB   esm/cdnManagementClient.d.ts.map                  
[npmPack] npm notice 3.3kB   esm/cdnManagementClient.js.map                    
[npmPack] npm notice 599B    esm/cdnManagementClientContext.d.ts.map           
[npmPack] npm notice 1.6kB   esm/cdnManagementClientContext.js.map             
[npmPack] npm notice 3.8kB   esm/operations/customDomains.d.ts.map             
[npmPack] npm notice 6.1kB   esm/operations/customDomains.js.map               
[npmPack] npm notice 1.3kB   esm/models/customDomainsMappers.d.ts.map          
[npmPack] npm notice 1.3kB   esm/models/customDomainsMappers.js.map            
[npmPack] npm notice 1.0kB   esm/operations/edgeNodes.d.ts.map                 
[npmPack] npm notice 1.4kB   esm/operations/edgeNodes.js.map                   
[npmPack] npm notice 1.2kB   esm/models/edgeNodesMappers.d.ts.map              
[npmPack] npm notice 1.3kB   esm/models/edgeNodesMappers.js.map                
[npmPack] npm notice 5.7kB   esm/operations/endpoints.d.ts.map                 
[npmPack] npm notice 11.2kB  esm/operations/endpoints.js.map                   
[npmPack] npm notice 1.3kB   esm/models/endpointsMappers.d.ts.map              
[npmPack] npm notice 1.3kB   esm/models/endpointsMappers.js.map                
[npmPack] npm notice 39.3kB  esm/models/index.d.ts.map                         
[npmPack] npm notice 334B    esm/operations/index.d.ts.map                     
[npmPack] npm notice 126B    esm/models/index.js.map                           
[npmPack] npm notice 349B    esm/operations/index.js.map                       
[npmPack] npm notice 1.0kB   esm/operations/managedRuleSets.d.ts.map           
[npmPack] npm notice 1.5kB   esm/operations/managedRuleSets.js.map             
[npmPack] npm notice 1.3kB   esm/models/managedRuleSetsMappers.d.ts.map        
[npmPack] npm notice 1.3kB   esm/models/managedRuleSetsMappers.js.map          
[npmPack] npm notice 5.9kB   esm/models/mappers.d.ts.map                       
[npmPack] npm notice 68.5kB  esm/models/mappers.js.map                         
[npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map                
[npmPack] npm notice 1.4kB   esm/operations/operations.js.map                  
[npmPack] npm notice 225B    esm/models/operationsMappers.d.ts.map             
[npmPack] npm notice 238B    esm/models/operationsMappers.js.map               
[npmPack] npm notice 3.1kB   esm/operations/originGroups.d.ts.map              
[npmPack] npm notice 5.6kB   esm/operations/originGroups.js.map                
[npmPack] npm notice 1.3kB   esm/models/originGroupsMappers.d.ts.map           
[npmPack] npm notice 1.3kB   esm/models/originGroupsMappers.js.map             
[npmPack] npm notice 3.1kB   esm/operations/origins.d.ts.map                   
[npmPack] npm notice 5.6kB   esm/operations/origins.js.map                     
[npmPack] npm notice 1.2kB   esm/models/originsMappers.d.ts.map                
[npmPack] npm notice 1.3kB   esm/models/originsMappers.js.map                  
[npmPack] npm notice 731B    esm/models/parameters.d.ts.map                    
[npmPack] npm notice 2.4kB   esm/models/parameters.js.map                      
[npmPack] npm notice 2.6kB   esm/operations/policies.d.ts.map                  
[npmPack] npm notice 4.8kB   esm/operations/policies.js.map                    
[npmPack] npm notice 1.3kB   esm/models/policiesMappers.d.ts.map               
[npmPack] npm notice 1.3kB   esm/models/policiesMappers.js.map                 
[npmPack] npm notice 4.9kB   esm/operations/profiles.d.ts.map                  
[npmPack] npm notice 8.2kB   esm/operations/profiles.js.map                    
[npmPack] npm notice 1.3kB   esm/models/profilesMappers.d.ts.map               
[npmPack] npm notice 1.3kB   esm/models/profilesMappers.js.map                 
[npmPack] npm notice 1.1kB   esm/operations/resourceUsageOperations.d.ts.map   
[npmPack] npm notice 1.5kB   esm/operations/resourceUsageOperations.js.map     
[npmPack] npm notice 238B    esm/models/resourceUsageOperationsMappers.d.ts.map
[npmPack] npm notice 251B    esm/models/resourceUsageOperationsMappers.js.map  
[npmPack] npm notice 3.1kB   README.md                                         
[npmPack] npm notice 4.6kB   esm/cdnManagementClient.d.ts

openapi-sdkautomation · 2020-07-02T17:35:34Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 21736a1 with merge commit af6cd68. SDK Automation 13.0.17.20200619.4

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Cdn [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Cdn.4.3.0-preview.nupkg
- Microsoft.Azure.Management.Cdn.4.3.0-preview.snupkg

openapi-sdkautomation · 2020-07-02T17:35:53Z

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 21736a1 with merge commit af6cd68. SDK Automation 13.0.17.20200619.4

⚠️azure-mgmt-cdn [View full logs] [Release SDK Changes] Breaking Change Detected

[build_conf] INFO:packaging_tools:Building template azure-mgmt-cdn
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-cdn
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 19.789% size of original (original: 78235 chars, delta: 15482 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model Origin has a new parameter private_endpoint_status
[ChangeLog]   - Model Origin has a new parameter enabled
[ChangeLog]   - Model Origin has a new parameter private_link_location
[ChangeLog]   - Model Origin has a new parameter private_link_alias
[ChangeLog]   - Model Origin has a new parameter private_link_approval_message
[ChangeLog]   - Model Origin has a new parameter origin_host_header
[ChangeLog]   - Model Origin has a new parameter weight
[ChangeLog]   - Model Origin has a new parameter priority
[ChangeLog]   - Model Origin has a new parameter private_link_resource_id
[ChangeLog]   - Model EndpointUpdateParameters has a new parameter url_signing_keys
[ChangeLog]   - Model EndpointUpdateParameters has a new parameter default_origin_group
[ChangeLog]   - Model Endpoint has a new parameter url_signing_keys
[ChangeLog]   - Model Endpoint has a new parameter origin_groups
[ChangeLog]   - Model Endpoint has a new parameter default_origin_group
[ChangeLog]   - Added operation OriginsOperations.create
[ChangeLog]   - Added operation OriginsOperations.delete
[ChangeLog]   - Added operation group OriginGroupsOperations
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog]   - Model CustomDomain no longer has parameter custom_https_parameters
[ChangeLog]   - Model DeepCreatedOrigin has a new signature
[ChangeLog]   - Model OriginUpdateParameters has a new signature

openapi-sdkautomation · 2020-07-02T17:36:54Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azuresdkci · 2020-07-02T18:04:02Z

Can one of the admins verify this patch?

weidongxu-microsoft · 2020-07-03T02:31:15Z

Let me know if the lint error can be fixed. Or it would need code owner's help.

fore5fire · 2020-07-08T16:45:07Z

@weidongxu-microsoft, these linter errors are existing issues that are getting flagged as new because of the change in API version, and fixing them is beyond the scope of this PR. Can we merge this PR and plan to fix those issues in a future PR?

weidongxu-microsoft · 2020-07-09T02:00:14Z

@weidongxu-microsoft, these linter errors are existing issues that are getting flagged as new because of the change in API version, and fixing them is beyond the scope of this PR. Can we merge this PR and plan to fix those issues in a future PR?

@akning-ms Hello Arthur, are you OK to merge it? No change in spec, all lint issue is existing ones.

akning-ms · 2020-07-09T14:31:08Z

Hi @lsmith130, Can I know why you change this default tag to new version? it is for release SDK? if yes. suggest you to fix the lint error first. otherwise, it will cause more impact for customer if change after sdk release. as fix the linter error may change breaking change

azure-pipelines · 2020-07-09T20:02:02Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-07-09T20:03:40Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

fore5fire · 2020-07-09T20:28:22Z

@akning-ms, I've fixed the warnings that can be done reasonably, and the errors are saying that the error response format doesn't match the standard, which is incorrect. Our error format does match the standard, and changes to the error format would be a breaking change for all existing resource types.

The only remaining warnings that cannot be fixed later are the warnings that enums should be used as booleans, but because these warnings were not enforced before merging the original PR that introduced them, we've already done substantial engineering effort on the assumption that the boolean fields are acceptable. Can we move forward with this PR or do I need to convince my team to make updates to multiple accepted API versions and redo work in our RP that is already tested and working?

akning-ms · 2020-07-10T12:35:34Z

Thanks for clarify, @lsmith130 make sense, LGTM if you have plan to fix it.

* Update CDN default api version to 2020-04-15 * Add missing CDN x-ms-enum fields for url signing.

openapi-assignment-bot bot assigned weidongxu-microsoft Jul 2, 2020

weidongxu-microsoft approved these changes Jul 3, 2020

View reviewed changes

fore5fire added 2 commits July 9, 2020 12:49

Update CDN default api version to 2020-04-15

0b4a631

Add missing CDN x-ms-enum fields for url signing.

21736a1

fore5fire force-pushed the cdn/2020-04-15 branch from 0a5e7f7 to 21736a1 Compare July 9, 2020 20:01

openapi-sdkautomation bot mentioned this pull request Jul 9, 2020

[AutoPR sdk/cdn/mgmt-v2020_04_15] Update CDN default api version to 2020-04-15. AzureSDKAutomation/azure-sdk-for-java#3444

Closed

akning-ms merged commit af6cd68 into Azure:master Jul 10, 2020

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

Update CDN default api version to 2020-04-15. (Azure#10026)

4859bab

* Update CDN default api version to 2020-04-15 * Add missing CDN x-ms-enum fields for url signing.

Update CDN default api version to 2020-04-15. #10026

Update CDN default api version to 2020-04-15. #10026

Uh oh!

Conversation

fore5fire commented Jul 2, 2020

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-pipeline-app bot commented Jul 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Staging] Swagger Validation Report

Uh oh!

azure-pipelines bot commented Jul 2, 2020

Uh oh!

openapi-sdkautomation bot commented Jul 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Azure CLI Extension Generation - Release

Uh oh!

openapi-sdkautomation bot commented Jul 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Jul 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Jul 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Jul 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Jul 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

- Breaking Change detected in SDK

Uh oh!

openapi-sdkautomation bot commented Jul 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Trenton Generation - Release

Uh oh!

azuresdkci commented Jul 2, 2020

Uh oh!

weidongxu-microsoft commented Jul 3, 2020

Uh oh!

fore5fire commented Jul 8, 2020

Uh oh!

weidongxu-microsoft commented Jul 9, 2020

Uh oh!

akning-ms commented Jul 9, 2020

Uh oh!

azure-pipelines bot commented Jul 9, 2020

Uh oh!

openapi-sdkautomation bot commented Jul 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python-track2 - Release

Uh oh!

fore5fire commented Jul 9, 2020

Uh oh!

akning-ms commented Jul 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

openapi-pipeline-app bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 9, 2020 •

edited

Loading