[ReleasePR consumption] [Hub Generated] Review request for Microsoft.Consumption to add version stable/2021-10-01#1944
Merged
1 commit merged intoAzure:mainfrom Oct 1, 2021
Conversation
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2021-10-01 (#15958) * Adds base for updating Microsoft.Consumption from version stable/2021-05-01 to version 2021-10-01 * Updates readme * Updates API version in new specs and examples * added benefitid and benefitname * adding descr for benefitid and benefitname * Deprecate Forecasts * added provider in modern * Adding description for the provider * 1) removed BenefitId and BenefitName from legacy 2) chnaged value of Publishertype fro 1pp to Microsoft 3) updated examples with ReservationName and BenefitId and BeneftName for modern * Make changes based on s360 * Fix example errors * Missed an instance of purchaseDate type * No schema for 204 * No schema for 204 * No schema for 204 * Ran prettier * Add changes to 10.01.21 * Ran prettier * Revert "Ran prettier" This reverts commit 1a0fbfe4a2b0583a3db0b4f985a5857925763958. * Revert "No schema for 204" This reverts commit 181f6c5af6add248619fbb558f59e7bb3820075d. * Revert "Missed an instance of purchaseDate type" This reverts commit d77898dcf5ec20620a84e5ec51bcb1b93df54d82. * Revert "Fix example errors" This reverts commit 06be042e08acb88232b46d80b77bdf4dad48dde1. * Revert "Make changes based on s360" This reverts commit 0960cc2078504e76328811f9eb9f5be1a25e1f2d. * Manually change 2021-05-01 * removing reservationName * costAllocationRule * Adding missing fields * Operation scopeReservationRecommendationDetails had two params with the same name scope, so fixing it. * chnaging the casing for eTag * chnaging the casing for eTag * reservation api * Arm feedback - add enum to PricingModel * pretty check * linter check * pretty check Co-authored-by: Mita Garg <v-migarg@microsoft.com> Co-authored-by: Alex Goldschmidt <algoldsc@microsoft.com>
25 tasks
ghost
approved these changes
Oct 1, 2021
ghost
left a comment
There was a problem hiding this comment.
This PR has been auto-approved by the @msftbot for the azure-resource-manager-schemas repo.
|
Hello @msftbot[bot]! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 1 minute. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create to sync Azure/azure-rest-api-specs#15958
ReCreate this PR