Skip to content

cmdlets for MI Sync scenario #8461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cormacpayne merged 9 commits into from
Feb 13, 2019
Merged

cmdlets for MI Sync scenario #8461

cormacpayne merged 9 commits into from
Feb 13, 2019

Conversation

@sichoudh
Copy link
Contributor

@sichoudh sichoudh commented Feb 1, 2019 •
edited
Loading

Description

Checklist

@adxsdkps
Copy link
Collaborator

adxsdkps commented Feb 1, 2019

Can one of the admins verify this patch?

@vladimir-shcherbakov
Copy link
Contributor

vladimir-shcherbakov commented Feb 1, 2019 •
edited
Loading

@azuresdkci Add to whitelist

2 similar comments
@vladimir-shcherbakov
Copy link
Contributor

vladimir-shcherbakov commented Feb 1, 2019

@azuresdkci Add to whitelist

@maddieclayton
Copy link
Contributor

maddieclayton commented Feb 2, 2019

@azuresdkci Add to whitelist

@vladimir-shcherbakov
Copy link
Contributor

vladimir-shcherbakov commented Feb 4, 2019

@sichoudh ci-build has failed.

@vladimir-shcherbakov
Copy link
Contributor

vladimir-shcherbakov commented Feb 5, 2019

@sichoudh For public API changes to cmdlets the changes should go through a cmdlet design review (Microsoft internal partners only)

haitsongmsft
haitsongmsft previously approved these changes Feb 7, 2019
View reviewed changes
cormacpayne
cormacpayne suggested changes Feb 8, 2019
View reviewed changes
@cormacpayne cormacpayne assigned sichoudh and unassigned cormacpayne Feb 8, 2019
@cormacpayne cormacpayne merged commit 8c3b2d1 into Azure:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hitenjava hitenjava Awaiting requested review from hitenjava

@ash1625 ash1625 Awaiting requested review from ash1625

2 more reviewers

@cormacpayne cormacpayne cormacpayne approved these changes

@haitsongmsft haitsongmsft haitsongmsft left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@cormacpayne cormacpayne

Labels

needs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sichoudh @adxsdkps @vladimir-shcherbakov @maddieclayton @cormacpayne @haitsongmsft @azuresdkci