[Test Controller] New test controller applied to Network #8281
Conversation
There was a problem hiding this comment.
Why were the generated scenario tests moved up a directory? They put them there so that only generated tests are in that folder, and they manage non-generated tests in the ScenarioTests folder.
There was a problem hiding this comment.
I agreed these changes with the Network team
src/Network/Network.Test/ScenarioTests/ExpressRouteCircuitTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Why is this file deleted? They use a generator to create some of their tests. I'm assuming this file is used by their generator.
There was a problem hiding this comment.
I agreed these changes with the Network team
There was a problem hiding this comment.
This captures the commit for the source script they used to generate the tests, so we should leave it, I think
There was a problem hiding this comment.
@EvgenyAgafonchikov Can you confirm you need the metadata?
There was a problem hiding this comment.
I discussed this offline with @EvgenyAgafonchikov:
AFAIK PS team plans to use their own cmdlets generator, so we are dropping support of ours. In this context removing of this file is okay.
There was a problem hiding this comment.
That doesn't apply until we are actually using a new generator.
vladimir-shcherbakov
force-pushed
the
tc-core-network
branch
from
8242a8d to
f66c68d
Compare
vladimir-shcherbakov
added
needs-review
and removed
Merge Conflicts
needs-revision
labels
|
@MikhailTryakhov We are applying a new test controller - could you take a look? |
EvgenyAgafonchikov
left a comment
EvgenyAgafonchikov
left a comment
There was a problem hiding this comment.
Left comment on module reference. Otherwise LGTM.
|
@MiYanni Are you ready to sign off? |
|
@vladimir-shcherbakov Please reassign to someone else. Thanks. |
| TestRunner.RunTestScript("Test-FlowLog"); | ||
| } | ||
|
|
||
| #if NETSTANDARD |
There was a problem hiding this comment.
We should remove this #if - we are awlays in NetStandard
There was a problem hiding this comment.
This captures the commit for the source script they used to generate the tests, so we should leave it, I think
# Conflicts: # src/Network/Network.Test/NetworkResourcesController.cs
There was a problem hiding this comment.
That doesn't apply until we are actually using a new generator.
7 participants
Description
Checklist
CONTRIBUTING.mdplatyPSmodule