Skip to content

Update header for module manifest files and AzureRM.Example.psm1 file #7496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MiYanni merged 2 commits into from
Oct 12, 2018
Merged

Update header for module manifest files and AzureRM.Example.psm1 file #7496

MiYanni merged 2 commits into from
Oct 12, 2018

Conversation

@cormacpayne
Copy link
Member

@cormacpayne cormacpayne commented Oct 8, 2018 •
edited
Loading

Description

Fix for #7432

  • Change header in module manifest files from PSGet_MODULE to just MODULE
  • Change message in AzureRM.Example.psm1 that is used for each module's .psm1 file

Checklist

@cormacpayne
Copy link
Member Author

cormacpayne commented Oct 8, 2018

Sign job: https://azuresdkci.westus2.cloudapp.azure.com/job/ps-sign/1435/

maddieclayton
maddieclayton previously approved these changes Oct 11, 2018
View reviewed changes
MiYanni
MiYanni suggested changes Oct 12, 2018
View reviewed changes
src/ResourceManager/Aks/Commands.Aks/Az.Aks.psd1 Outdated
@@ -1,5 +1,5 @@
#
# Module manifest for module 'PSGet_AzureRM.Aks'
# Module manifest for module 'AzureRM.Aks'
Copy link
Contributor

@MiYanni MiYanni Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the Az psd1 file headers say Az.Aks?

Copy link
Member Author

@cormacpayne cormacpayne Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good catch. Will update.

@MiYanni MiYanni assigned cormacpayne and unassigned maddieclayton Oct 12, 2018
@cormacpayne cormacpayne assigned MiYanni and unassigned cormacpayne Oct 12, 2018
MiYanni
MiYanni approved these changes Oct 12, 2018
View reviewed changes
Copy link
Contributor

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiYanni MiYanni removed their assignment Oct 12, 2018
@MiYanni MiYanni merged commit 3e2b43a into Azure:preview Oct 12, 2018
@cormacpayne cormacpayne deleted the cleanup-metadata branch October 15, 2018 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@MiYanni MiYanni MiYanni approved these changes

@maddieclayton maddieclayton maddieclayton left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Waiting for CI :shipit:

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cormacpayne @maddieclayton @MiYanni @azuresdkci1x