Fix Get-AzureRmSubscription issue in CloudShell #7493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
added 2 commits
October 11, 2018 13:07
markcowl
approved these changes
Oct 12, 2018
| { | ||
| var subscriptions = _client.ListSubscriptions(tenant); | ||
| WriteObject(subscriptions.Select((s) => new PSAzureSubscription(s)), enumerateCollection: true); | ||
| if (DefaultContext.Account.Type.Equals("ManagedService")) |
Member
There was a problem hiding this comment.
Please file an issue to add some automation for this - we have the infrastructure to mock managed service tests, and we should have some regression protection for thsi scenario.
Please make sure you have tested this in CloudShell. LMK if you need some help in doign this.
Member
|
@maddieclayton Please file the issue for automated mocked tests for this |
Contributor
Author
|
Test coverage issue here: #7536 I did test is on CloudShell and everything worked as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#7360
Checklist
CONTRIBUTING.mdplatyPSmodule