Skip to content

Conversation

@junyezhu
Copy link
Contributor

@junyezhu junyezhu commented Oct 5, 2018

Description

Checklist

@cormacpayne
Copy link
Member

@junyezhu what is being changed in this PR? Please add a snippet to the Network change log with an overview of what you're changing

@adxsdkps
Copy link
Collaborator

adxsdkps commented Oct 5, 2018

Can one of the admins verify this patch?

@cormacpayne
Copy link
Member

@azuresdkci add to whitelist

@junyezhu
Copy link
Contributor Author

junyezhu commented Oct 5, 2018

@cormacpayne added. We found out although we already added protocolConfiguration, we didn't pass any protocol value into backend.

Copy link
Contributor

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junyezhu I've put the changelog update into the correct changelog. I removed it from the Resources changelog and put it into the Network changelog as @cormacpayne instructed.

@MiYanni MiYanni dismissed cormacpayne’s stale review October 12, 2018 21:22

Requested changes have been addressed.

@MiYanni MiYanni merged commit 8b91a28 into Azure:preview Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants