Add DnsZonePartner Parameter for New-AzureRmSqlManagedInstance cmdlet #7458

ziwa-msft · 2018-10-03T19:09:49Z

Description

Add DnsZonePartner Parameter for New-AzureRmSqlManagedInstance cmdlet to support AutoDr for Managed Instance. Properties of the ManagedInstance model have also been updated to reflect new members DnsZone and DnsZonePartner

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review
- the cmdlet markdown files were generated using the platyPS module

ziwa-msft · 2018-10-03T19:10:59Z

Link to .NetSDK: Azure/azure-sdk-for-net#4801

ziwa-msft · 2018-10-03T19:12:50Z

I added the references to new ClientRuntime packages per advice from Maddie. I was seeing local failures due to package mismatch and reached out for help. She mentioned that there is a ClientRuntime upgrade ongoing and I should add these references for now to unblock testing.

jaredmoo · 2018-10-03T19:30:18Z

src/ResourceManager/Network/Commands.Network/Commands.Network.csproj

    <Reference Include="Microsoft.Azure.Management.Network, Version=19.5.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
      <HintPath>..\..\..\packages\Microsoft.Azure.Management.Network.19.5.0-preview\lib\net452\Microsoft.Azure.Management.Network.dll</HintPath>
    </Reference>
+    <Reference Include="Newtonsoft.Json, Version=6.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL" />


I don't think that we should need to change Commands.Network or Commands.Profile . Were these changes intentional?

it was auto-generated due to the new package version. reverting now.

jaredmoo · 2018-10-03T19:31:38Z

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/ManagedInstanceCrudScenarioTests.ps1

 	$managedInstanceLogin = "dummylogin"
 	$managedInstancePassword = "Un53cuRE!"
- 	$subnetId = "/subscriptions/ee5ea899-0791-418f-9270-77cd8273794b/resourceGroups/cl_one/providers/Microsoft.Network/virtualNetworks/cl_initial/subnets/CooL"
+ 	$subnetId = "/subscriptions/a8c9a924-06c0-4bde-9788-e7b1370969e1/resourceGroups/mi-wcus-demo-rg/providers/Microsoft.Network/virtualNetworks/mi-wcus-vnet/subnets/mi-subnet-managed-instances"


Since MI is in GA now, can you please change this test to be fully automated? This includes creating the virtual network. Check out SQL virtual network firewall rules for an example.

cormacpayne

@ziwa-msft a few comments for you to take a look at

cormacpayne · 2018-10-05T23:25:26Z

src/ResourceManager/Profile/Commands.Profile/Commands.Profile.csproj

      <LastGenOutput>Resources.Designer.cs</LastGenOutput>
    </EmbeddedResource>
  </ItemGroup>
+  <ItemGroup>


@ziwa-msft please revert the change made in this file

cormacpayne · 2018-10-05T23:25:49Z

src/ResourceManager/Profile/Commands.Profile/packages.config

  <package id="Microsoft.PowerShell.5.ReferenceAssemblies" version="1.1.0" targetFramework="net452" />
-  <package id="Microsoft.Rest.ClientRuntime" version="2.3.13" targetFramework="net452" />
-  <package id="Microsoft.Rest.ClientRuntime.Azure" version="3.3.15" targetFramework="net452" />
+  <package id="Microsoft.Rest.ClientRuntime" version="2.3.14" targetFramework="net452" />


@ziwa-msft please revert the change made in this file -- we have a separate PR open to update the version of ClientRuntime used throughout PowerShell

cormacpayne · 2018-10-05T23:26:24Z

src/ResourceManager/Sql/Commands.Sql.Test/Commands.Sql.Test.csproj

    <Reference Include="Microsoft.Azure.Management.Storage">
      <HintPath>..\..\..\packages\Microsoft.Azure.Management.Storage.2.4.0-preview\lib\net40\Microsoft.Azure.Management.Storage.dll</HintPath>
    </Reference>
+    <Reference Include="Microsoft.Rest.ClientRuntime, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">


@ziwa-msft please remove these references to ClientRuntime added in this file

cormacpayne · 2018-10-05T23:26:59Z

src/ResourceManager/Sql/Commands.Sql.Test/packages.config

  <package id="Microsoft.Bcl.Build" version="1.0.14" targetFramework="net45" />
  <package id="Microsoft.IdentityModel.Clients.ActiveDirectory" version="2.28.3" targetFramework="net45" />
  <package id="Microsoft.Net.Http" version="2.2.28" targetFramework="net45" />
+  <package id="Microsoft.Rest.ClientRuntime" version="2.3.14" targetFramework="net452" />


@ziwa-msft same comment about removing the references to ClientRuntime in this file

cormacpayne · 2018-10-05T23:27:52Z

src/ResourceManager/Sql/Commands.Sql/Commands.Sql.csproj

    <Reference Include="Microsoft.Data.Services.Client, Version=5.8.1.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
      <HintPath>..\..\..\packages\Microsoft.Data.Services.Client.5.8.2\lib\net40\Microsoft.Data.Services.Client.dll</HintPath>
    </Reference>
+    <Reference Include="Microsoft.Rest.ClientRuntime, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">


@ziwa-msft same comment about removing the references to ClientRuntime in this file

cormacpayne · 2018-10-05T23:29:15Z

src/ResourceManager/Sql/Commands.Sql/packages.config

  <package id="Microsoft.Data.Edm" version="5.8.2" targetFramework="net452" />
  <package id="Microsoft.Data.OData" version="5.8.2" targetFramework="net452" />
  <package id="Microsoft.Data.Services.Client" version="5.8.2" targetFramework="net452" />
+  <package id="Microsoft.Rest.ClientRuntime" version="2.3.14" targetFramework="net452" />


@ziwa-msft same comment about removing the references to ClientRuntime in this file

cormacpayne · 2018-10-05T23:30:38Z

src/ResourceManager/Sql/LegacySdk/SqlManagement.csproj

      <Name>Commands.Profile</Name>
    </ProjectReference>
  </ItemGroup>
+  <ItemGroup>


@ziwa-msft please revert the changes in this file -- you don't need to add a reference to ClientRuntime and I was under the impression since this was a generation of the old Sql SDK that you don't need a reference to the new Sql management SDK.

cormacpayne · 2018-10-05T23:30:53Z

src/ResourceManager/Sql/LegacySdk/packages.config

 <packages>
  <package id="Hyak.Common" version="1.0.3" targetFramework="net45" />
  <package id="Microsoft.Azure.Common" version="2.1.0" targetFramework="net45" />
+  <package id="Microsoft.Azure.Management.Sql" version="1.20.1-preview" targetFramework="net452" />


@ziwa-msft same comment about reverting the changes made in this file

ziwa-msft · 2018-10-11T00:29:03Z

@jaredmoo @cormacpayne Please review and let me know if there is any other feedback

cormacpayne · 2018-10-15T19:56:04Z

PR to merge in the latest from preview: #7574

cormacpayne · 2018-10-16T18:12:25Z

@ziwa-msft some build failures for you to look at:

Jenkins

The .json files associated with the tests found in ManagedInstanceCrudScenarioTests.cs are not being copied to the output directory in the .csproj file.

Travis

The version of the Microsoft.Azure.Management.Sql package was not updated in the Commands.Sql.Test.Netcore file.

… into dnsZone

ziwa-msft · 2018-10-18T19:18:00Z

@cormacpayne Hi Cormac. Looks like the default build failed because of CredScan issue. Any suggestion on how to proceed?

ziwa-msft · 2018-10-19T20:58:57Z

@cormacpayne Looks like all checks have passed finally ;D

cormacpayne · 2018-10-19T22:54:04Z

src/ResourceManager/Sql/Commands.Sql/ChangeLog.md


 ## Version 4.11.5
 * Fixed issue where some backup cmdlets would not recognize the current azure subscription
+* Add DnsZonePartner Parameter for New-AzureRmSqlManagedInstance cmdlet to support AutoDr for Managed Instance.


@ziwa-msft this should go under the ## Current Release header, but we can move it when we do the versioning for the next release of this preview module

ziwa-msft added 7 commits September 21, 2018 15:38

Fix Wrong Partner RG name For Instance Failover Group Creation

b087567

Adding DnsZonePartner Parameter to NewAzureSqlManagedInstance cmdlet

f2e0ea0

Updating .NetSDK Package to 1.20.1-preview

983fbec

Merge changes from remote

a8fc1c7

Test changes for DnsZone

f57e6da

Add Test Recordings For MI Creation

9dd9c95

Update ChangeLog and Markdown Files

b22b5f4

azuresdkci1x added the needs-review label Oct 3, 2018

jaredmoo suggested changes Oct 3, 2018

View reviewed changes

maddieclayton added needs-revision and removed needs-review labels Oct 3, 2018

maddieclayton assigned ziwa-msft Oct 3, 2018

cormacpayne suggested changes Oct 5, 2018

View reviewed changes

ziwa-msft added 3 commits October 8, 2018 16:10

Add Test Automation For VNet Creation in MI

19d125d

Reverting ClientRuntime References

1331415

Updating .NetCore Project Reference To New SDK

961026e

jaredmoo approved these changes Oct 11, 2018

View reviewed changes

Merge branch 'AzureRM.Sql-preview' into dnsZone

05fef30

ziwa-msft added 3 commits October 16, 2018 18:02

Fix missing references in MSBuild for test file and sdk

8bb302f

Merge branch 'dnsZone' of https://github.com/ziwa-msft/azure-powershell…

8bd4b91

… into dnsZone

Fix Session Records Path

eb145c8

Suppressing CredScan messages

2bda910

cormacpayne reviewed Oct 19, 2018

View reviewed changes

cormacpayne approved these changes Oct 19, 2018

View reviewed changes

cormacpayne merged commit df17ae8 into Azure:AzureRM.Sql-preview Oct 19, 2018

ziwa-msft mentioned this pull request Apr 25, 2019

Adding DnsZone Partner to New-SqlInstance cmdlet #9088

Merged

1 task

Add DnsZonePartner Parameter for New-AzureRmSqlManagedInstance cmdlet #7458

Add DnsZonePartner Parameter for New-AzureRmSqlManagedInstance cmdlet #7458

Uh oh!

Conversation

ziwa-msft commented Oct 3, 2018

Description

Checklist

Uh oh!

ziwa-msft commented Oct 3, 2018

Uh oh!

ziwa-msft commented Oct 3, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cormacpayne left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ziwa-msft commented Oct 11, 2018

Uh oh!

cormacpayne commented Oct 15, 2018

Uh oh!

cormacpayne commented Oct 16, 2018

Jenkins

Travis

Uh oh!

ziwa-msft commented Oct 18, 2018

Uh oh!

ziwa-msft commented Oct 19, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants