Remove SiteRecovery psd1 for Az #7457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markcowl
requested changes
Oct 8, 2018
...ecoveryServices/Commands.RecoveryServices.SiteRecovery/Az.RecoveryServices.SiteRecovery.psd1
Show resolved
Hide resolved
...ecoveryServices/Commands.RecoveryServices.SiteRecovery/Az.RecoveryServices.SiteRecovery.psd1
Show resolved
Hide resolved
...ecoveryServices/Commands.RecoveryServices.SiteRecovery/Az.RecoveryServices.SiteRecovery.psd1
Show resolved
Hide resolved
...ecoveryServices/Commands.RecoveryServices.SiteRecovery/Az.RecoveryServices.SiteRecovery.psd1
Show resolved
Hide resolved
# Conflicts: # src/ResourceManager/RecoveryServices/Commands.RecoveryServices.SiteRecovery/Az.RecoveryServices.SiteRecovery.psd1 # tools/StaticAnalysis/StaticAnalysis.Netcore.csproj
Contributor
Author
|
@azuresdkci Retest this please |
1 similar comment
Contributor
Author
|
@azuresdkci Retest this please |
4 tasks
markcowl
reviewed
Oct 12, 2018
src/ResourceManager/RecoveryServices/Commands.RecoveryServices/Az.RecoveryServices.psd1
Show resolved
Hide resolved
markcowl
approved these changes
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The psd1 for SiteRecovery shouldn't exist for Az as those cmdlets are part of the RecoveryServices module.
This PR also moves StaticAnalysis (Az) into Package with everything else. And, fixes a StaticAnalysis issue.
Checklist
CONTRIBUTING.mdplatyPSmodule