Skip to content

FW: Adding cmdlets for creating and deleting AD application & service principal #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
perseusCode wants to merge 54 commits into from
Closed

FW: Adding cmdlets for creating and deleting AD application & service principal #74

perseusCode wants to merge 54 commits into from

Conversation

@perseusCode
Copy link

@perseusCode perseusCode commented Jan 8, 2015

This change contains following four cmdlets :-

a) New-AzureADApplication
b) Remove-AzureADApplication
c) New-AzureADServicePrincipal
d) Remove-AzureADServicePrincipal

These cmdlets are needed to maintain AD service princiapals. Tests for the same have also been added.

ogail and others added 12 commits December 4, 2014 09:13
@ogail
Merge pull request Azure#7 from ogail/master
fdfee61 
Merge public master
@akromm-zz
Added some service objectives to the list.
b7dfdd5 
Added service objective information to Database object.
Ensured exclusivity of parameters for get database operation
@akromm-zz
Updating mock sessions file for v12 tests. Updated v12 connection con…
aa6bdc9 
…text.
@akromm-zz
Merge branch 'dev' of https://github.com/azure/azure-powershell into …
359439f 
…dev-sql-fixes
@jtlibingus
Merge pull request Azure#4 from Azure/dev
82901a0 
merge from azure/azure-powershell/dev
@akromm-zz
Fixing a failing test.
b5af664
@EmmaZhu
Add new cmdlets for storage SAS token stored policy.
e211c63
@akromm-zz
Merge branch 'dev' of https://github.com/Azure/azure-powershell-pr in…
6d45858 
…to dev-sql-fixes
@akromm-zz
Merge branch 'dev' of https://github.com/Azure/azure-powershell-pr in…
ce380c5 
…to dev-sql-fixes
@ogail
Merge pull request Azure#22 from EmmaZhu/dev
5c78199 
Add new cmdlets for storage SAS token stored policy.
@ogail
Merge pull request Azure#25 from akromm/dev-sql-fixes
2c3592f 
Dev sql fixes
FW: Adding cmdlets for creating and deleting AD application &
c77f6e8 
servicePrincipal
@azuresdkci
Copy link

azuresdkci commented Jan 8, 2015

Can one of the admins verify this patch?

@azurecla
Copy link

azurecla commented Jan 8, 2015

Hi @perseusCode, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (mansikka). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@ogail
Copy link
Contributor

ogail commented Jan 9, 2015

add to whitelist

ogail
ogail reviewed Jan 9, 2015
View reviewed changes
...ResourceManager/Resources/Commands.Resources/ActiveDirectory/NewAzureADApplicationCommand.cs Outdated
Copy link
Contributor

@ogail ogail Jan 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we don't use _ convention in PowerShell

@ogail
Copy link
Contributor

ogail commented Jan 12, 2015

retest this please

@perseusCode
Copy link
Author

perseusCode commented Jan 12, 2015

Didn't get your comment, do you want me to run the unit tests again ?

@ogail
Copy link
Contributor

ogail commented Jan 12, 2015

@perseusCode that's a comment for the CI to kickoff the build again. Apparently it failed so please fix it.

@perseusCode
Copy link
Author

perseusCode commented Jan 13, 2015

The build break is because Microsoft.Graph.RBAC.dll 1.4 onwards are not compatible with Azure powershell. The SDK needs to be fixed to generate proper MAML library.

jtlibingus and others added 3 commits January 13, 2015 20:02
@jtlibingus
Upgrade the Microsoft.DataTransfer.Gateway.Encryption nuget package t…
1b01ad7 
…o version 1.2.1
@jtlibingus
Merge branch 'dev' of https://github.com/azure/azure-powershell into …
159c740 
…dev5
@ogail
Merge pull request Azure#82 from jtlibing/dev5
fe9bb87 
Add 'type' parameter in cmdlet New-AzureDataFactoryEncryptValue for supporting file linked service encryption
@ogail
Copy link
Contributor

ogail commented Jan 13, 2015

retest this please

unknown added 14 commits January 13, 2015 13:33
FW: Adding cmdlets for creating and deleting AD application &
2de6931 
servicePrincipal
FW: Re-recording the Test-GetAzureADUserWithUPN.
e7eff28
FW: Adressing comments from ogail. Using constructor to set default
0d56c55 
parameters.
FW: Adding cmdlets for creating and deleting AD application &
7819550 
servicePrincipal
FW: Getting rid of build and test failures after merge.
471f0a0
Merge branch 'master' of https://github.com/perseusCode/azure-powershell
4ea884d 


Conflicts:
	src/ResourceManager/Resources/Commands.Resources.Test/Commands.Resources.Test.csproj
	src/ResourceManager/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestGetADUserWithUPN.json
	src/ResourceManager/Resources/Commands.Resources/ActiveDirectory/NewAzureADApplicationCommand.cs
	src/ResourceManager/Resources/Commands.Resources/Commands.Resources.csproj
	src/ResourceManager/Resources/Commands.Resources/Models.ActiveDirectory/ActiveDirectoryClient.cs
	src/ResourceManager/Resources/Commands.Resources/packages.config
FW: Adding cmdlets for creating and deleting AD application &
d366494 
servicePrincipal
FW: Re-recording the Test-GetAzureADUserWithUPN.
72442fb
FW: Adressing comments from ogail. Using constructor to set default
84726a0 
parameters.
FW: Adding cmdlets for creating and deleting AD application &
ba61a3c 
servicePrincipal
FW: Adressing comments from ogail. Using constructor to set default
8901c05 
parameters.
FW: Adding cmdlets for creating and deleting AD application &
7d1b492 
servicePrincipal
FW: Getting rid of build and test failures after merge.
a6f4a4f
Merge branch 'master' of https://github.com/perseusCode/azure-powershell
af3f5e5 


Conflicts:
	src/ResourceManager/Resources/Commands.Resources/ActiveDirectory/NewAzureADApplicationCommand.cs
@perseusCode
Copy link
Author

perseusCode commented Jan 15, 2015

Closing this as this PR is against master.

hyonholee referenced this pull request in hyonholee/azure-powershell Sep 4, 2015
@huangpf
Merge pull request AzureRT#74 from Azure/dev
1a2d326 
.
hovsepm pushed a commit that referenced this pull request Feb 4, 2016
@huangpf
Merge pull request #74 from huangpf/dev
fc106cc 
Dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@perseusCode @azuresdkci @azurecla @ogail @akromm-zz @jtlibingus @EmmaZhu @markcowl @stankovski