Reservations RP 2018-06-01: Add CosmosDb in reserved resource enum type. Add name property in PatchProperties #7126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update AzureStack.Compute.Admin powershell quota object to support two additional managed disk parameters
…pe enum. Add name property in the PatchProperties
…pe. Add name property in Patch Properties
Author
|
Working on resolving the CI failure |
Member
|
@luluRagdoll Why did you add me and Bala as reviewers? Is this in Azure Stack? |
Author
|
You two were suggested as the reviewers in the PR reviewer section after I submitted this PR. |
Member
|
@luluRagdoll We only review for Azure Stack. I removed us, you should add @maddieclayton/ @cormacpayne/@MiYanni |
Contributor
|
@luluRagdoll Not sure how, but looks like you picked up a bunch of changes from Stack. Can you rebase so only your changes are added? |
Contributor
|
@luluRagdoll please link your cmdlet design review from here: https://github.com/Azure/azure-powershell-cmdlet-review-pr |
Contributor
|
Closing in favor of: #7164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add CosmosDb in reserved resource enum type.
Add name property in PatchProperties
Checklist
CONTRIBUTING.mdplatyPSmodule