added global reach flag in New-AzureExpressRouteCircuit cmdlet #6845
added global reach flag in New-AzureExpressRouteCircuit cmdlet #6845syfarogh wants to merge 5 commits intoAzure:network-august-releasefrom
Conversation
| Mandatory = false, | ||
| ValueFromPipelineByPropertyName = true)] | ||
| [ValidateNotNullOrEmpty] | ||
| public bool AllowGlobalReach { get; set; } |
There was a problem hiding this comment.
Boolean parameters are discouraged. You should use a SwitchParameter instead.
| [ValidateNotNullOrEmpty] | ||
| public bool? AllowClassicOperations { get; set; } | ||
|
|
||
| [Parameter( |
There was a problem hiding this comment.
You should ensure the new parameter is covered in one of your tests
There was a problem hiding this comment.
I've updated an existing test to test this flag.
|
@syfarogh Code complete is today (8/6) Please make requested changes by EOD if you would like this PR in this release. |
|
The test is failing because it requires SDK generated from swagger network-august-release. |
markcowl
left a comment
markcowl
left a comment
There was a problem hiding this comment.
Tests failing - need to be re-recorded
|
|
||
| # Create the ExpressRouteCircuit | ||
| $circuit = New-AzureRmExpressRouteCircuit -Name $circuitName -Location $location -ResourceGroupName $rgname -SkuTier Standard -SkuFamily MeteredData -ServiceProviderName "equinix" -PeeringLocation "Silicon Valley" -BandwidthInMbps 500; | ||
| $circuit = New-AzureRmExpressRouteCircuit -Name $circuitName -Location $location -ResourceGroupName $rgname -SkuTier Standard -SkuFamily MeteredData -ServiceProviderName "equinix" -PeeringLocation "Silicon Valley" -BandwidthInMbps 500 -AllowGlobalReach; |
There was a problem hiding this comment.
Looks like you will need to re-record tests for this
|
@syfarogh Ping |
|
Closing per offline conversation that @syfarogh will open a new PR targeting a different branch. |
4 participants
Description
added global reach flag in New-AzureExpressRouteCircuit cmdlet to toggle Global reach feature on a circuit.
Checklist
CONTRIBUTING.mdplatyPSmodule