Skip to content

Conversation

@ahamad-MS
Copy link
Contributor

@ahamad-MS ahamad-MS commented Jun 8, 2018

Description

This PR fixes #6331. In this issue, customer has a need to update parameters (SubjectBeginsWith) or (SubjectEndsWith) in Update-AzureRmEventGridSubscription cmdlet with empty string. ValidateNotNullOrEmpty validation on these parameters disallows this operation and needs to be removed as they are preventing legitimate operation.

Checklist

@maddieclayton
Copy link
Contributor

@ahamad-MS Do we want to remove this empty check on New-AzureRmEventGridSubscription as well?

@ahamad-MS
Copy link
Contributor Author

ahamad-MS commented Jun 8, 2018

@maddieclayton .. the check for nullandempty is still needed for the New-AzureRmEventGridSubscription cmdlet only the update command needs to be changed to allow user to update this parameter. Hence no change in the New- cmdlet since we want the user to specify this value if this optional parameter is chosen. Otherwise, it should be specified

@maddieclayton
Copy link
Contributor

Sounds good.

@maddieclayton
Copy link
Contributor

@maddieclayton maddieclayton merged commit 1a4d2f9 into Azure:preview Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants