Skip to content

Fix for KeyVault issue 5159 and tests #6357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maddieclayton merged 6 commits into from
Jun 8, 2018
Merged

Fix for KeyVault issue 5159 and tests #6357

maddieclayton merged 6 commits into from
Jun 8, 2018

Conversation

@maddieclayton
Copy link
Contributor

@maddieclayton maddieclayton commented Jun 1, 2018

Description

#5159

Checklist

@MiYanni
Copy link
Contributor

MiYanni commented Jun 6, 2018

@maddieclayton You have merge conflicts that need to be resolved.

schaabs
schaabs approved these changes Jun 8, 2018
View reviewed changes
Copy link

@schaabs schaabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cormacpayne cormacpayne removed their assignment Jun 8, 2018
@maddieclayton maddieclayton merged commit dc4027b into Azure:preview Jun 8, 2018
@maddieclayton maddieclayton deleted the kvcall branch June 8, 2018 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@cormacpayne cormacpayne cormacpayne approved these changes

@schaabs schaabs schaabs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RandalliLama RandalliLama

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@maddieclayton @MiYanni @cormacpayne @schaabs @azuresdkci @RandalliLama