Skip to content

Conversation

@sergey-shandar
Copy link
Contributor

Description

The PR contains some breaking changes for the Strategy library so don't merge it yet until we prepare a version change for the library.

Checklist

@sergey-shandar sergey-shandar changed the title [Don't Merge Yet] websites strategy library update Websites strategy library update May 10, 2018
@MiYanni
Copy link
Contributor

MiYanni commented May 10, 2018

@sergey-shandar Well, I was looking at the error, but the build restarted for some reason. I think you changed something in NewAzureRmWebApp that wasn't being referenced properly for NetCore. At least that is what the error indicated in Travis.

@vladimir-shcherbakov vladimir-shcherbakov self-assigned this May 10, 2018
@vladimir-shcherbakov
Copy link
Contributor

vladimir-shcherbakov commented May 16, 2018

@sergey-shandar
What do you mean by Websites strategy library?

@vladimir-shcherbakov
Copy link
Contributor

@sergey-shandar
Is it possible for you organize the commits by

  1. ResourceManager/Common/Commands.Common.Strategies changes
  2. ResourceManager/Compute/AzureRM.Compute changes
  3. ResourceManager/Websites chages

or you may want to split up the PR into 3 and leave in the PR only changes related to Websites.

@sergey-shandar
Copy link
Contributor Author

See this PR #6239

@sergey-shandar sergey-shandar deleted the sergey-websites branch May 16, 2018 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants