Populate context list when no previous context found #6137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markcowl
requested changes
May 25, 2018
Member
markcowl
left a comment
markcowl
left a comment
There was a problem hiding this comment.
A couple of small changes. Also, can we write a unit test for this
| string tempName = null; | ||
| if (!_profile.TryGetContextName(tempContext, out tempName)) | ||
| { | ||
| WriteWarningMessage(string.Format("Unable to get context name for subscription with id '{0}'.", subscription.Id)); |
Member
There was a problem hiding this comment.
Let's put these strings into the assembly resources
|
|
||
| if (!_profile.TrySetContext(tempName, tempContext)) | ||
| { | ||
| WriteWarningMessage(string.Format("Cannot create a context for subscription with id '{0}'.", subscription.Id)); |
markcowl
requested changes
May 29, 2018
| } | ||
|
|
||
| _profile.DefaultContext.TokenCache = _cache; | ||
| if (shouldPopulateContextList) |
Member
There was a problem hiding this comment.
Were we going to add an option in to the login cmdlet that would disable populating the contexts? Also, I think we should set a default limit to the number of populated contexts (say, 25).
Contributor
|
@cormacpayne You have merge conflicts that need to be resolved. |
markcowl
approved these changes
Jun 9, 2018
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #6115
Checklist
CONTRIBUTING.mdplatyPSmodule