Skip to content

Conversation

@vladimir-shcherbakov
Copy link
Contributor

@vladimir-shcherbakov vladimir-shcherbakov commented Apr 26, 2018

Description

Checklist

@vladimir-shcherbakov
Copy link
Contributor Author

issue #865

```

The default table output reveals some issues:
1. **SubscriptionId** property values duplicates the **Id** property values,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's important to call out these

  • The selected fields don't feit in a standard window
  • The columns are not displayed in oirder of importance to the customer for doign their work

2. Run the New-FormatPs1Xml cmdlet to generate the format.ps1xml file.

---
We presume that for the [output type](https://github.com/Azure/azure-powershell/blob/preview/documentation/development-docs/azure-powershell-design-guidelines.md#output-type) you created a new class that, for example, wraps a returning .NET SDK type, rather to use PSObject.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..., rather than PSObject.

Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change, otherwise LGTM.

By the way, how does a user specify the ordering of fields in the output display? This is especially important for tabel formats. If we don't have a facility, we should consider adding one.

@vladimir-shcherbakov
Copy link
Contributor Author

@markcowl
The column order in the output table will be the same as the order of the properties in the output class. Does it make sense?

@markcowl markcowl merged commit 29fe5bc into Azure:preview May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants