[Subscription RP] New-AzureRmSubscription by wilcobmsft · Pull Request #5803 · Azure/azure-powershell

wilcobmsft · 2018-03-24T00:06:12Z

Description

Adding a cmdlet New-AzureRmSubscription which will allow EA customers to automate subscription creation.

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review
  See design PR
- the cmdlet markdown files were generated using the platyPS module

2. Add -AsJob support to NewAzureRmSubscription

wilcobmsft · 2018-03-27T23:15:14Z

.NET SDK merged.

markcowl · 2018-03-30T16:42:49Z

src/ResourceManager/Subscription/Commands.Subscription/Commands.Subscription.Netcore.csproj

    <ProjectReference Include="..\..\..\Common\Commands.Common.Authentication.Abstractions\Common.Authentication.Abstractions.Netcore.csproj" />
+    <ProjectReference Include="..\..\..\Common\Commands.Common.Graph.RBAC\Common.Rbac.Netcore.csproj" />
    <ProjectReference Include="..\..\..\Common\Commands.Common\Common.Netcore.csproj" />
+    <ProjectReference Include="..\..\Common\Commands.Common.Authentication.ResourceManager\Common.ResourceManager.Authentication.Netcore.csproj" />


Unfortunately, you cannot take a reference to this project, as it contains dependencies that are controlled by Profile, and may change. I assume that this is to get the PSAzureSubscription model?

If it is for this, we can move this type into another assembly (for example, the common resource manager assembly).

Yes, it is just for PSAzureSubscription. I'll just create a new IAzureSubscription implementation instead for now and remove the dependency.

markcowl · 2018-03-30T16:43:11Z

src/ResourceManager/Subscription/Commands.Subscription/Commands.Subscription.csproj

      <Project>{5ee72c53-1720-4309-b54b-5fb79703195f}</Project>
      <Name>Commands.Common</Name>
    </ProjectReference>
+    <ProjectReference Include="..\..\Common\Commands.Common.Authentication.ResourceManager\Commands.Common.Authentication.ResourceManager.csproj">


SHould not take a reference to this (see above)

markcowl · 2018-03-30T16:46:33Z

...sourceManager/Subscription/Commands.Subscription/Cmdlets/GetAzureRmSubscriptionDefinition.cs

-namespace Microsoft.Azure.Commands.Subscription.Cmdlets
-{
-    [Cmdlet(VerbsCommon.Get, "AzureRmSubscriptionDefinition", DefaultParameterSetName = ParameterSetNames.Default), OutputType(typeof(List<PSSubscriptionDefinition>))]
-    public class GetAzureRmSubscriptionDefinition : AzureSubscriptionDefinitionCmdletBase


Now that there is no 'Get' cmdlet, how do I get the subscriptions? Will Get-AzureRmSubscription work?

Yes, the existing Get-AzureRmSubscription cmdlet will work.

markcowl · 2018-04-05T00:46:33Z

on demand run here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/726/

markcowl · 2018-04-10T23:36:52Z

on demand run here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/736/

wilcobmsft added 4 commits March 22, 2018 12:48

Add basic scaffolding for New-AzureRmSubscription.

0331743

1. Integrate NewAzureRmSubscription cmdlet with underlying .NET SDK.

61920e5

2. Add -AsJob support to NewAzureRmSubscription

Update tests.

3dc6ac9

Update help.

9c45991

azuresdkci added the needs-review label Mar 24, 2018

azuresdkci assigned markcowl Mar 24, 2018

markcowl removed their assignment Mar 25, 2018

vladimir-shcherbakov assigned markcowl Mar 26, 2018

maddieclayton added Do Not Merge 🚫 Cmdlet Review Required ⚠️ labels Mar 26, 2018

Pick up published .NET SDK.

c8f8072

wilcobmsft removed the Do Not Merge 🚫 label Mar 27, 2018

wilcobmsft added 3 commits March 27, 2018 16:45

Fix version references

f1c16b7

Remove unused code.

ef76b9e

Merge branch 'preview' into wilcob/createSubscription

748450c

vladimir-shcherbakov assigned wilcobmsft and unassigned markcowl Mar 29, 2018

vladimir-shcherbakov added the Waiting for CI label Mar 29, 2018

wilcobmsft added 2 commits March 29, 2018 12:37

Fix subscription netcore support

b3d2ac6

Add missing dependencies to netcore project

da31a38

maddieclayton added Waiting for Passing Build and removed Waiting for CI labels Mar 29, 2018

Re-record test

1addcbd

wilcobmsft added Cmdlet Review Complete and removed Cmdlet Review Required ⚠️ Waiting for Passing Build labels Mar 30, 2018

wilcobmsft assigned markcowl and unassigned wilcobmsft Mar 30, 2018

markcowl requested changes Mar 30, 2018

View reviewed changes

markcowl assigned wilcobmsft and unassigned markcowl Mar 30, 2018

markcowl added needs-revision and removed needs-review labels Mar 30, 2018

Remove dependency on Common.ResourceManager.Authentication.

624e3f8

wilcobmsft added needs-review and removed needs-revision labels Mar 30, 2018

wilcobmsft assigned markcowl and unassigned wilcobmsft Mar 30, 2018

markcowl removed the needs-review label Apr 5, 2018

markcowl removed their assignment Apr 5, 2018

markcowl added the Waiting for On Demand label Apr 5, 2018

markcowl previously approved these changes Apr 5, 2018

View reviewed changes

wilcobmsft and others added 3 commits April 9, 2018 11:41

Merge branch 'preview' into wilcob/createSubscription

35c792e

Merge branch 'preview' into wilcob/createSubscription

298943b

Re-generate help docs with platyPS.

3124a38

wilcobmsft dismissed markcowl’s stale review via 3124a38 April 9, 2018 23:36

wilcobmsft added 4 commits April 9, 2018 18:35

Fix help

969bb18

Add breaking change doc

a69fda6

Merge branch 'preview' into wilcob/createSubscription

2acca63

Add breaking change exception

e796016

markcowl approved these changes Apr 10, 2018

View reviewed changes

maddieclayton merged commit fb55055 into Azure:preview Apr 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Subscription RP] New-AzureRmSubscription#5803

[Subscription RP] New-AzureRmSubscription#5803
maddieclayton merged 19 commits intoAzure:previewfrom
wilcobmsft:wilcob/createSubscription

wilcobmsft commented Mar 24, 2018 •

edited

Loading

Uh oh!

wilcobmsft commented Mar 27, 2018

Uh oh!

markcowl Mar 30, 2018

Uh oh!

markcowl Mar 30, 2018

Uh oh!

wilcobmsft Mar 30, 2018

Uh oh!

markcowl Mar 30, 2018

Uh oh!

wilcobmsft Mar 30, 2018

Uh oh!

markcowl Mar 30, 2018

Uh oh!

wilcobmsft Mar 30, 2018

Uh oh!

markcowl commented Apr 5, 2018 •

edited by cormacpayne

Loading

Uh oh!

markcowl commented Apr 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

wilcobmsft commented Mar 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

wilcobmsft commented Mar 27, 2018

Uh oh!

markcowl Mar 30, 2018

Choose a reason for hiding this comment

Uh oh!

markcowl Mar 30, 2018

Choose a reason for hiding this comment

Uh oh!

wilcobmsft Mar 30, 2018

Choose a reason for hiding this comment

Uh oh!

markcowl Mar 30, 2018

Choose a reason for hiding this comment

Uh oh!

wilcobmsft Mar 30, 2018

Choose a reason for hiding this comment

Uh oh!

markcowl Mar 30, 2018

Choose a reason for hiding this comment

Uh oh!

wilcobmsft Mar 30, 2018

Choose a reason for hiding this comment

Uh oh!

markcowl commented Apr 5, 2018 • edited by cormacpayne Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

markcowl commented Apr 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

wilcobmsft commented Mar 24, 2018 •

edited

Loading

markcowl commented Apr 5, 2018 •

edited by cormacpayne

Loading