Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ChangeLog.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
2015.07.10 version 1.0.0
2015.07.16 version 0.9.5
*Azure Network cmdlets
* Reserved IP cmdlets (New-AzureReservedIP, Get-AzureReservedIP, Set-AzureReservedIPAssociation, Remove-AzureReservedIPAssociation) fixed to support -VirtualIPName parameter
* Multivip Cmdlets (Add-AzureVirtualIP, Remove-AzureVirtualIP) fixed to support -VirtualIPName parameter

2015.07.10 version 1.0.0
* Azure Backup cmdlets
*Added New-AzureBackupVault cmdlets
*Added Get-AzureBackupVault cmdlets
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
</Reference>
<Reference Include="Microsoft.WindowsAzure.Management.Network, Version=7.0.0.0, Culture=neutral, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.Network.7.0.0\lib\net40\Microsoft.WindowsAzure.Management.Network.dll</HintPath>
<HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.Network.7.0.3\lib\net40\Microsoft.WindowsAzure.Management.Network.dll</HintPath>
</Reference>
<Reference Include="Microsoft.WindowsAzure.Management.Storage">
<HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.Storage.5.1.1\lib\net40\Microsoft.WindowsAzure.Management.Storage.dll</HintPath>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<package id="Microsoft.WindowsAzure.ConfigurationManager" version="2.0.3" targetFramework="net45" />
<package id="Microsoft.WindowsAzure.Management" version="4.1.1" targetFramework="net45" />
<package id="Microsoft.WindowsAzure.Management.Compute" version="12.2.0-preview" targetFramework="net45" />
<package id="Microsoft.WindowsAzure.Management.Network" version="7.0.0" targetFramework="net45" />
<package id="Microsoft.WindowsAzure.Management.Network" version="7.0.3" targetFramework="net45" />
<package id="Microsoft.WindowsAzure.Management.Storage" version="5.1.1" targetFramework="net45" />
<package id="Newtonsoft.Json" version="6.0.4" targetFramework="net45" />
<package id="System.Spatial" version="5.6.0" targetFramework="net45" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
<HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.Compute.12.2.0-preview\lib\net40\Microsoft.WindowsAzure.Management.Compute.dll</HintPath>
</Reference>
<Reference Include="Microsoft.WindowsAzure.Management.Network">
<HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.Network.7.0.0\lib\net40\Microsoft.WindowsAzure.Management.Network.dll</HintPath>
<HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.Network.7.0.3\lib\net40\Microsoft.WindowsAzure.Management.Network.dll</HintPath>
</Reference>
<Reference Include="Microsoft.WindowsAzure.Management.Storage">
<HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.Storage.5.1.1\lib\net40\Microsoft.WindowsAzure.Management.Storage.dll</HintPath>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<package id="Microsoft.WindowsAzure.ConfigurationManager" version="2.0.3" targetFramework="net45" />
<package id="Microsoft.WindowsAzure.Management" version="4.1.1" targetFramework="net45" />
<package id="Microsoft.WindowsAzure.Management.Compute" version="12.2.0-preview" targetFramework="net45" />
<package id="Microsoft.WindowsAzure.Management.Network" version="7.0.0" targetFramework="net45" />
<package id="Microsoft.WindowsAzure.Management.Network" version="7.0.3" targetFramework="net45" />
<package id="Microsoft.WindowsAzure.Management.Storage" version="5.1.1" targetFramework="net45" />
<package id="Moq" version="4.2.1402.2112" targetFramework="net45" />
<package id="Newtonsoft.Json" version="6.0.4" targetFramework="net45" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
</Reference>
<Reference Include="Microsoft.WindowsAzure.Management.Network, Version=7.0.0.0, Culture=neutral, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.Network.7.0.0\lib\net40\Microsoft.WindowsAzure.Management.Network.dll</HintPath>
<HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.Network.7.0.3\lib\net40\Microsoft.WindowsAzure.Management.Network.dll</HintPath>
</Reference>
<Reference Include="Microsoft.WindowsAzure.Management.Storage">
<HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.Storage.5.1.1\lib\net40\Microsoft.WindowsAzure.Management.Storage.dll</HintPath>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@ namespace Microsoft.WindowsAzure.Commands.ServiceManagement.IaaS.Network
[Cmdlet(VerbsCommon.Add, "AzureVirtualIP"), OutputType(typeof(ManagementOperationContext))]
public class AddAzureVirtualIP : ServiceManagementBaseCmdlet
{
public AddAzureVirtualIP()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove these empty constructors?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a parameterized constructor, so default constructor is required to support backward compatibility.

{
}

public AddAzureVirtualIP(IClientProvider provider) : base(provider)
{
}

[Parameter(Position = 0, Mandatory = true, ValueFromPipelineByPropertyName = false)]
[ValidateNotNullOrEmpty]
public string ServiceName { get; set; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,17 @@ namespace Microsoft.WindowsAzure.Commands.ServiceManagement.IaaS
[Cmdlet(VerbsCommon.New, ReservedIPConstants.CmdletNoun, DefaultParameterSetName = ReserveNewIPParamSet), OutputType(typeof(ManagementOperationContext))]
public class NewAzureReservedIPCmdlet : ServiceManagementBaseCmdlet
{
protected const string ReserveNewIPParamSet = "CreateNewReservedIP";
protected const string ReserveInUseIPUsingSlotParamSet = "CreateInUseReservedIPUsingSlot";
protected const string ReserveInUseIPParamSet = "CreateInUseReservedIP";
public const string ReserveNewIPParamSet = "CreateNewReservedIP";
public const string ReserveInUseIPUsingSlotParamSet = "CreateInUseReservedIPUsingSlot";
public const string ReserveInUseIPParamSet = "CreateInUseReservedIP";

public NewAzureReservedIPCmdlet()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove these empty constructors?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a parameterized constructor, so default constructor is required to support backward compatibility.

{
}

public NewAzureReservedIPCmdlet(IClientProvider provider) : base(provider)
{
}

[Parameter(Mandatory = true, Position = 0, ValueFromPipelineByPropertyName = true, ParameterSetName = ReserveNewIPParamSet, HelpMessage = "Reserved IP Name.")]
[Parameter(Mandatory = true, Position = 0, ValueFromPipelineByPropertyName = true, ParameterSetName = ReserveInUseIPUsingSlotParamSet, HelpMessage = "Reserved IP Name.")]
Expand Down Expand Up @@ -85,7 +93,7 @@ public string Slot
set;
}

protected override void OnProcessRecord()
public override void ExecuteCmdlet()
{
ServiceManagementProfile.Initialize();
string deploymentName = string.Empty;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,15 @@ namespace Microsoft.WindowsAzure.Commands.ServiceManagement.IaaS
[Cmdlet(VerbsCommon.Remove, ReservedIPConstants.CmdletNoun, DefaultParameterSetName = RemoveReservedIPParamSet), OutputType(typeof(ManagementOperationContext))]
public class RemoveAzureReservedIPCmdlet : ServiceManagementBaseCmdlet
{
public RemoveAzureReservedIPCmdlet()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove these empty constructors?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a parameterized constructor, so default constructor is required to support backward compatibility.

{
}

public RemoveAzureReservedIPCmdlet(IClientProvider provider)
: base(provider)
{
}

protected const string RemoveReservedIPParamSet = "RemoveReservedIP";

[Parameter(Mandatory = true, Position = 0, ValueFromPipelineByPropertyName = true, HelpMessage = "Reserved IP Name.")]
Expand All @@ -32,7 +41,7 @@ public class RemoveAzureReservedIPCmdlet : ServiceManagementBaseCmdlet
[Parameter(Position = 1, HelpMessage = "Do not confirm deletion of deployment")]
public SwitchParameter Force { get; set; }

protected override void OnProcessRecord()
public override void ExecuteCmdlet()
{
ServiceManagementProfile.Initialize();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@ namespace Microsoft.WindowsAzure.Commands.ServiceManagement.IaaS
[Cmdlet(VerbsCommon.Remove, "AzureVirtualIP"), OutputType(typeof(ManagementOperationContext))]
public class RemoveAzureVirtualIP : ServiceManagementBaseCmdlet
{
public RemoveAzureVirtualIP()
{
}

public RemoveAzureVirtualIP(IClientProvider provider) : base(provider)
{
}

[Parameter(Position = 0, Mandatory = true, ValueFromPipelineByPropertyName = false)]
[ValidateNotNullOrEmpty]
public string ServiceName { get; set; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,15 @@ namespace Microsoft.WindowsAzure.Commands.ServiceManagement.IaaS
[Cmdlet(VerbsCommon.Set, ReservedIPConstants.AssociationCmdletNoun), OutputType(typeof(ManagementOperationContext))]
public class SetAzureReservedIPAssociationCmdlet : ServiceManagementBaseCmdlet
{
public SetAzureReservedIPAssociationCmdlet()
{
}

public SetAzureReservedIPAssociationCmdlet(IClientProvider provider)
: base(provider)
{
}

[Parameter(Mandatory = true, Position = 0, ValueFromPipelineByPropertyName = true, HelpMessage = "Reserved IP Name.")]
[ValidateNotNullOrEmpty]
public string ReservedIPName
Expand Down Expand Up @@ -58,7 +67,7 @@ public string Slot
set;
}

protected override void OnProcessRecord()
public override void ExecuteCmdlet()
{
ServiceManagementProfile.Initialize();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<package id="Microsoft.WindowsAzure.ConfigurationManager" version="2.0.3" targetFramework="net45" />
<package id="Microsoft.WindowsAzure.Management" version="4.1.1" targetFramework="net45" />
<package id="Microsoft.WindowsAzure.Management.Compute" version="12.2.0-preview" targetFramework="net45" />
<package id="Microsoft.WindowsAzure.Management.Network" version="7.0.0" targetFramework="net45" />
<package id="Microsoft.WindowsAzure.Management.Network" version="7.0.3" targetFramework="net45" />
<package id="Microsoft.WindowsAzure.Management.Storage" version="5.1.1" targetFramework="net45" />
<package id="Newtonsoft.Json" version="6.0.4" targetFramework="net45" />
<package id="System.Spatial" version="5.6.0" targetFramework="net45" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,11 @@
<HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.Compute.12.2.0-preview\lib\net40\Microsoft.WindowsAzure.Management.Compute.dll</HintPath>
</Reference>
<Reference Include="Microsoft.WindowsAzure.Management.Network">
<HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.Network.7.0.3\lib\net40\Microsoft.WindowsAzure.Management.Network.dll</HintPath>
</Reference>
<Reference Include="Microsoft.WindowsAzure.Management.Storage, Version=5.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.Network.7.0.2\lib\net40\Microsoft.WindowsAzure.Management.Network.dll</HintPath>
<HintPath>..\..\..\packages\Microsoft.WindowsAzure.Management.Storage.5.1.1\lib\net40\Microsoft.WindowsAzure.Management.Storage.dll</HintPath>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it expected to update Storage to 5.1.1? Don't you need to update all other projects for the same?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I'll remove the update. However other files seem to contain 5.1.1

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is adding a new Storage dependency. This project never had storage dependency. The diff appears against the network package because its confused. All other projects seem to refer to 5.1.1.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eg. Commands.ServiceManagement.Preview

</Reference>
<Reference Include="Moq, Version=4.2.1402.2112, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
Expand Down Expand Up @@ -145,10 +148,12 @@
<ItemGroup>
<Compile Include="IPForwarding\GetIPForwardingTests.cs" />
<Compile Include="IPForwarding\SetIPForwardingTests.cs" />
<Compile Include="Multivip\MultivipTests.cs" />
<Compile Include="NetworkSecurityGroups\GetNetworkSecurityGroupAssociationTests.cs" />
<Compile Include="NetworkSecurityGroups\RemoveNetworkSecurityGroupAssociationTests.cs" />
<Compile Include="NetworkSecurityGroups\SetNetworkSecurityGroupAssociationTests.cs" />
<Compile Include="Properties\AssemblyInfo.cs" />
<Compile Include="ReservedIP\ReservedIPTest.cs" />
<Compile Include="Routes\GetEffectiveRouteTests.cs" />
<Compile Include="Routes\GetRouteTableTests.cs" />
<Compile Include="Routes\GetSubnetRouteTableTests.cs" />
Expand All @@ -159,16 +164,22 @@
<Compile Include="Routes\SetRouteTests.cs" />
<Compile Include="Routes\SetSubnetRouteTableTests.cs" />
<Compile Include="ScenarioTests\IPForwarding\IPForwardingScenarioTests.cs" />
<Compile Include="ScenarioTests\MultiVip\MultiVip.cs" />
<Compile Include="ScenarioTests\NetworkSecurityGroup\NSGScenarioTests.cs" />
<Compile Include="ScenarioTests\NetworkTests.cs" />
<Compile Include="ScenarioTests\NetworkTestsBase.cs" />
<Compile Include="ScenarioTests\ReservedIPs\ReservedIP.cs" />
<Compile Include="TestInterfaces\TestClientProvider.cs" />
</ItemGroup>
<ItemGroup>
<None Include="MSSharedLibKey.snk" />
<None Include="packages.config" />
<None Include="ScenarioTests\IPForwarding\IPForwardingTests.ps1">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Include="ScenarioTests\MultiVip\MultiVipTests.ps1">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Include="ScenarioTests\NetworkSecurityGroup\Common.ps1">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
Expand All @@ -187,6 +198,10 @@
<Project>{5ee72c53-1720-4309-b54b-5fb79703195f}</Project>
<Name>Commands.Common</Name>
</ProjectReference>
<ProjectReference Include="..\..\..\Common\Commands.Profile\Commands.Profile.csproj">
<Project>{c60342b1-47d3-4a0e-8081-9b97ce60b7af}</Project>
<Name>Commands.Profile</Name>
</ProjectReference>
<ProjectReference Include="..\..\..\Common\Commands.ScenarioTests.Common\Commands.ScenarioTests.Common.csproj">
<Project>{C1BDA476-A5CC-4394-914D-48B0EC31A710}</Project>
<Name>Commands.ScenarioTests.Common</Name>
Expand All @@ -203,12 +218,31 @@
<Project>{E1CA72BA-8374-45F6-904D-FD34ECDF5B6F}</Project>
<Name>Commands.ServiceManagement</Name>
</ProjectReference>
<ProjectReference Include="..\..\Services\Commands.Utilities\Commands.Utilities.csproj">
<Project>{4900ec4e-8deb-4412-9108-0bc52f81d457}</Project>
<Name>Commands.Utilities</Name>
</ProjectReference>
<ProjectReference Include="..\Commands.Network\Commands.ServiceManagement.Network.csproj">
<Project>{40fee0bb-fd45-4efc-85bc-0d602a6892c4}</Project>
<Name>Commands.ServiceManagement.Network</Name>
</ProjectReference>
</ItemGroup>
<ItemGroup>
<None Include="ScenarioTests\ReservedIPs\ReservedIPTests.ps1">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.WindowsAzure.Commands.ServiceManagement.Network.Test.ScenarioTests.MultiVip\ExtraVipLifecycle.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.WindowsAzure.Commands.ServiceManagement.Network.Test.ScenarioTests.MultiVip\ExtraVipMobility.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.WindowsAzure.Commands.ServiceManagement.Network.Test.ScenarioTests.MultiVip\ReserveMultivipDepIP.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.WindowsAzure.Commands.ServiceManagement.Network.Test.ScenarioTests.MultiVip\SetLbEpMultivipDep.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.WindowsAzure.Commands.ServiceManagement.Network.Test.ScenarioTests.NSGScenarioTests\CreateAndRemoveNSG.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
Expand Down Expand Up @@ -236,6 +270,21 @@
<None Include="SessionRecords\Microsoft.WindowsAzure.Commands.ServiceManagement.Network.Test.ScenarioTests.NSGScenarioTests\SetNSRWithInvalidParameter.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.WindowsAzure.Commands.ServiceManagement.Network.Test.ScenarioTests.ReservedIP\AzureReservedIPSimpleOps.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.WindowsAzure.Commands.ServiceManagement.Network.Test.ScenarioTests.ReservedIP\CreateVMWithReservedIP.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.WindowsAzure.Commands.ServiceManagement.Network.Test.ScenarioTests.ReservedIP\RemoveReservedIPAssocSimple.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.WindowsAzure.Commands.ServiceManagement.Network.Test.ScenarioTests.ReservedIP\ReserveExistingDepIP.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.WindowsAzure.Commands.ServiceManagement.Network.Test.ScenarioTests.ReservedIP\SetReservedIPAssocSimple.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="TestData\EmptyNetworkConfiguration.xml">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
Expand Down
Loading