-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New CmdLet to get UsageAggregates #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @Matt-Westphal, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not check in files with hardcoded paths
|
This PR should also include: (1) Updated installer that includes your files (use the BuildInstaller script in the Tools folder); (2) dll help file; (3) Changes to changelog.txt describing your new cmdlet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ReportedStartTime and ReportedEndTime and not just StartTime and EndTime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With usage data there is multiple uses of DateTime. Reported vs when the usage was consumed. which is a critical distinction to make sure they consumers have all the data they need. Also this is consistent with output of the billing data from the Azure system
|
@azuresdkci retest this please |
|
Where can I find some documentation or any idea where/how to do these? Would have included them if I had known they needed to be done. From: Mark Cowlishaw [mailto:[email protected]] This PR should also include: (1) Updated installer that includes your files (use the BuildInstaller script in the Tools folder); (2) dll help file; (3) Changes to changelog.txt describing your new cmdlet — |
|
please pull from upstream and resolve conflicts. |
New CmdLet to get UsageAggregates
|
Hi, I thought the problem could have been with the date format,so I've tried several different ways: dd/mm/yyyy, yyyy/mm/dd, etc. Always the same result. Finally, I've used the -debug flag and these were my findings: If you note the URI, the reportedstartTime and reportedEndTime fields have spaces between the date and time; I think theses should be URL Encoded or set to ShortDate format! PS: I've replaced my subscription ID with the text {SUBSCRIPTIONID} |
HPF PR: dev <- Azure:dev
This command will get the usage data for a subscription.
Also added a script to verify the module works as expected
The test is marked as skipped since I can get the test framework to start after working at it for 4 days.