Skip to content

Security update for storageURL field of ApplicationPackage #28957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wyunchi-ms merged 12 commits into from
Dec 12, 2025
Merged

Security update for storageURL field of ApplicationPackage #28957

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
101b1d9
changed the way we get the storageUrl from the get call to put call
wiboris Dec 5, 2025
9ae7574
changed test to upload file not just activate it
wiboris Dec 5, 2025
8073b1a
added test and responded to feedback
wiboris Dec 5, 2025
f537a77
update to make test live only
wiboris Dec 5, 2025
2cf7407
updateing recordings
wiboris Dec 8, 2025
eeecbfa
updating changelog
wiboris Dec 9, 2025
882c29a
Update src/Batch/Batch/ChangeLog.md
wiboris Dec 10, 2025
cee0614
Update src/Batch/Batch/ChangeLog.md
wiboris Dec 10, 2025
f3f0ab2
copilot feedback
wiboris Dec 10, 2025
b28e8d7
Update src/Batch/Batch/Models/BatchClient.ApplicationPackages.cs
wiboris Dec 10, 2025
4a42014
Update src/Batch/Batch/Models/BatchClient.ApplicationPackages.cs
wiboris Dec 10, 2025
23870c5
Implementing coplilot suggesions
wiboris Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions src/Batch/Batch.Test/ScenarioTests/BatchApplicationPackageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ public BatchApplicationPackageTests(Xunit.Abstractions.ITestOutputHelper output)

}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
[Fact(Skip = "Successful re-recording, but fails in playback. See issue https://github.com/Azure/azure-powershell/issues/7512")]
[Trait(Category.AcceptanceType, Category.LiveOnly)]
public void TestUploadApplicationPackage()
{
string id = "newApplicationPackage";
Expand All @@ -51,6 +51,29 @@ public void TestUploadApplicationPackage()
);
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TestUploadApplicationPackageActivateOnly()
{
string id = "newApplicationPackage";

BatchAccountContext context = null;
TestRunner.RunTestScript(
null,
mockContext =>
{
context = new ScenarioTestContext();
ScenarioTestHelpers.CreateApplicationPackage(this, context, id, version, filePath);
},
() =>
{
ScenarioTestHelpers.DeleteApplicationPackage(this, context, id, version);
ScenarioTestHelpers.DeleteApplication(this, context, id);
},
$"Test-UploadApplicationPackageActivateOnly '{id}' '{version}' '{filePath}'"
);
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TestUpdateApplicationPackage()
Expand Down
20 changes: 20 additions & 0 deletions src/Batch/Batch.Test/ScenarioTests/BatchApplicationPackageTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,26 @@ function Test-UploadApplicationPackage
# Setup
$context = New-Object Microsoft.Azure.Commands.Batch.Test.ScenarioTests.ScenarioTestContext

$addAppPack = New-AzBatchApplicationPackage -ResourceGroupName $context.ResourceGroupName -AccountName $context.AccountName -ApplicationName $applicationName -ApplicationVersion $applicationVersion -format "zip" -FilePath $filePath
$subId = $context.Subscription
$resourceGroup = $context.ResourceGroupName
$batchAccountName = $context.AccountName

Assert-AreEqual "/subscriptions/$subId/resourceGroups/$resourceGroup/providers/Microsoft.Batch/batchAccounts/$batchAccountName/applications/$applicationName/versions/$applicationVersion" $addAppPack.Id
Assert-AreEqual $applicationVersion $addAppPack.Name
}

<#
.SYNOPSIS
Tests uploading an application package.
#>
function Test-UploadApplicationPackageActivateOnly
{
param([string] $applicationName, [string] $applicationVersion, [string]$filePath)

# Setup
$context = New-Object Microsoft.Azure.Commands.Batch.Test.ScenarioTests.ScenarioTestContext

$addAppPack = New-AzBatchApplicationPackage -ResourceGroupName $context.ResourceGroupName -AccountName $context.AccountName -ApplicationName $applicationName -ApplicationVersion $applicationVersion -format "zip" -ActivateOnly
$subId = $context.Subscription
$resourceGroup = $context.ResourceGroupName
Expand Down
Loading