Skip to content

Conversation

@mihretkidane-OCI
Copy link
Contributor

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings October 20, 2025 20:35
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Oracle module to use a new API version (2025-01-15-preview → 2025-09-01). The changes include parameter updates, new cmdlets for DbSystem, NetworkAnchor, and ResourceAnchor resources, and corresponding test files.

  • Updated API version from 2025-01-15-preview to 2025-09-01
  • Added new cmdlets for DbSystem, NetworkAnchor, and ResourceAnchor management
  • Replaced deprecated ScheduledStartTime/ScheduledStopTime parameters with ScheduledOperationsList

Reviewed Changes

Copilot reviewed 84 out of 89 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Az.Oracle.psd1 Updated module version dependencies and exported cmdlets list
Oracle.sln Updated project GUIDs for solution structure
utils.ps1 Added test environment setup for new anchor and DbSystem resources
loadEnv.ps1 Added module loading logic to ensure Az.Oracle cmdlets are available during tests
localEnv.json New test environment configuration file
help/*.md Updated cmdlet documentation to reflect API changes (parameter additions/removals)
test/*.Tests.ps1 Added tests for new cmdlets (NetworkAnchor, ResourceAnchor, DbSystem)
test/*.Recording.json Added/updated test recordings for new and existing cmdlets

# Exadata Infra Properties

$exaInfraName = "OFake_PowerShellTestExaInfra"
$exaInfraName = "OFake_PowerShellExaInfra"
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name was changed from OFake_PowerShellTestExaInfra to OFake_PowerShellExaInfra. While this change appears intentional based on the test name, ensure this matches the actual test resource name and all references are updated accordingly. After making changes, perform manual validation by building the module and running the affected tests.

Copilot generated this review using guidance from repository custom instructions.
Comment on lines +50 to +52
"Request": {
"Method": "GET",
"RequestUri": "https://management.azure.com/subscriptions/fd42b73d-5f28-4a23-ae7c-ca08c625fe07/providers/Oracle.Database/locations/eastus/dnsPrivateZones?api-version=2025-09-01",
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate entries exist for the same test case in the recording file. Lines 1-48 contain a complete request/response pair, followed by lines 50-55 starting another request entry without proper JSON structure closure. This creates invalid JSON and will cause test playback failures.

Copilot uses AI. Check for mistakes.
Comment on lines +37 to +38
$created = New-AzOracleResourceAnchor `
-Name $name `
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $name is referenced but never defined in this test. This will cause the test to fail. Define $name before usage, similar to how other variables like $location and $rgName are defined.

Copilot uses AI. Check for mistakes.
@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@mihretkidane-OCI mihretkidane-OCI marked this pull request as draft October 20, 2025 21:07
@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants