-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[HDInsight] Update api version to 2025-01-15-preview #28724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Oracle module to use a new API version (2025-01-15-preview → 2025-09-01). The changes include parameter updates, new cmdlets for DbSystem, NetworkAnchor, and ResourceAnchor resources, and corresponding test files.
- Updated API version from 2025-01-15-preview to 2025-09-01
- Added new cmdlets for DbSystem, NetworkAnchor, and ResourceAnchor management
- Replaced deprecated
ScheduledStartTime/ScheduledStopTimeparameters withScheduledOperationsList
Reviewed Changes
Copilot reviewed 84 out of 89 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Az.Oracle.psd1 | Updated module version dependencies and exported cmdlets list |
| Oracle.sln | Updated project GUIDs for solution structure |
| utils.ps1 | Added test environment setup for new anchor and DbSystem resources |
| loadEnv.ps1 | Added module loading logic to ensure Az.Oracle cmdlets are available during tests |
| localEnv.json | New test environment configuration file |
| help/*.md | Updated cmdlet documentation to reflect API changes (parameter additions/removals) |
| test/*.Tests.ps1 | Added tests for new cmdlets (NetworkAnchor, ResourceAnchor, DbSystem) |
| test/*.Recording.json | Added/updated test recordings for new and existing cmdlets |
| # Exadata Infra Properties | ||
|
|
||
| $exaInfraName = "OFake_PowerShellTestExaInfra" | ||
| $exaInfraName = "OFake_PowerShellExaInfra" |
Copilot
AI
Oct 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable name was changed from OFake_PowerShellTestExaInfra to OFake_PowerShellExaInfra. While this change appears intentional based on the test name, ensure this matches the actual test resource name and all references are updated accordingly. After making changes, perform manual validation by building the module and running the affected tests.
| "Request": { | ||
| "Method": "GET", | ||
| "RequestUri": "https://management.azure.com/subscriptions/fd42b73d-5f28-4a23-ae7c-ca08c625fe07/providers/Oracle.Database/locations/eastus/dnsPrivateZones?api-version=2025-09-01", |
Copilot
AI
Oct 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate entries exist for the same test case in the recording file. Lines 1-48 contain a complete request/response pair, followed by lines 50-55 starting another request entry without proper JSON structure closure. This creates invalid JSON and will cause test playback failures.
| $created = New-AzOracleResourceAnchor ` | ||
| -Name $name ` |
Copilot
AI
Oct 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $name is referenced but never defined in this test. This will cause the test to fail. Define $name before usage, similar to how other variables like $location and $rgName are defined.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.