Skip to content

Conversation

@Ptnan7
Copy link
Member

@Ptnan7 Ptnan7 commented Oct 20, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings October 20, 2025 03:36
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive Edge Action support to the Azure CDN PowerShell module. The changes include new cmdlets for managing Edge Actions, Edge Action Versions, Edge Action Execution Filters, and Edge Action Attachments.

Key changes:

  • Added 17 new cmdlets for complete Edge Action lifecycle management including Create, Read, Update, Delete operations
  • Added support for Edge Action version management with code deployment capabilities
  • Integrated new API specification for Edge Actions (2024-07-22-preview)

Reviewed Changes

Copilot reviewed 74 out of 74 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Az.Cdn.psd1 Updated module manifest to export new Edge Action cmdlets
Cdn.sln Updated project GUID reference for autorest module
help/*.md Added comprehensive help documentation for all new Edge Action cmdlets
test/*.Tests.ps1 Added test stubs for all new Edge Action cmdlets
examples/*.md Added usage examples for new Edge Action cmdlets
docs/*.md Added detailed documentation for new Edge Action cmdlets
UX/Microsoft.Cdn/edgeActions.json Added UX metadata for Edge Action cmdlets
README.md Added reference to new Edge Action API specification
generate-info.json Updated generation ID for new autorest run

@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good. Please add tests and check out these questions

Accept wildcard characters: False
```

### -IsDefaultVersion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a boolean, should it be?

### UpdateExpanded (Default)
```
Update-AzCdnEdgeAction -Name <String> -ResourceGroupName <String> [-SubscriptionId <String>]
[-SkuName <String>] [-SkuTier <String>] [-Tag <Hashtable>] [-DefaultProfile <PSObject>] [-AsJob] [-NoWait]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you actually update the SKU? It's immutable for many resource types

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the feature owner, it can be updated.

@github-actions
Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

Jingnan Xu added 2 commits October 24, 2025 23:49
@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants