-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Update Update-AzRoleManagementPolicy.md #28502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the documentation for the Update-AzRoleManagementPolicy cmdlet to fix non-working PowerShell examples by using fully qualified type names instead of shorthand type names.
- Updates type references to use fully qualified namespace paths to avoid type resolution ambiguity
- Fixes broken documentation examples that were previously failing due to incorrect type casting
- Improves usability by ensuring the provided examples actually work when executed
|
Thank you for your contribution @B-Oudehinken! We will review the pull request and get back to you soon. |
|
Hi @B-Oudehinken , Thanks for the contribution, I suppose you don't want to bother cloning the repo and compile any code. Please update these 2 files as well: Otherwise, your update will be overwritten because these help markdowns are auto-generated. Thanks |
|
@VeryEarly |
|
@microsoft-github-policy-service agree |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
The current doc examples do not work.
This suggested configuration works.
Tested it my self. Credits to :
#18781 (comment)
This pull request updates the usage of role management policy rule types in the documentation for Update-AzRoleManagementPolicy. The main change is to use fully qualified type names in the PowerShell examples to avoid ambiguity and ensure correct type resolution.
Documentation improvements:
Updated the $expirationRule variable in both examples to use the fully qualified type name Microsoft.Azure.PowerShell.Cmdlets.Resources.Authorization.Models.Api20201001Preview.RoleManagementPolicyExpirationRule instead of the shorthand RoleManagementPolicyExpirationRule. [1] [2]
Updated the $notificationRule variable in Example 2 to use the fully qualified type name Microsoft.Azure.PowerShell.Cmdlets.Resources.Authorization.Models.Api20201001Preview.RoleManagementPolicyNotificationRule instead of the shorthand RoleManagementPolicyNotificationRule.