-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[Az.ServiceFabric] Add cmdlets Invoke-AzServiceFabricDeallocateManagedNodeType, Invoke-AzServiceFabricRedeployManagedNodeType, Start-AzServiceFabricManagedNodeType #28499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add cmdlet parameter deprecation attributes; add -UpdateType input parameter for Invoke-AzServiceFabricRedeployManagedNodeType and Restart-AzServiceFabricManagedNodeType;
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
src/ServiceFabric/ServiceFabric/help/Restart-AzServiceFabricManagedNodeType.md
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds new cmdlets for Service Fabric managed node type operations and enhances existing functionality. The main purpose is to provide additional node management capabilities and improve the existing restart functionality.
Key changes include:
- Addition of three new cmdlets for node operations (deallocate, redeploy, reimage, start)
- Enhancement of the existing restart cmdlet with an UpdateType parameter and making NodeName optional
- Deprecation warnings for existing reimage functionality in favor of the new dedicated cmdlet
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| Start-AzServiceFabricManagedNodeType.md | Help documentation for the new Start cmdlet |
| Restart-AzServiceFabricManagedNodeType.md | Updated help with new UpdateType parameter and optional NodeName |
| Invoke-AzServiceFabricReimageManagedNodeType.md | Help documentation for the new Reimage cmdlet |
| Invoke-AzServiceFabricRedeployManagedNodeType.md | Help documentation for the new Redeploy cmdlet |
| Invoke-AzServiceFabricDeallocateManagedNodeType.md | Help documentation for the new Deallocate cmdlet |
| Az.ServiceFabric.md | Updated module documentation with new cmdlets |
| StartAzServiceFabricNodeType.cs | Implementation of the new Start cmdlet |
| SetAzServiceFabricManagedNodeType.cs | Added deprecation warnings for reimage operations |
| RestartAzServiceFabricManagedNodeType.cs | Enhanced with UpdateType parameter and optional NodeName |
| InvokeAzServiceFabricReimageManagedNodeType.cs | Implementation of the new Reimage cmdlet |
| InvokeAzServiceFabricRedeployManagedNodeType.cs | Implementation of the new Redeploy cmdlet |
| InvokeAzServiceFabricDeallocateManagedNodeType.cs | Implementation of the new Deallocate cmdlet |
| ChangeLog.md | Updated with new features and changes |
| Az.ServiceFabric.psd1 | Added new cmdlets to the module manifest |
| ServiceFabricManagedClustersTests.ps1 | Updated tests to use new cmdlets |
src/ServiceFabric/ServiceFabric/help/Start-AzServiceFabricManagedNodeType.md
Outdated
Show resolved
Hide resolved
src/ServiceFabric/ServiceFabric/help/Invoke-AzServiceFabricReimageManagedNodeType.md
Outdated
Show resolved
Hide resolved
src/ServiceFabric/ServiceFabric/help/Invoke-AzServiceFabricRedeployManagedNodeType.md
Outdated
Show resolved
Hide resolved
src/ServiceFabric/ServiceFabric/help/Invoke-AzServiceFabricDeallocateManagedNodeType.md
Outdated
Show resolved
Hide resolved
src/ServiceFabric/ServiceFabric/help/Invoke-AzServiceFabricRedeployManagedNodeType.md
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Description
[Az.ServiceFabric]
Add cmdlets Invoke-AzServiceFabricDeallocateManagedNodeType, Invoke-AzServiceFabricRedeployManagedNodeType, Invoke-AzServiceFabricReimageManagedNodeType, Start-AzServiceFabricManagedNodeType
Add -UpdateType parameter for Restart-AzServiceFabricManagedNodeType
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.