Skip to content

Conversation

@iliu816
Copy link
Member

@iliu816 iliu816 commented Sep 3, 2025

Description

[Az.ServiceFabric]

Add cmdlets Invoke-AzServiceFabricDeallocateManagedNodeType, Invoke-AzServiceFabricRedeployManagedNodeType, Invoke-AzServiceFabricReimageManagedNodeType, Start-AzServiceFabricManagedNodeType

Add -UpdateType parameter for Restart-AzServiceFabricManagedNodeType

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

add cmdlet parameter deprecation attributes;

add -UpdateType input parameter for Invoke-AzServiceFabricRedeployManagedNodeType and Restart-AzServiceFabricManagedNodeType;
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@isra-fel
Copy link
Member

isra-fel commented Sep 3, 2025

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@isra-fel
Copy link
Member

isra-fel commented Sep 3, 2025

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

isra-fel commented Sep 5, 2025

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@iliu816 iliu816 marked this pull request as ready for review September 5, 2025 18:35
Copilot AI review requested due to automatic review settings September 5, 2025 18:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds new cmdlets for Service Fabric managed node type operations and enhances existing functionality. The main purpose is to provide additional node management capabilities and improve the existing restart functionality.

Key changes include:

  • Addition of three new cmdlets for node operations (deallocate, redeploy, reimage, start)
  • Enhancement of the existing restart cmdlet with an UpdateType parameter and making NodeName optional
  • Deprecation warnings for existing reimage functionality in favor of the new dedicated cmdlet

Reviewed Changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
Start-AzServiceFabricManagedNodeType.md Help documentation for the new Start cmdlet
Restart-AzServiceFabricManagedNodeType.md Updated help with new UpdateType parameter and optional NodeName
Invoke-AzServiceFabricReimageManagedNodeType.md Help documentation for the new Reimage cmdlet
Invoke-AzServiceFabricRedeployManagedNodeType.md Help documentation for the new Redeploy cmdlet
Invoke-AzServiceFabricDeallocateManagedNodeType.md Help documentation for the new Deallocate cmdlet
Az.ServiceFabric.md Updated module documentation with new cmdlets
StartAzServiceFabricNodeType.cs Implementation of the new Start cmdlet
SetAzServiceFabricManagedNodeType.cs Added deprecation warnings for reimage operations
RestartAzServiceFabricManagedNodeType.cs Enhanced with UpdateType parameter and optional NodeName
InvokeAzServiceFabricReimageManagedNodeType.cs Implementation of the new Reimage cmdlet
InvokeAzServiceFabricRedeployManagedNodeType.cs Implementation of the new Redeploy cmdlet
InvokeAzServiceFabricDeallocateManagedNodeType.cs Implementation of the new Deallocate cmdlet
ChangeLog.md Updated with new features and changes
Az.ServiceFabric.psd1 Added new cmdlets to the module manifest
ServiceFabricManagedClustersTests.ps1 Updated tests to use new cmdlets

@isra-fel
Copy link
Member

isra-fel commented Sep 5, 2025

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly self-assigned this Sep 10, 2025
@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit efdb836 into Azure:main Sep 15, 2025
12 checks passed
@iliu816 iliu816 deleted the user/iliu/editNTActions branch October 15, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants