Alecb/generation 20240403 Stable Release#25951
Merged
vidai-msft merged 21 commits intoAzure:generationfrom Nov 5, 2024
Merged
Conversation
️✔️Az.Accounts
|
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| Get-AzWvdAppAttachPackage | Get-AzWvdAppAttachPackage Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWvdAppAttachPackage | Get-AzWvdAppAttachPackage changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWvdApplication | Get-AzWvdApplication Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWvdApplication | Get-AzWvdApplication changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWvdApplicationGroup | Get-AzWvdApplicationGroup Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWvdApplicationGroup | Get-AzWvdApplicationGroup changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWvdDesktop | Get-AzWvdDesktop Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWvdDesktop | Get-AzWvdDesktop changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWvdHostPool | Get-AzWvdHostPool Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWvdHostPool | Get-AzWvdHostPool changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWvdMsixPackage | Get-AzWvdMsixPackage Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWvdMsixPackage | Get-AzWvdMsixPackage changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWvdPrivateEndpointConnection | Get-AzWvdPrivateEndpointConnection Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWvdPrivateEndpointConnection | Get-AzWvdPrivateEndpointConnection changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWvdPrivateLinkResource | Get-AzWvdPrivateLinkResource Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWvdPrivateLinkResource | Get-AzWvdPrivateLinkResource changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWvdRegistrationInfo | Get-AzWvdRegistrationInfo Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWvdRegistrationInfo | Get-AzWvdRegistrationInfo changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWvdScalingPlan | Get-AzWvdScalingPlan Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWvdScalingPlan | Get-AzWvdScalingPlan changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWvdScalingPlanPersonalSchedule | Get-AzWvdScalingPlanPersonalSchedule Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWvdScalingPlanPersonalSchedule | Get-AzWvdScalingPlanPersonalSchedule changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWvdScalingPlanPooledSchedule | Get-AzWvdScalingPlanPooledSchedule Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWvdScalingPlanPooledSchedule | Get-AzWvdScalingPlanPooledSchedule changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWvdSessionHost | Get-AzWvdSessionHost Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWvdSessionHost | Get-AzWvdSessionHost changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWvdStartMenuItem | Get-AzWvdStartMenuItem Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWvdStartMenuItem | Get-AzWvdStartMenuItem changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWvdUserSession | Get-AzWvdUserSession Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWvdUserSession | Get-AzWvdUserSession changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWvdWorkspace | Get-AzWvdWorkspace Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWvdWorkspace | Get-AzWvdWorkspace changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ New-AzWvdAppAttachPackage 1 12 Mismatched_Parameter_Value_Type New-AzWvdAppAttachPackage -ImagePackageApplication $apps is not an expected parameter value type. -ImagePackageApplication Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.IMsixPackageApplications. Now the type is string.(Static). ⚠️ New-AzWvdAppAttachPackage 1 13 Mismatched_Parameter_Value_Type New-AzWvdAppAttachPackage -ImagePackageDependency $deps is not an expected parameter value type. -ImagePackageDependency Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.IMsixPackageDependencies. Now the type is string.(Static). ⚠️ New-AzWvdAppAttachPackage 2 6 Mismatched_Parameter_Value_Type New-AzWvdAppAttachPackage -AppAttachPackage imageObject is not an expected parameter value type. -AppAttachPackage Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.AppAttachPackage. Now the type is string.(Static). ⚠️ New-AzWvdMsixPackage 2 12 Mismatched_Parameter_Value_Type New-AzWvdMsixPackage -PackageApplication $apps is not an expected parameter value type. -PackageApplication Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.IMsixPackageApplications. Now the type is string.(Static). ⚠️ New-AzWvdMsixPackage 2 13 Mismatched_Parameter_Value_Type New-AzWvdMsixPackage -PackageDependency $deps is not an expected parameter value type. -PackageDependency Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.IMsixPackageDependencies. Now the type is string.(Static). ⚠️ Update-AzWvdAppAttachPackage 1 11 Mismatched_Parameter_Value_Type Update-AzWvdAppAttachPackage -ImagePackageApplication $apps is not an expected parameter value type. -ImagePackageApplication Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.IMsixPackageApplications. Now the type is string.(Static). ⚠️ Update-AzWvdAppAttachPackage 1 12 Mismatched_Parameter_Value_Type Update-AzWvdAppAttachPackage -ImagePackageDependency $deps is not an expected parameter value type. -ImagePackageDependency Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.IMsixPackageDependencies. Now the type is string.(Static). ⚠️ Update-AzWvdAppAttachPackage 2 5 Mismatched_Parameter_Value_Type Update-AzWvdAppAttachPackage -AppAttachPackage imageObject is not an expected parameter value type. -AppAttachPackage Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.AppAttachPackage. Now the type is string.(Static).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️ File Change Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.DesktopVirtualization. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
Member
Author
|
Looks like the only thing that failed is static analysis, and that seems to be a pipeline issue, not an issue with the module. |
Contributor
The breaking changes may be caused by API upgrading. You can commit your change into breaking change release |
|
To the author of the pull request, |
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
msJinLei
previously requested changes
Aug 29, 2024
src/DesktopVirtualization/DesktopVirtualization.Autorest/examples/Get-AzWvdAppAttachPackage.md
Outdated
Show resolved
Hide resolved
Member
Author
We updated our commonTypes that these properties are based on from v2 to a v5 version. That is possibly the cause of the breaking change? @msJinLei |
Member
Author
PR Where breaking changes were made in Swagger: Azure/azure-rest-api-specs#28637 |
vidai-msft
requested changes
Nov 1, 2024
src/DesktopVirtualization/DesktopVirtualization.Autorest/Az.DesktopVirtualization.psd1
Outdated
Show resolved
Hide resolved
src/DesktopVirtualization/DesktopVirtualization.Autorest/README.md
Outdated
Show resolved
Hide resolved
src/DesktopVirtualization/DesktopVirtualization.Autorest/README.md
Outdated
Show resolved
Hide resolved
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
vidai-msft
requested changes
Nov 5, 2024
src/DesktopVirtualization/DesktopVirtualization.Autorest/README.md
Outdated
Show resolved
Hide resolved
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.