New-AzGalleryImageVersion new parameter SourceImageVMId #24449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
|
| Type | Cmdlet | Example | Line | RuleName | Description | Extent | Remediation |
|---|---|---|---|---|---|---|---|
| New-AzGalleryImageVersion | 11 | 6 | Unassigned_Variable | New-AzGalleryImageVersion -SourceImageId $sourceImageId is a null-valued parameter value. | -SourceImageId | Assign value for $sourceImageId. | |
| New-AzGalleryImageVersion | 12 | 7 | Unassigned_Variable | New-AzGalleryImageVersion -SourceImageId $sourceImageId is a null-valued parameter value. | -SourceImageId | Assign value for $sourceImageId. |
⚠️ Windows PowerShell - Windows
| Type | Cmdlet | Example | Line | RuleName | Description | Extent | Remediation |
|---|---|---|---|---|---|---|---|
| New-AzGalleryImageVersion | 11 | 6 | Unassigned_Variable | New-AzGalleryImageVersion -SourceImageId $sourceImageId is a null-valued parameter value. | -SourceImageId | Assign value for $sourceImageId. | |
| New-AzGalleryImageVersion | 12 | 7 | Unassigned_Variable | New-AzGalleryImageVersion -SourceImageId $sourceImageId is a null-valued parameter value. | -SourceImageId | Assign value for $sourceImageId. |
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Ssh
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
Sandido
requested review from
bilaakpan-ms,
grizzlytheodore and
haagha
as code owners
src/Compute/Compute/Generated/GalleryImageVersion/GalleryImageVersionCreateOrUpdateMethod.cs
Outdated
Show resolved
Hide resolved
src/Compute/Compute/Generated/GalleryImageVersion/GalleryImageVersionCreateOrUpdateMethod.cs
Outdated
Show resolved
Hide resolved
Contributor
|
@Sandido Please address the review comments. |
Contributor
Author
@vidai-msft , done. The errors will happen on the backend when we can get that team to work on it. But this is an important feature to get in. I will be following up to ensure we can remove these. |
Contributor
Author
|
Apparently the vmID format and SourceImageID errors are already in the backend, so removing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1412
This adds a new parameter SourceImageVMId. This takes in a resourceId that is specifically for a VM. This cannot be used when the SourceImageId is also used.
Mandatory Checklist
Please choose the target release of Azure PowerShell
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.