Skip to content

az.codesigning initial version#23908

Merged
msJinLei merged 69 commits intoAzure:mainfrom
Jaxelr:feature/az.codesigning-initial-version
Feb 12, 2024
Merged

az.codesigning initial version#23908
msJinLei merged 69 commits intoAzure:mainfrom
Jaxelr:feature/az.codesigning-initial-version

Conversation

@Jaxelr
Copy link
Member

@Jaxelr Jaxelr commented Jan 9, 2024

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jan 9, 2024 •
edited
Loading

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.CodeSigning
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️Windows PowerShell - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.

@Jaxelr Jaxelr marked this pull request as ready for review January 9, 2024 14:48
@wyunchi-ms
Copy link
Contributor

wyunchi-ms commented Jan 10, 2024

Please exclude the changes for other modules.

wyunchi-ms
wyunchi-ms reviewed Jan 10, 2024
View reviewed changes
wyunchi-ms
wyunchi-ms reviewed Jan 10, 2024
View reviewed changes
wyunchi-ms
wyunchi-ms reviewed Jan 10, 2024
View reviewed changes
wyunchi-ms
wyunchi-ms reviewed Jan 10, 2024
View reviewed changes
wyunchi-ms
wyunchi-ms reviewed Jan 10, 2024
View reviewed changes
wyunchi-ms
wyunchi-ms reviewed Jan 10, 2024
View reviewed changes
wyunchi-ms
wyunchi-ms reviewed Jan 10, 2024
View reviewed changes
@Jaxelr Jaxelr requested a review from isra-fel as a code owner January 10, 2024 19:19
@Jaxelr
Copy link
Member Author

Jaxelr commented Jan 10, 2024 •
edited
Loading

Please exclude the changes for other modules.

Woops @wyunchi-ms, I'm really sorry for this mess. Already fixed on the branch.

msJinLei
msJinLei reviewed Jan 11, 2024
View reviewed changes
wyunchi-ms
wyunchi-ms reviewed Jan 12, 2024
View reviewed changes
wyunchi-ms
wyunchi-ms reviewed Jan 12, 2024
View reviewed changes
Copy link
Contributor

@wyunchi-ms wyunchi-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks the dlls under src/CodeSigning/CodeSigning/Libraries are data plane SDK. Please reference it from nuget and the nuget package should be strong name signed.

@Jaxelr
Copy link
Member Author

Jaxelr commented Jan 12, 2024

Looks the dlls under src/CodeSigning/CodeSigning/Libraries are data plane SDK. Please reference it from nuget and the nuget package should be strong name signed.

One of the packages included here does not exist on nuget.org currently, I'm discussing with the team to do the required publishing.

@github-actions
Copy link

github-actions bot commented Jan 19, 2024

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@Jaxelr Jaxelr requested a review from wyunchi-ms January 31, 2024 02:48
@Jaxelr
Copy link
Member Author

Jaxelr commented Jan 31, 2024

hey @wyunchi-ms could I request a re-review?

@Jaxelr Jaxelr requested a review from msJinLei January 31, 2024 13:06
wyunchi-ms
wyunchi-ms reviewed Feb 2, 2024
View reviewed changes
wyunchi-ms
wyunchi-ms reviewed Feb 2, 2024
View reviewed changes
wyunchi-ms
wyunchi-ms reviewed Feb 2, 2024
View reviewed changes
wyunchi-ms
wyunchi-ms reviewed Feb 2, 2024
View reviewed changes
wyunchi-ms and others added 16 commits February 12, 2024 09:58
@wyunchi-ms @Jaxelr
Update Get-AzCodeSigningCustomerEku.md
db98084
@wyunchi-ms @Jaxelr
Update Get-AzCodeSigningRootCert.md
08cadf3
@wyunchi-ms @Jaxelr
Update Invoke-AzCodeSigningCIPolicySigning.md
062b754
@wyunchi-ms @Jaxelr
Update Get-AzCodeSigningCustomerEku.md
fa74582
@Jaxelr
docs: fix help command markdowns
993c5b1
@Jaxelr
fix: modified code signing customer eku operation to return string array
76bdcfb
@Jaxelr
docs: corrected examples per guidance.
623d475
@Jaxelr
chore: remove unused constants
ceaead4
@Jaxelr
refactor: simplified object creation
15c923c
@Jaxelr
style: remove unused namespace, added space between props
00f6265
@Jaxelr
refactor: removed positions 4 and 5 from invoke ci policy signing
5b7a301
@Jaxelr
chore: bump Azure.CodeSigning.Client.CryptoProvider to version 0.1.16
1dbd7fa
@Jaxelr
chore: added module exception for static analysis
9b14dbe
@Jaxelr @msJinLei
Update src/CodeSigning/CodeSigning/ChangeLog.md
9ab298d 
Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com>
@Jaxelr
fix: per PR feedback, removing unused ps1
06ac441
@Jaxelr
chore: remove unused classes
a34ba65
@Jaxelr Jaxelr requested a review from msJinLei February 12, 2024 15:15
@msJinLei
Copy link
Contributor

msJinLei commented Feb 12, 2024

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Feb 12, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@msJinLei msJinLei merged commit bea8ec5 into Azure:main Feb 12, 2024
@Jaxelr Jaxelr deleted the feature/az.codesigning-initial-version branch February 12, 2024 20:21
@Jaxelr
Copy link
Member Author

Jaxelr commented Feb 12, 2024

Thanks for all your patience and help guys @msJinLei / @wyunchi-ms

msJinLei added a commit that referenced this pull request Feb 22, 2024
@msJinLei
Revert "az.codesigning initial version (#23908)"
756f3da 
This reverts commit bea8ec5.
@msJinLei msJinLei mentioned this pull request Feb 22, 2024
Merged
isra-fel pushed a commit that referenced this pull request Feb 22, 2024
@msJinLei
Revert "az.codesigning initial version (#23908)" (#24211)
573fb93 
This reverts commit bea8ec5.
wyunchi-ms added a commit that referenced this pull request Feb 23, 2024
@wyunchi-ms
Revert "Revert "az.codesigning initial version (#23908)" (#24211)"
11c52bb 
This reverts commit 573fb93.
msJinLei pushed a commit that referenced this pull request Feb 23, 2024
@wyunchi-ms
Add back of Az.CodeSigning (#24222)
7df078a 
* Revert "Revert "az.codesigning initial version (#23908)" (#24211)"

This reverts commit 573fb93.

* Fix some issues

* Add Az.CodeSigning.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isra-fel isra-fel Awaiting requested review from isra-fel

@wyunchi-ms wyunchi-ms Awaiting requested review from wyunchi-ms

1 more reviewer

@msJinLei msJinLei msJinLei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Jaxelr Jaxelr

@msJinLei msJinLei

Labels

Waiting for CI :shipit:

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jaxelr @wyunchi-ms @msJinLei @DawnWang17