Skip to content

Conversation

@mwesigwaguma
Copy link
Contributor

Description

Updating service fabric managed clusters to latest api preview version: Azure/azure-rest-api-specs#26178

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Nov 21, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.ServiceFabric
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00 % Test coverage for the module cannot be lower than 50%.
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ServiceFabricManagedClusters
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@NoriZC NoriZC self-assigned this Nov 21, 2023
@NoriZC
Copy link
Contributor

NoriZC commented Nov 22, 2023

Hi @mwesigwaguma The errors thrown by static analysis is a false positive. Please suppress it by putting this file here: https://github.com/mwesigwaguma/azure-powershell/tree/sfmc_2023-11-01-preview/tools/StaticAnalysis/Exceptions/Az.ServiceFabric

@mwesigwaguma
Copy link
Contributor Author

/

Hi @mwesigwaguma The errors thrown by static analysis is a false positive. Please suppress it by putting this file here: https://github.com/mwesigwaguma/azure-powershell/tree/sfmc_2023-11-01-preview/tools/StaticAnalysis/Exceptions/Az.ServiceFabric

updated!

@NoriZC
Copy link
Contributor

NoriZC commented Nov 28, 2023

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

NoriZC
NoriZC previously approved these changes Nov 28, 2023
@NoriZC
Copy link
Contributor

NoriZC commented Nov 28, 2023

please update the changelog

@NoriZC NoriZC dismissed their stale review November 28, 2023 01:49

changelog

@NoriZC
Copy link
Contributor

NoriZC commented Nov 28, 2023

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@NoriZC NoriZC merged commit 3330493 into Azure:main Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants