09-01-preview changes by hvedati · Pull Request #23122 · Azure/azure-powershell

hvedati · 2023-10-31T19:04:50Z

Description

Checklist

Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
SHOULD make the title of PR clear and informative, and in the present imperative tense.
SHOULD update ChangeLog.md file(s) appropriately
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
- Create new module from scratch
- Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
- Create new resource type which name doesn't use module name as prefix
- Have design question before implementation
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT introduce breaking changes in Az minor release except preview version.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2023-10-31T19:04:54Z

️✔️Az.Accounts

️✔️Build

️✔️PowerShell Core - Windows

⚠️Az.StackHCI

️✔️Build

️✔️PowerShell Core - Windows

️✔️Breaking Change Check

️✔️PowerShell Core - Windows

⚠️Signature Check

⚠️PowerShell Core - Windows

Type Cmdlet Description Remediation

⚠️ Get-AzStackHciArcSetting Get-AzStackHciArcSetting Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzStackHciArcSetting Get-AzStackHciArcSetting changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzStackHciCluster Get-AzStackHciCluster Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzStackHciCluster Get-AzStackHciCluster changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzStackHciExtension Get-AzStackHciExtension Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzStackHciExtension Get-AzStackHciExtension changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzStackHCIRemoteSupportAccess Get-AzStackHCIRemoteSupportAccess Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzStackHCIRemoteSupportAccess Get-AzStackHCIRemoteSupportAccess changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzStackHCIRemoteSupportSessionHistory Get-AzStackHCIRemoteSupportSessionHistory Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzStackHCIRemoteSupportSessionHistory Get-AzStackHCIRemoteSupportSessionHistory changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzStackHCIVmImage Get-AzStackHCIVmImage Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzStackHCIVmImage Get-AzStackHCIVmImage changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzStackHCIVmLogicalNetwork Get-AzStackHCIVmLogicalNetwork Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzStackHCIVmLogicalNetwork Get-AzStackHCIVmLogicalNetwork changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzStackHCIVmNetworkInterface Get-AzStackHCIVmNetworkInterface Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzStackHCIVmNetworkInterface Get-AzStackHCIVmNetworkInterface changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzStackHCIVmStoragePath Get-AzStackHCIVmStoragePath Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzStackHCIVmStoragePath Get-AzStackHCIVmStoragePath changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzStackHCIVmVirtualHardDisk Get-AzStackHCIVmVirtualHardDisk Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzStackHCIVmVirtualHardDisk Get-AzStackHCIVmVirtualHardDisk changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

️✔️Help Example Check

️✔️PowerShell Core - Windows

️✔️Help File Existence Check

️✔️PowerShell Core - Windows

⚠️File Change Check

⚠️PowerShell Core - Windows

Type Cmdlet Description Remediation

⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.StackHCI. Add a changelog record under Upcoming Release section with past tense.

️✔️UX Metadata Check

️✔️PowerShell Core - Windows

⚠️Test

⚠️ - Linux

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 18.97 % Test coverage for the module cannot be lower than 50%.

⚠️ - MacOS

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 18.97% Test coverage for the module cannot be lower than 50%.

⚠️PowerShell Core - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 18.97% Test coverage for the module cannot be lower than 50%.

hvedati · 2023-10-31T19:06:49Z

@VeryEarly Please let me know if this PR is good to merge.

VeryEarly

there is a folder export under docs, please remove this folder and move help markdown under docs

src/StackHCI/StackHCIVm/README.md

VeryEarly

folder structure is incorrect, there should be folders for both StackHCIVm and StackHCI

VeryEarly

inconsistent term "StackHCIVM" "StackHCIVm"

VeryEarly · 2023-11-01T10:55:34Z

src/StackHCI/StackHCIVm/README.md

+title: StackHCIVm
+service-name: StackHCIVm
+subject-prefix: $(service-name)
+


add line: root-module-name: $(prefix).StackHCI

VeryEarly

why deleting src/StackHCI/examples/Get-AzStackHCILogsDirectory.md?

src/StackHCI/StackHCIVm/test/envValues.json

VeryEarly · 2023-11-01T11:02:10Z

this PR is far from ready, I don't think it catch 2023-11-14 release, please consider move to some latter iterations.

hvedati · 2023-11-01T15:53:41Z

folder structure is incorrect, there should be folders for both StackHCIVm and StackHCI

@VeryEarly I was told that I need to only include the files for the new StackHCIVm module in the PR. I have had this conversation with other engineers in previous iterations!

hvedati · 2023-11-01T16:00:30Z

there is a folder export under docs, please remove this folder and move help markdown under docs

I have moved these markdown files just under the doc section.

hvedati · 2023-11-07T03:12:59Z

PS E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest> .\test-module.ps1 -Playback
Creating isolated process...
Pester v4.10.1
Executing all tests in 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test'

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Add-AzStackHCIVmVirtualMachineDataDisk.Tests.ps1

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Add-AzStackHCIVmVirtualMachineNetworkInterface.Tests.ps1

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\AzStackHCIVmImageNew.Tests.ps1
Running 'playback' mode...
Using recording E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\AzStackHCIVmImageNew.Recording.json

Describing AzStackHCIVmImageNew
[+] Create Image 423ms
[+] List 116ms
[+] Get 33ms
WARNING: Running this command will delete the image.
[+] Delete 651ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\AzStackHciVmLogicalNetwork.Tests.ps1
Running 'playback' mode...
Using recording E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\AzStackHCIVmLogicalNetwork.Recording.json

Describing AzStackHCIVmLogicalNetwork
[+] Create Logical Network 143ms
[+] List 58ms
[+] Get 54ms
WARNING: Running this command will delete the logical network.
[+] Delete 317ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\AzStackHciVmNetworkInterface.Tests.ps1
Running 'playback' mode...
Using recording E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\AzStackHCIVmNetworkInterface.Recording.json

Describing AzStackHCIVmNetworkInterface
[+] Create Network Interface 358ms
[+] List 63ms
[+] Get 32ms
WARNING: Running this command will delete the network interface.
[+] Delete 273ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\AzStackHciVmStoragePath.Tests.ps1
Running 'playback' mode...
Using recording E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\AzStackHCIVmStoragePath.Recording.json

Describing AzStackHCIVmStoragePath
[+] Create Storage Path 131ms
[+] List 51ms
[+] Get 30ms
WARNING: Running this command will delete the storage path.
[+] Delete 79ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\AzStackHCIVmVirtualHardDisks.Tests.ps1
Running 'playback' mode...
Using recording E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\AzStackHCIVmVirtualHardDisks.Recording.json

Describing AzStackHCIVmVirtualHardDisks
[+] Create 134ms
[+] List 39ms
[+] Get 46ms
WARNING: Running this command will delete the virtual hard disk.
[+] Delete 401ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\AzStackHciVmVirtualMachine.Tests.ps1
Running 'playback' mode...
Using recording E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\AzStackHCIVmVirtualMachine.Recording.json

Describing AzStackHCIVmVirtualMachine
[+] Create Virtual Machine 564ms
[+] Get 47ms
[+] Stop 130ms
[+] Start 96ms
WARNING: Running this command will delete the virtual machine.
[+] Delete 181ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Get-AzStackHCIVmImage.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Get-AzStackHCIVmImage.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Get-AzStackHCIVmImage
[!] BySubscription, is skipped 0ms
[!] ByName, is skipped 0ms
[!] ByResourceGroup, is skipped 0ms
[!] ByResourceId, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Get-AzStackHciVMLogicalNetwork.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Get-AzStackHciVMLogicalNetwork.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Get-AzStackHciVMLogicalNetwork
[!] List1, is skipped 0ms
[!] Get, is skipped 0ms
[!] List, is skipped 0ms
[!] ByResourceId, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Get-AzStackHciVMNetworkInterface.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Get-AzStackHciVMNetworkInterface.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Get-AzStackHciVMNetworkInterface
[!] List1, is skipped 0ms
[!] Get, is skipped 0ms
[!] List, is skipped 0ms
[!] ByResourceId, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Get-AzStackHciVMStoragePath.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Get-AzStackHciVMStoragePath.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Get-AzStackHciVMStoragePath
[!] List1, is skipped 0ms
[!] Get, is skipped 0ms
[!] List, is skipped 0ms
[!] ByResourceId, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Get-AzStackHciVMVirtualHardDisk.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Get-AzStackHciVMVirtualHardDisk.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Get-AzStackHciVMVirtualHardDisk
[!] List1, is skipped 0ms
[!] Get, is skipped 0ms
[!] List, is skipped 0ms
[!] ByResourceId, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Get-AzStackHCIVmVirtualMachine.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Get-AzStackHCIVmVirtualMachine.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Get-AzStackHCIVmVirtualMachine
[!] BySubscription, is skipped 0ms
[!] ByName, is skipped 0ms
[!] ByResourceGroup, is skipped 0ms
[!] ByResourceId, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\New-AzStackHCIVmImage.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\New-AzStackHCIVmImage.Recording.json' is not present. Tests expecting recorded responses will fail

Describing New-AzStackHCIVmImage
[!] MarketplaceURN, is skipped 0ms
[!] GalleryImage, is skipped 0ms
[!] Marketplace, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\New-AzStackHCIVmLogicalNetwork.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\New-AzStackHCIVmLogicalNetwork.Recording.json' is not present. Tests expecting recorded responses will fail

Describing New-AzStackHCIVmLogicalNetwork
[!] __AllParameterSets, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\New-AzStackHCIVmNetworkInterface.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\New-AzStackHCIVmNetworkInterface.Recording.json' is not present. Tests expecting recorded responses will fail

Describing New-AzStackHCIVmNetworkInterface
[!] __AllParameterSets, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\New-AzStackHCIVmStoragePath.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\New-AzStackHCIVmStoragePath.Recording.json' is not present. Tests expecting recorded responses will fail

Describing New-AzStackHCIVmStoragePath
[!] __AllParameterSets, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\New-AzStackHCIVmVirtualHardDisk.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\New-AzStackHCIVmVirtualHardDisk.Recording.json' is not present. Tests expecting recorded responses will fail

Describing New-AzStackHCIVmVirtualHardDisk
[!] __AllParameterSets, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\New-AzStackHCIVmVirtualMachine.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\New-AzStackHCIVmVirtualMachine.Recording.json' is not present. Tests expecting recorded responses will fail

Describing New-AzStackHCIVmVirtualMachine
[!] ByImageId, is skipped 0ms
[!] ByImageName, is skipped 0ms
[!] ByOsDiskId, is skipped 0ms
[!] ByOsDiskName, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Remove-AzStackHCIVmImage.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Remove-AzStackHCIVmImage.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Remove-AzStackHCIVmImage
[!] ByResourceId, is skipped 0ms
[!] ByName, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Remove-AzStackHCIVmLogicalNetwork.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Remove-AzStackHCIVmLogicalNetwork.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Remove-AzStackHCIVmLogicalNetwork
[!] ByResourceId, is skipped 0ms
[!] Delete, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Remove-AzStackHCIVmNetworkInterface.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Remove-AzStackHCIVmNetworkInterface.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Remove-AzStackHCIVmNetworkInterface
[!] ByResourceId, is skipped 0ms
[!] ByName, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Remove-AzStackHCIVmStoragePath.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Remove-AzStackHCIVmStoragePath.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Remove-AzStackHCIVmStoragePath
[!] ByResourceId, is skipped 0ms
[!] ByName, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Remove-AzStackHCIVmVirtualHardDisk.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Remove-AzStackHCIVmVirtualHardDisk.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Remove-AzStackHCIVmVirtualHardDisk
[!] ByResourceId, is skipped 0ms
[!] ByName, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Remove-AzStackHCIVmVirtualMachine.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Remove-AzStackHCIVmVirtualMachine.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Remove-AzStackHCIVmVirtualMachine
[!] ByResourceId, is skipped 0ms
[!] ByName, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Remove-AzStackHCIVmVirtualMachineDataDisk.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Remove-AzStackHCIVmVirtualMachineDataDisk.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Remove-AzStackHCIVmVirtualMachineDataDisk
[!] ByResourceId, is skipped 0ms
[!] ByName, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Remove-AzStackHCIVmVirtualMachineNetworkInterface.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Remove-AzStackHCIVmVirtualMachineNetworkInterface.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Remove-AzStackHCIVmVirtualMachineNetworkInterface
[!] ByResourceId, is skipped 0ms
[!] ByName, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Restart-AzStackHCIVmVirtualMachine.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Restart-AzStackHCIVmVirtualMachine.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Restart-AzStackHCIVmVirtualMachine
[!] ByResourceId, is skipped 0ms
[!] ByName, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Start-AzStackHCIVmVirtualMachine.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Start-AzStackHCIVmVirtualMachine.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Start-AzStackHCIVmVirtualMachine
[!] ByResourceId, is skipped 0ms
[!] ByName, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Stop-AzStackHCIVmVirtualMachine.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Stop-AzStackHCIVmVirtualMachine.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Stop-AzStackHCIVmVirtualMachine
[!] ByResourceId, is skipped 0ms
[!] ByName, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Update-AzStackHCIVmImage.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Update-AzStackHCIVmImage.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Update-AzStackHCIVmImage
[!] ByResourceId, is skipped 0ms
[!] ByName, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Update-AzStackHciVMLogicalNetwork.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Update-AzStackHciVMLogicalNetwork.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Update-AzStackHciVMLogicalNetwork
[!] ByResourceId, is skipped 0ms
[!] UpdateExpanded, is skipped 0ms
[!] UpdateViaIdentityExpanded, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Update-AzStackHciVMNetworkInterface.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Update-AzStackHciVMNetworkInterface.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Update-AzStackHciVMNetworkInterface
[!] ByResourceId, is skipped 0ms
[!] UpdateExpanded, is skipped 0ms
[!] UpdateViaIdentityExpanded, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Update-AzStackHciVMStoragePath.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Update-AzStackHciVMStoragePath.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Update-AzStackHciVMStoragePath
[!] ByResourceId, is skipped 0ms
[!] UpdateExpanded, is skipped 0ms
[!] UpdateViaIdentityExpanded, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Update-AzStackHciVMVirtualHardDisk.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Update-AzStackHciVMVirtualHardDisk.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Update-AzStackHciVMVirtualHardDisk
[!] ByResourceId, is skipped 0ms
[!] UpdateExpanded, is skipped 0ms
[!] UpdateViaIdentityExpanded, is skipped 0ms

Executing script E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Update-AzStackHCIVmVirtualMachine.Tests.ps1
Running 'playback' mode...
Recording file 'E:\new\azure-powershell2\src\StackHCI\StackHCIVm.Autorest\test\Update-AzStackHCIVmVirtualMachine.Recording.json' is not present. Tests expecting recorded responses will fail

Describing Update-AzStackHCIVmVirtualMachine
[!] ByResourceId, is skipped 0ms
[!] ByName, is skipped 0ms
Tests completed in 11.53s
Tests Passed: 25, Failed: 0, Skipped: 73, Pending: 0, Inconclusive: 0

This reverts commit 5c8e408.

09-01-preview changes

f4a2418

hvedati added this to the Az 11.0.0 (November 2023, 2023-11-14)❗ Breaking change release ❗ milestone Oct 31, 2023

hvedati assigned VeryEarly Oct 31, 2023

Harika Vedati added 5 commits October 31, 2023 12:28

removing examples for hidden cmdlets

f082dbe

removing extra example files

f4896b8

removing extra tests

c876d0d

adding updating examples

049360b

updating docs

ca09226

VeryEarly requested changes Nov 1, 2023

View reviewed changes

src/StackHCI/StackHCIVm/README.md Outdated Show resolved Hide resolved

VeryEarly requested changes Nov 1, 2023

View reviewed changes

VeryEarly reviewed Nov 1, 2023

View reviewed changes

src/StackHCI/StackHCIVm/test/envValues.json Outdated Show resolved Hide resolved

hvedati closed this Nov 1, 2023

hvedati reopened this Nov 1, 2023

Harika Vedati added 10 commits November 1, 2023 09:04

adding log directory example back

60dde45

removing envValues.json

b304a9e

adding root module

8d8c21c

getting rid of local paths

62a07d5

bug fixes

db11128

fixes

0282aff

updates

8add0cb

removing ip config and subnet conig

e8cd84a

fixing example formating

e0bf112

fixing get and update

3dbd501

Harika Vedati added 14 commits November 6, 2023 13:46

fixing parameters in VM create

205597a

removing example stub from each custom file

1ac0eb0

updating example files

952fa17

fixing subnet in logical network

bce17c3

adding logical network recording

e641f6b

addig vhd and nic recording

01eae12

adding storage path recording

c0cc7f5

adding default param to new cmdlets

a6178de

virtual machine recording

5592cdf

adding image recording

bf885fe

fixing lnet ippool and test reordings

9d2577a

fixing v disk addand nic add

34e97cf

addig passig tests

4fb7568

adding passing recording for nic

4f62593

Harika Vedati added 5 commits November 6, 2023 20:36

fixing nic json

e16110d

fixing vm json

e609038

fixing vm recording

ceccc53

fixing network interface recording

0a8c992

passing default param through new-nic

ce125bf

VeryEarly force-pushed the dev/hv/addingStackHCIVmPreviewModule branch 2 times, most recently from 64da914 to ce125bf Compare November 7, 2023 13:41

VeryEarly added 3 commits November 7, 2023 22:13

fix file name for some examples and docs, fix online version uri

20fb34d

add ux files

81e9466

remove asjob for get cmdlets

57ce56b

VeryEarly approved these changes Nov 7, 2023

View reviewed changes

VeryEarly merged commit 5c8e408 into Azure:generation Nov 7, 2023

VeryEarly added a commit that referenced this pull request Nov 8, 2023

Revert "09-01-preview changes (#23122)"

937e83e

This reverts commit 5c8e408.

VeryEarly mentioned this pull request Nov 8, 2023

Revert "09-01-preview changes" #23300

Merged

NoriZC pushed a commit that referenced this pull request Nov 8, 2023

Revert "09-01-preview changes (#23122)" (#23300)

be223ad

This reverts commit 5c8e408.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

09-01-preview changes#23122

09-01-preview changes#23122
VeryEarly merged 66 commits intoAzure:generationfrom
hvedati:dev/hv/addingStackHCIVmPreviewModule

hvedati commented Oct 31, 2023

Uh oh!

azure-client-tools-bot-prd bot commented Oct 31, 2023 •

edited

Loading

Uh oh!

hvedati commented Oct 31, 2023

Uh oh!

VeryEarly left a comment

Uh oh!

Uh oh!

VeryEarly left a comment

Uh oh!

VeryEarly left a comment

Uh oh!

VeryEarly Nov 1, 2023

Uh oh!

VeryEarly left a comment

Uh oh!

Uh oh!

VeryEarly commented Nov 1, 2023

Uh oh!

hvedati commented Nov 1, 2023

Uh oh!

hvedati commented Nov 1, 2023

Uh oh!

hvedati commented Nov 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

hvedati commented Oct 31, 2023

Description

Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hvedati commented Oct 31, 2023

Uh oh!

VeryEarly left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

VeryEarly left a comment

Choose a reason for hiding this comment

Uh oh!

VeryEarly left a comment

Choose a reason for hiding this comment

Uh oh!

VeryEarly Nov 1, 2023

Choose a reason for hiding this comment

Uh oh!

VeryEarly left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

VeryEarly commented Nov 1, 2023

Uh oh!

hvedati commented Nov 1, 2023

Uh oh!

hvedati commented Nov 1, 2023

Uh oh!

hvedati commented Nov 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

azure-client-tools-bot-prd bot commented Oct 31, 2023 •

edited

Loading