Skip to content

Adjust Publish-AzWebApp default parameters #22832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VeryEarly merged 4 commits into from
Sep 27, 2023
Merged

Adjust Publish-AzWebApp default parameters #22832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
171404f
Adjust Publish-AzWebApp default behavior
dannysongg Sep 20, 2023
2eb90e5
Update tests and async behavior
dannysongg Sep 20, 2023
a9d2a61
Moving release notes to upcoming release
dannysongg Sep 27, 2023
b1b8361
Update ChangeLog.md
VeryEarly Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Websites/Websites.Test/ScenarioTests/WebAppTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1274,7 +1274,7 @@ function Test-PublishAzureWebAppOnedeploy
New-AzResource -PropertyObject $PropertiesObject -ResourceGroupName $rgname -ResourceType Microsoft.Web/sites/config -ResourceName "$appName/web" -ApiVersion 2018-02-01 -Force

$warPath = Join-Path $ResourcesPath "HelloJava.war"
$publishedApp = Publish-AzWebApp -ResourceGroupName $rgname -Name $appName -ArchivePath $warPath -Type war -Clean $true -TargetPath /home/site/wwwroot/webapps/ROOT -Force
$publishedApp = Publish-AzWebApp -ResourceGroupName:$rgname -Name:$appName -ArchivePath:$warPath -Type:war -Clean:$true -TargetPath:/home/site/wwwroot/webapps/ROOT -Force

Assert-NotNull $publishedApp
}
Expand Down
1,130 changes: 490 additions & 640 deletions ...soft.Azure.Commands.Websites.Test.ScenarioTests.WebAppTests/TestPublishWebAppFromWar.json
View file
Open in desktop

Large diffs are not rendered by default.

942 changes: 510 additions & 432 deletions ...soft.Azure.Commands.Websites.Test.ScenarioTests.WebAppTests/TestPublishWebAppFromZip.json
View file
Open in desktop

Large diffs are not rendered by default.

1,000 changes: 653 additions & 347 deletions ...ft.Azure.Commands.Websites.Test.ScenarioTests.WebAppTests/TestPublishWebAppOneDeploy.json
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/Websites/Websites/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Additional information about change #1
-->
## Upcoming Release
* Adjusted `Publish-AzWebApp` default behavior

## Version 3.1.1
* Added support for XenonMV3 webapps
Expand Down
36 changes: 31 additions & 5 deletions src/Websites/Websites/Cmdlets/WebApps/PublishAzureWebApp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,37 @@ public override void ExecuteCmdlet()
}

paramValues.Add("path", TargetPath);
paramValues.Add("isasync", Async.IsPresent.ToString());
paramValues.Add("restart", Restart.IsPresent.ToString());
paramValues.Add("clean", Clean.IsPresent.ToString());
paramValues.Add("ignorestack", IgnoreStack.IsPresent.ToString());
paramValues.Add("reset", Reset.IsPresent.ToString());

// default async to true if not provided to match old behavior
if (Async.IsPresent)
{
paramValues.Add("async", Async.ToString());
}

else
{
paramValues.Add("async", "true");
}

if (Restart.IsPresent)
{
paramValues.Add("restart", Restart.ToString());
}

if (Clean.IsPresent)
{
paramValues.Add("clean", Clean.ToString());
}

if (IgnoreStack.IsPresent)
{
paramValues.Add("ignorestack", IgnoreStack.ToString());
}

if (Reset.IsPresent)
{
paramValues.Add("reset", Reset.ToString());
}

uriBuilder.Query = paramValues.ToString();

Expand Down