Skip to content

Add SecurityType of Standard to VM and VMSS cmdlets for Trusted Launch, includes breaking changes#22534

Merged
YanaXu merged 19 commits intomainfrom
adsandor/sectypestnd
Aug 21, 2023
Merged

Add SecurityType of Standard to VM and VMSS cmdlets for Trusted Launch, includes breaking changes#22534
YanaXu merged 19 commits intomainfrom
adsandor/sectypestnd

Conversation

@Sandido
Copy link
Contributor

@Sandido Sandido commented Aug 9, 2023 •
edited
Loading

Description

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1270

This PR is preliminary work for the Trusted Launch feature where VMs need to have a way for customers to opt out of the TL feature once TL is the default in the near future.
The plan is to allow the user to supply the value Standard to SecurityType. This value does not actually exist on the backend RP or in ARM yet. The PS and CLI clients will take in Standard and just ensure that the SecurityType is not defaulted to TL.

This PR includes breaking changes and suppressions for them. The 2 breaking changes are the same type in 2 different cmdlets.

  1. Set-AzVMSecurityProfile
  2. Set-AzVmssSecurityProfile
    Where the change was adding a ValidateSet parameter group to the SecurityType parameter. I think this change should be allowed as the SecurityType parameter has always been restricted on the backend to only ConfidentialVM and TrustedLaunch. In the future, this will be expanded to Standard, hence my work here.
    I don't think this is a breaking change in practice since these values were always restricted to certain strings.
    If this is actually a breaking change that could harm our customers, please let me know and I will revert this.
    UPDATE: I removed these validations for now.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 9, 2023 •
edited
Loading

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ApplicationInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzVM 4 20 Unassigned_Variable New-AzVM -Credential $cred is a null-valued parameter value. -Credential Assign value for $cred.
⚠️ New-AzVM 6 10 Unassigned_Variable New-AzVmssConfig -Location $loc is a null-valued parameter value. -Location Assign value for $loc.
⚠️ New-AzVM 6 10 Unassigned_Variable New-AzVmssConfig -PlatformFaultDomainCount $vmssFaultDomain is a null-valued parameter value. -PlatformFaultDomainCount Assign value for $vmssFaultDomain.
⚠️ New-AzVM 8 9 Unassigned_Variable New-AzResourceGroup -Name $rgname is a null-valued parameter value. -Name Assign value for $rgname.
⚠️ New-AzVM 8 14 Unassigned_Variable New-AzVM -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ New-AzVM 8 16 Unassigned_Variable Get-AzVM -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ New-AzVmss 4 33 Mismatched_Parameter_Value_Type Set-AzVmssOsProfile -AdminPassword $adminPassword is not an expected parameter value type. -AdminPassword Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command).
⚠️ New-AzVmssConfig 1 1 Unassigned_Variable New-AzVmssConfig -Location $Loc is a null-valued parameter value. -Location Assign value for $Loc.
⚠️ New-AzVmssConfig 1 1 Unassigned_Variable New-AzVmssConfig -NetworkInterfaceConfiguration $NetCfg is a null-valued parameter value. -NetworkInterfaceConfiguration Assign value for $NetCfg.
⚠️ New-AzVmssConfig 1 2 Unassigned_Variable Add-AzVmssNetworkInterfaceConfiguration -IPConfiguration $IPCfg is a null-valued parameter value. -IPConfiguration Assign value for $IPCfg.
⚠️ New-AzVmssConfig 1 3 Unassigned_Variable Set-AzVmssOsProfile -AdminUsername $adminUsername is a null-valued parameter value. -AdminUsername Assign value for $adminUsername.
⚠️ New-AzVmssConfig 1 3 Unassigned_Variable Set-AzVmssOsProfile -AdminPassword $AdminPassword is a null-valued parameter value. -AdminPassword Assign value for $AdminPassword.
⚠️ New-AzVmssConfig 1 5 Unassigned_Variable Set-AzVmssStorageProfile -ImageReferenceOffer $ImgRef.Offer is a null-valued parameter value. -ImageReferenceOffer Assign value for $ImgRef.Offer.
⚠️ New-AzVmssConfig 1 5 Unassigned_Variable Set-AzVmssStorageProfile -ImageReferenceSku $ImgRef.Skus is a null-valued parameter value. -ImageReferenceSku Assign value for $ImgRef.Skus.
⚠️ New-AzVmssConfig 1 5 Unassigned_Variable Set-AzVmssStorageProfile -ImageReferenceVersion $ImgRef.Version is a null-valued parameter value. -ImageReferenceVersion Assign value for $ImgRef.Version.
⚠️ New-AzVmssConfig 1 6 Unassigned_Variable Set-AzVmssStorageProfile -ImageReferencePublisher $ImgRef.PublisherName is a null-valued parameter value. -ImageReferencePublisher Assign value for $ImgRef.PublisherName.
⚠️ New-AzVmssConfig 1 6 Unassigned_Variable Set-AzVmssStorageProfile -VhdContainer $VHDContainer is a null-valued parameter value. -VhdContainer Assign value for $VHDContainer.
⚠️ New-AzVmssConfig 1 7 Unassigned_Variable Add-AzVmssAdditionalUnattendContent -ComponentName $AUCComponentName is a null-valued parameter value. -ComponentName Assign value for $AUCComponentName.
⚠️ New-AzVmssConfig 1 7 Unassigned_Variable Add-AzVmssAdditionalUnattendContent -Content $AUCContent is a null-valued parameter value. -Content Assign value for $AUCContent.
⚠️ New-AzVmssConfig 1 7 Unassigned_Variable Add-AzVmssAdditionalUnattendContent -PassName $AUCPassName is a null-valued parameter value. -PassName Assign value for $AUCPassName.
⚠️ New-AzVmssConfig 1 7 Unassigned_Variable Add-AzVmssAdditionalUnattendContent -SettingName $AUCSetting is a null-valued parameter value. -SettingName Assign value for $AUCSetting.
⚠️ New-AzVmssConfig 1 9 Unassigned_Variable New-AzVmss -ResourceGroupName $RGName is a null-valued parameter value. -ResourceGroupName Assign value for $RGName.
⚠️ New-AzVmssConfig 1 9 Unassigned_Variable New-AzVmss -Name $VMSSName is a null-valued parameter value. -Name Assign value for $VMSSName.
⚠️ New-AzVmssConfig 4 18 Unassigned_Variable New-AzStorageAccount -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ New-AzVmssConfig 4 18 Unassigned_Variable New-AzStorageAccount -Location $loc is a null-valued parameter value. -Location Assign value for $loc.
⚠️ New-AzVmssConfig 4 19 Unassigned_Variable Get-AzStorageAccount -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ New-AzVmssConfig 4 23 Unassigned_Variable New-AzVirtualNetwork -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ New-AzVmssConfig 4 23 Unassigned_Variable New-AzVirtualNetwork -Location $loc is a null-valued parameter value. -Location Assign value for $loc.
⚠️ New-AzVmssConfig 4 24 Unassigned_Variable Get-AzVirtualNetwork -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ New-AzVmssConfig 4 30 Unassigned_Variable New-AzVmssConfig -Location $loc is a null-valued parameter value. -Location Assign value for $loc.
⚠️ New-AzVmssConfig 4 37 Unassigned_Variable New-AzVmss -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ New-AzVmssConfig 4 39 Unassigned_Variable Get-AzVmss -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ New-AzVmssConfig 5 36 Mismatched_Parameter_Value_Type Set-AzVmssOsProfile -AdminPassword $adminPassword is not an expected parameter value type. -AdminPassword Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command).
⚠️ Set-AzVMSecurityProfile 2 8 Mismatched_Parameter_Value_Type ConvertTo-SecureString -[-String] $password is not an expected parameter value type. $password Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command).
⚠️ Set-AzVMSecurityProfile 2 9 Unassigned_Variable New-Object -[-ArgumentList] ($user, $securePassword) is a null-valued parameter value. ($user, $securePassword) Assign value for ($user, $securePassword).
⚠️ Set-AzVMSecurityProfile 2 13 Unassigned_Variable New-AzVMConfig -VMName $VMName is a null-valued parameter value. -VMName Assign value for $VMName.
⚠️ Set-AzVMSecurityProfile 2 16 Unassigned_Variable New-AzVirtualNetworkSubnetConfig -Name $SubnetName is a null-valued parameter value. -Name Assign value for $SubnetName.
⚠️ Set-AzVMSecurityProfile 2 17 Unassigned_Variable New-AzVirtualNetwork -Name $NetworkName is a null-valued parameter value. -Name Assign value for $NetworkName.
⚠️ Set-AzVMSecurityProfile 2 17 Unassigned_Variable New-AzVirtualNetwork -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Set-AzVMSecurityProfile 2 17 Unassigned_Variable New-AzVirtualNetwork -Location $LocationName is a null-valued parameter value. -Location Assign value for $LocationName.
⚠️ Set-AzVMSecurityProfile 2 18 Unassigned_Variable New-AzPublicIpAddress -Name $PublicIPAddressName is a null-valued parameter value. -Name Assign value for $PublicIPAddressName.
⚠️ Set-AzVMSecurityProfile 2 18 Unassigned_Variable New-AzPublicIpAddress -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Set-AzVMSecurityProfile 2 18 Unassigned_Variable New-AzPublicIpAddress -Location $LocationName is a null-valued parameter value. -Location Assign value for $LocationName.
⚠️ Set-AzVMSecurityProfile 2 19 Unassigned_Variable New-AzNetworkInterface -Name $NICName is a null-valued parameter value. -Name Assign value for $NICName.
⚠️ Set-AzVMSecurityProfile 2 19 Unassigned_Variable New-AzNetworkInterface -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Set-AzVMSecurityProfile 2 19 Unassigned_Variable New-AzNetworkInterface -Location $LocationName is a null-valued parameter value. -Location Assign value for $LocationName.
⚠️ Set-AzVMSecurityProfile 2 20 Unassigned_Variable Set-AzVMOperatingSystem -ComputerName $ComputerName is a null-valued parameter value. -ComputerName Assign value for $ComputerName.
⚠️ Set-AzVMSecurityProfile 2 32 Unassigned_Variable New-AzVM -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Set-AzVMSecurityProfile 2 32 Unassigned_Variable New-AzVM -Location $LocationName is a null-valued parameter value. -Location Assign value for $LocationName.
⚠️ Set-AzVMSecurityProfile 2 33 Unassigned_Variable Get-AzVm -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Set-AzVMSecurityProfile 2 33 Unassigned_Variable Get-AzVm -Name $vmname is a null-valued parameter value. -Name Assign value for $vmname.
⚠️ Set-AzVmssSecurityProfile 2 40 Mismatched_Parameter_Value_Type Set-AzVmssOsProfile -AdminPassword $adminPassword is not an expected parameter value type. -AdminPassword Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command).
⚠️ Update-AzVmss 1 1 Unassigned_Variable Update-AzVmss -VirtualMachineScaleSet $LocalVMSS is a null-valued parameter value. -VirtualMachineScaleSet Assign value for $LocalVMSS.
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzVM 4 20 Unassigned_Variable New-AzVM -Credential $cred is a null-valued parameter value. -Credential Assign value for $cred.
⚠️ New-AzVM 6 10 Unassigned_Variable New-AzVmssConfig -Location $loc is a null-valued parameter value. -Location Assign value for $loc.
⚠️ New-AzVM 6 10 Unassigned_Variable New-AzVmssConfig -PlatformFaultDomainCount $vmssFaultDomain is a null-valued parameter value. -PlatformFaultDomainCount Assign value for $vmssFaultDomain.
⚠️ New-AzVM 8 9 Unassigned_Variable New-AzResourceGroup -Name $rgname is a null-valued parameter value. -Name Assign value for $rgname.
⚠️ New-AzVM 8 14 Unassigned_Variable New-AzVM -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ New-AzVM 8 16 Unassigned_Variable Get-AzVM -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ New-AzVmss 4 33 Mismatched_Parameter_Value_Type Set-AzVmssOsProfile -AdminPassword $adminPassword is not an expected parameter value type. -AdminPassword Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command).
⚠️ New-AzVmssConfig 1 1 Unassigned_Variable New-AzVmssConfig -Location $Loc is a null-valued parameter value. -Location Assign value for $Loc.
⚠️ New-AzVmssConfig 1 1 Unassigned_Variable New-AzVmssConfig -NetworkInterfaceConfiguration $NetCfg is a null-valued parameter value. -NetworkInterfaceConfiguration Assign value for $NetCfg.
⚠️ New-AzVmssConfig 1 2 Unassigned_Variable Add-AzVmssNetworkInterfaceConfiguration -IPConfiguration $IPCfg is a null-valued parameter value. -IPConfiguration Assign value for $IPCfg.
⚠️ New-AzVmssConfig 1 3 Unassigned_Variable Set-AzVmssOsProfile -AdminUsername $adminUsername is a null-valued parameter value. -AdminUsername Assign value for $adminUsername.
⚠️ New-AzVmssConfig 1 3 Unassigned_Variable Set-AzVmssOsProfile -AdminPassword $AdminPassword is a null-valued parameter value. -AdminPassword Assign value for $AdminPassword.
⚠️ New-AzVmssConfig 1 5 Unassigned_Variable Set-AzVmssStorageProfile -ImageReferenceOffer $ImgRef.Offer is a null-valued parameter value. -ImageReferenceOffer Assign value for $ImgRef.Offer.
⚠️ New-AzVmssConfig 1 5 Unassigned_Variable Set-AzVmssStorageProfile -ImageReferenceSku $ImgRef.Skus is a null-valued parameter value. -ImageReferenceSku Assign value for $ImgRef.Skus.
⚠️ New-AzVmssConfig 1 5 Unassigned_Variable Set-AzVmssStorageProfile -ImageReferenceVersion $ImgRef.Version is a null-valued parameter value. -ImageReferenceVersion Assign value for $ImgRef.Version.
⚠️ New-AzVmssConfig 1 6 Unassigned_Variable Set-AzVmssStorageProfile -ImageReferencePublisher $ImgRef.PublisherName is a null-valued parameter value. -ImageReferencePublisher Assign value for $ImgRef.PublisherName.
⚠️ New-AzVmssConfig 1 6 Unassigned_Variable Set-AzVmssStorageProfile -VhdContainer $VHDContainer is a null-valued parameter value. -VhdContainer Assign value for $VHDContainer.
⚠️ New-AzVmssConfig 1 7 Unassigned_Variable Add-AzVmssAdditionalUnattendContent -ComponentName $AUCComponentName is a null-valued parameter value. -ComponentName Assign value for $AUCComponentName.
⚠️ New-AzVmssConfig 1 7 Unassigned_Variable Add-AzVmssAdditionalUnattendContent -Content $AUCContent is a null-valued parameter value. -Content Assign value for $AUCContent.
⚠️ New-AzVmssConfig 1 7 Unassigned_Variable Add-AzVmssAdditionalUnattendContent -PassName $AUCPassName is a null-valued parameter value. -PassName Assign value for $AUCPassName.
⚠️ New-AzVmssConfig 1 7 Unassigned_Variable Add-AzVmssAdditionalUnattendContent -SettingName $AUCSetting is a null-valued parameter value. -SettingName Assign value for $AUCSetting.
⚠️ New-AzVmssConfig 1 9 Unassigned_Variable New-AzVmss -ResourceGroupName $RGName is a null-valued parameter value. -ResourceGroupName Assign value for $RGName.
⚠️ New-AzVmssConfig 1 9 Unassigned_Variable New-AzVmss -Name $VMSSName is a null-valued parameter value. -Name Assign value for $VMSSName.
⚠️ New-AzVmssConfig 4 18 Unassigned_Variable New-AzStorageAccount -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ New-AzVmssConfig 4 18 Unassigned_Variable New-AzStorageAccount -Location $loc is a null-valued parameter value. -Location Assign value for $loc.
⚠️ New-AzVmssConfig 4 19 Unassigned_Variable Get-AzStorageAccount -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ New-AzVmssConfig 4 23 Unassigned_Variable New-AzVirtualNetwork -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ New-AzVmssConfig 4 23 Unassigned_Variable New-AzVirtualNetwork -Location $loc is a null-valued parameter value. -Location Assign value for $loc.
⚠️ New-AzVmssConfig 4 24 Unassigned_Variable Get-AzVirtualNetwork -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ New-AzVmssConfig 4 30 Unassigned_Variable New-AzVmssConfig -Location $loc is a null-valued parameter value. -Location Assign value for $loc.
⚠️ New-AzVmssConfig 4 37 Unassigned_Variable New-AzVmss -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ New-AzVmssConfig 4 39 Unassigned_Variable Get-AzVmss -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ New-AzVmssConfig 5 36 Mismatched_Parameter_Value_Type Set-AzVmssOsProfile -AdminPassword $adminPassword is not an expected parameter value type. -AdminPassword Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command).
⚠️ Set-AzVMSecurityProfile 2 8 Mismatched_Parameter_Value_Type ConvertTo-SecureString -[-String] $password is not an expected parameter value type. $password Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command).
⚠️ Set-AzVMSecurityProfile 2 9 Unassigned_Variable New-Object -[-ArgumentList] ($user, $securePassword) is a null-valued parameter value. ($user, $securePassword) Assign value for ($user, $securePassword).
⚠️ Set-AzVMSecurityProfile 2 13 Unassigned_Variable New-AzVMConfig -VMName $VMName is a null-valued parameter value. -VMName Assign value for $VMName.
⚠️ Set-AzVMSecurityProfile 2 16 Unassigned_Variable New-AzVirtualNetworkSubnetConfig -Name $SubnetName is a null-valued parameter value. -Name Assign value for $SubnetName.
⚠️ Set-AzVMSecurityProfile 2 17 Unassigned_Variable New-AzVirtualNetwork -Name $NetworkName is a null-valued parameter value. -Name Assign value for $NetworkName.
⚠️ Set-AzVMSecurityProfile 2 17 Unassigned_Variable New-AzVirtualNetwork -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Set-AzVMSecurityProfile 2 17 Unassigned_Variable New-AzVirtualNetwork -Location $LocationName is a null-valued parameter value. -Location Assign value for $LocationName.
⚠️ Set-AzVMSecurityProfile 2 18 Unassigned_Variable New-AzPublicIpAddress -Name $PublicIPAddressName is a null-valued parameter value. -Name Assign value for $PublicIPAddressName.
⚠️ Set-AzVMSecurityProfile 2 18 Unassigned_Variable New-AzPublicIpAddress -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Set-AzVMSecurityProfile 2 18 Unassigned_Variable New-AzPublicIpAddress -Location $LocationName is a null-valued parameter value. -Location Assign value for $LocationName.
⚠️ Set-AzVMSecurityProfile 2 19 Unassigned_Variable New-AzNetworkInterface -Name $NICName is a null-valued parameter value. -Name Assign value for $NICName.
⚠️ Set-AzVMSecurityProfile 2 19 Unassigned_Variable New-AzNetworkInterface -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Set-AzVMSecurityProfile 2 19 Unassigned_Variable New-AzNetworkInterface -Location $LocationName is a null-valued parameter value. -Location Assign value for $LocationName.
⚠️ Set-AzVMSecurityProfile 2 20 Unassigned_Variable Set-AzVMOperatingSystem -ComputerName $ComputerName is a null-valued parameter value. -ComputerName Assign value for $ComputerName.
⚠️ Set-AzVMSecurityProfile 2 32 Unassigned_Variable New-AzVM -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Set-AzVMSecurityProfile 2 32 Unassigned_Variable New-AzVM -Location $LocationName is a null-valued parameter value. -Location Assign value for $LocationName.
⚠️ Set-AzVMSecurityProfile 2 33 Unassigned_Variable Get-AzVm -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Set-AzVMSecurityProfile 2 33 Unassigned_Variable Get-AzVm -Name $vmname is a null-valued parameter value. -Name Assign value for $vmname.
⚠️ Set-AzVmssSecurityProfile 2 40 Mismatched_Parameter_Value_Type Set-AzVmssOsProfile -AdminPassword $adminPassword is not an expected parameter value type. -AdminPassword Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command).
⚠️ Update-AzVmss 1 1 Unassigned_Variable Update-AzVmss -VirtualMachineScaleSet $LocalVMSS is a null-valued parameter value. -VirtualMachineScaleSet Assign value for $LocalVMSS.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.EventHub
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Ssh
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@Sandido Sandido added this to the September 2023 (2023-09-05) milestone Aug 16, 2023
@Sandido Sandido changed the title Add SecurityType of Standard to VM and VMSS cmdlets for Trusted Launch Add SecurityType of Standard to VM and VMSS cmdlets for Trusted Launch, includes breaking changes Aug 17, 2023
@Sandido Sandido marked this pull request as ready for review August 17, 2023 21:21
@YanaXu YanaXu added the Contains Breaking Change This PR contains breaking change label Aug 18, 2023
@Sandido Sandido removed the Contains Breaking Change This PR contains breaking change label Aug 18, 2023
@YanaXu YanaXu merged commit 7842cd9 into main Aug 21, 2023
@YanaXu YanaXu deleted the adsandor/sectypestnd branch August 21, 2023 05:29
YanaXu added a commit that referenced this pull request Aug 25, 2023
@aneeshakella-microsoft @azure-powershell-bot
@Nickcandy @isra-fel @wyunchi-ms @grizzlytheodore @sauravraghuvanshi @YanaXu @BethanyZhou @andreygoran @kevinzz6 @vidai-msft @nalingaddis @coolhome @dolauli @VeryEarly @yifanz7 @dantedallag @yuc-Li @Sandido @msJinLei @mayankkatwal @microsoft-github-policy-service @myun12580
Adding Autoscaling Capabilities to Virtual Network Gateway (#22637)
af1ac14 
* Bump up version for KeyVault (#22511)

* Merge remote-tracking branch 'upstream/main' into lnx/azurecore (#22349)

Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>

* Exclude the api-version in typename when checking the breaking change of cmdlet output (#22495)

* Exclude the api-version in typename when checking the breaking change of cmdlet output

* Rename the function

* fix Get-AzVmRunCommand bug  (#22460)

* fix bug

* changelog

---------

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>

* Add permission for pr-label github actions (#22481)

* Add permission for pr-label github actions

* Add permission for pr-label github actions

* Add permission for pr-label github actions

* Add permission for pr-label github actions

* Update Remove-AzApiManagementApiFromGateway.md (#22505)

Added the example of removing an API from a managed gateway. Users are not able to achieve it by following the first example and raising questions using support tickets.

* Migrate StackHCI from generation to main (#22541)

* Move StackHCI to main

* udpate changelog

---------

Co-authored-by: YanaXu <sheshouxy@gmail.com>

* [KeyVault] Support MHSM Settings (#22525)

* wip

* add update-azkeyvaultsetting and help docs

* add example for settings

* add change log

* add live test

* fix

* fix

* Migrate ContainerInstance from generation to main (#22537)

* Move ContainerInstance to main

* Create containerGroups-containers.json

* Create containerGroups.json

---------

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>

* Updated ChangeLog.md for Az.ContainerInstance (#22550)

* Updated ChangeLog.md for Az.ContainerInstance

* Update src/ContainerInstance/ChangeLog.md

---------

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>

* [Synapse] Update artifact to 1.0.0-preview.18 (#22452)

* update artifact to 18

* fix change log error

* workaround the assembly loading issue (#22551)

* [Compute] update sdk package reference for Compute  (#22459)

* update SDK reference

* resolve breaking change

* update package reference

* breaking change mitigation

* breaking change suppression

* re-record ssh test with latest compute API call

---------

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>

* Bump up version for StackHCI (#22543)

* Compute migration to track 1 deprecation  (#21949)

* add compute.sdk project reference

* add sdk folder

* address comments

* update commit version to inputs

* rename Compute.Sdk folder to Compute.Management.Sdk

* resolve xmls, change compute.sdk reference to compute.management.sdk

* remove SDK reference.  generate track 1 with latest DiskRP version

* Update src/Compute/Compute.Management.Sdk/README.md

Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com>

* fix autorest cmd

* update autorest gen

* Update Compute.Management.Sdk.csproj

* generated with latest swagger versions. 2023-04-02 diskRP 2023-07-01 CRP

* update assembly version of sdk

---------

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com>

* [KeyVault] Added security domain properties into PSManagedHsm (#22540)

* Refresh track 1 SDK

* Added security domain properties into the output of New/Update/Get-AzKeyVaultManagedHsm (PSManagedHsm)

* Refresh example

* hibernate parameter for Stop-AzVmss (#22560)

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>

* Update PrLabeled.ps1 (#22553)

* Adding XenonMV3 Support (#22530)

* adding PremiumMV3 to Xenon list

* updating changelog

---------

Co-authored-by: Nalin Gaddis <nalingaddis@microsoft.com>

* Upgraded vulnerable DLLs after upgrading PowerShell SDK (#22566)

* Update New-AzVirtualNetworkSubnetConfig.md (#22561)

`New-AzVirtualSubnetConfig` does not exists but `New-AzVirtualNetworkSubnetConfig` does.

* Generate aks sdk with autorest.powershell (#22501)

* Generate aks sdk with autorest.powershell

* Suppress breaking changes caused by character case change

* [KeyVault] Add live tests for MHSM Settings (#22570)

* Add live tests for MHSM Settings

* enable all test cases

* [Config] add config to disable write error to file system (#22529)

* disable error records persistence

* add keys

* upgrade common version

* polish help message for 'DisableErrorRecordsPersistence'

* Update src/Accounts/Authentication/Properties/Resources.resx

Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>

* remove debug parameters for get/clear/update config

* update environment variable name to AzPSDisableErrorRecordsPersistence

---------

Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>

* Updated email notification to support multi-recipients (#22577)

* Use autorest.powershell to generate AlertsManagement SDK to replace the track 1 SDK (#22579)

* [Storage] Support encryption context property when creating a datalakegen2 item  (#22563)

* encryption context

* Add changelog

* update test dependency and help file

* Add an example for encryption context

* Migrate StackHCI from generation to main (#22588)

* Move StackHCI to main

* update changelog

---------

Co-authored-by: YanaXu <sheshouxy@gmail.com>

* Support deployment stack object as input parameter for Save-Az*DeploymentStack and Remove-Az*DeploymentStack cmdlets (#22519)

* implemented stack object parameter sets for save and remove cmdlets

* adjust tests and session records

* adjusted changelog to reflect changes

* adjust testing formatting

* updating help docs

* update cmdlets and help docs for renamed parameter

* update sessions record tests

* Migrate DataMigration from generation to main (#22574)

* Move DataMigration to main

* update ChangeLog

---------

Co-authored-by: YanaXu <sheshouxy@gmail.com>

* change breaking change info (#22571)

* Fixed type conversion issue when sending email in live test (#22596)

* Skip Accounts when run static analysis check in generation ci (#22597)

* [HDInsight] Add warning message for break changes which plan to release in Nov. (#22578)

* Update Azure.Core from 1.31.0 to 1.33.0

* replace models

* Revert "replace models"

This reverts commit d1a1de3.

* add Warning message 1

* Update Azure.Core version to 1.34

* revert added package.

* Update change log

* Update changelog

* move changelog to Upcoming release

---------

Co-authored-by: v-yuchenli <v-yuchenli@microsoft.com>

* Update code-oob.yml for Azure Pipelines (#22591)

* Update code-oob.yml for Azure Pipelines

* Update code-oob.yml for Azure Pipelines

* Update code-oob.yml for Azure Pipelines

* Update code-oob.yml for Azure Pipelines

* Update code-oob.yml for Azure Pipelines

* [KeyVault] Formatted the table view of outputs (#22580)

* Formatted the table view of *-AzKeyVault, *-AzKeyVaultKey and *-AzKeyVaultSecret

* format cert

* reorg folder constructure

* Update src/KeyVault/KeyVault.Test/UnitTests/SetKeyVaultSecretTests.cs

* Update src/KeyVault/KeyVault.Test/UnitTests/RemoveKeyVaultSecretTests.cs

* Update src/KeyVault/KeyVault/KeyVault.csproj

* Update Maintenance ChangeLog.md (#22602)

* Update ChangeLog.md

* Update ChangeLog.md

* Update ChangeLog.md

* Skip Accounts when run static analysis check in generation ci (#22603)

* Skip Accounts when run static analysis check in generation ci

* Skip Accounts when run static analysis check in generation ci

* Skip Accounts when run static analysis check in generation ci

* Add SecurityType of Standard to VM and VMSS cmdlets for Trusted Launch, includes breaking changes (#22534)

* initial dev

* successful test 1

* vmss test and rest of dev

* vmss with config test

* vm with config test

* tests fixed maybe 1 fails

* static analysis

* remove vmss validation

* null check

* changelog and help doc

* constant values

* clean

* valids and clean

* Update BreakingChangeIssues.csv

* remove breaking

* Update BreakingChangeIssues.csv

* Sign old modules (#22609)

* Update ChangeLog.md

* Update ChangeLog.md

* Update ChangeLog.md

* Update ChangeLog.md

* Update ChangeLog.md

* Migrate SqlVirtualMachine from generation to main (#22608)

* Move SqlVirtualMachine to main

* update Changelog

---------

Co-authored-by: YanaXu <sheshouxy@gmail.com>

* Migrate EventHub from generation to main (#22610)

* Move EventHub to main

* update ChangeLog

---------

Co-authored-by: YanaXu <sheshouxy@gmail.com>

* Refill Credentials from AzKeyStore When Save AzContext (#22440)

* Refill Credentials from AzKeyStore When Save AzContext

fix #22355

* Address review comments

* Address review comments

* CosmosDB - New Restore Parameter (#22585)

* restore new param public network access

* minor fixes

* test change

* stable changes 1

* md param def changed

* reverting test changes for build

* restore ts

* test and test recording

* Migrate KeyVault from generation to main (#22621)

* Move KeyVault to main

* Update ChangeLog.md

---------

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>

* FabricBot: Onboarding to GitOps.ResourceManagement because of FabricBot decommissioning (#22343)

* Add prIssueManagement.yml to onboard repo to GitOps.ResourceManagement as FabricBot replacement

Owners of the FabricBot configuration should have received email notification. The same information contained in the email is published internally at: https://aka.ms/gim/fabricbot. Details on the replacement service and the syntax of the new yaml configuration file is available publicly at: https://microsoft.github.io/GitOps/policies/resource-management.html

Please review and merge this PR to complete the process of onboarding to the new service.

* Deleting fabricbot.json

* Update resourceManagement.yml

---------

Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com>

* [KeyVault] Update TestSetting.ps1 to run on one platform and latest powershell (#22618)

* Update TestSetting.ps1

* Update KeyVault.sln

* first set of changes

* created initial powershell for ergwscale

* edited changelog

* update warning message (#22619)

* Fix to only include non-empty ExtendedLocation (#22630)

* Fix to only include non-empty ExtendedLocation

* Updated ChangeLog.md

* Remove PS 7.0 from smoke test (#22569)

* Alias Set-AzConfig (#22629)

* updated files due to failing test

* formatting changes

* formatting changes

* Revert "formatting changes"

This reverts commit d8900c5.

* Revert " fixed merge issues"

This reverts commit bc4af78, reversing
changes made to d8900c5.

* finished changes

* formatting

* formatting

* formatting

* edited ChangeLog

* added empty line

* added empty line between 6.1.1 and 6.1.0

---------

Co-authored-by: Azure PowerShell <65331932+azure-powershell-bot@users.noreply.github.com>
Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com>
Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>
Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>
Co-authored-by: Theodore Chang <thchan@microsoft.com>
Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
Co-authored-by: Saurav Raghuvanshi <47741547+sauravraghuvanshi@users.noreply.github.com>
Co-authored-by: YanaXu <sheshouxy@gmail.com>
Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
Co-authored-by: Andrey Goran <andreygoran@gmail.com>
Co-authored-by: kevinzz6 <632604666@qq.com>
Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com>
Co-authored-by: Nalin Gaddis <33502801+nalingaddis@users.noreply.github.com>
Co-authored-by: Nalin Gaddis <nalingaddis@microsoft.com>
Co-authored-by: Preston Alvarado <700740+coolhome@users.noreply.github.com>
Co-authored-by: Xiaogang <xidi@microsoft.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>
Co-authored-by: yifanz7 <131133995+yifanz7@users.noreply.github.com>
Co-authored-by: Dante <danted@microsoft.com>
Co-authored-by: yuc-Li <58678302+yuc-Li@users.noreply.github.com>
Co-authored-by: v-yuchenli <v-yuchenli@microsoft.com>
Co-authored-by: Adam Sandor <adsandor@microsoft.com>
Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com>
Co-authored-by: mayankkatwal <121567171+mayankkatwal@users.noreply.github.com>
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Co-authored-by: myun12580 <133928614+myun12580@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YanaXu YanaXu YanaXu approved these changes

@bilaakpan-ms bilaakpan-ms Awaiting requested review from bilaakpan-ms

@haagha haagha Awaiting requested review from haagha haagha is a code owner

@grizzlytheodore grizzlytheodore Awaiting requested review from grizzlytheodore

Assignees

@YanaXu YanaXu

Labels

None yet

Projects

None yet

Milestone

September 2023 (2023-09-05)

Development

Successfully merging this pull request may close these issues.

2 participants

@Sandido @YanaXu