Skip to content

Fixed websocket related tasks in InvokeAzContainerInstanceCommand_ExecuteExpanded.cs #22486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andreygoran wants to merge 1 commit into from
Closed

Fixed websocket related tasks in InvokeAzContainerInstanceCommand_ExecuteExpanded.cs #22486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ContainerInstance/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
-->

## Upcoming Release
* Fixed a bug in Invoke-AzContainerInstanceCommand when no result was returned under some conditions

## Version 3.2.0
* Added `priority` property to Container Group properties
Expand Down
6 changes: 4 additions & 2 deletions src/ContainerInstance/custom/InvokeAzContainerInstanceCommand_ExecuteExpanded.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ partial void overrideOnOk(global::System.Net.Http.HttpResponseMessage responseMe

private Task PullResponse()
{
return Task.Factory.StartNew(async () =>
return Task.Run(async () =>
{
string result = string.Empty;
var allBytes = new List<byte>();
Expand Down Expand Up @@ -76,8 +76,10 @@ private Task PullResponse()

private Task PushCommand()
{
return Task.Factory.StartNew(async () =>
return Task.Run(async () =>
{
if (Console.IsInputRedirected) return;

StringBuilder input = new StringBuilder();
// Loop until input is entered.
while (socket.State == WebSocketState.Open && !this._cancellationTokenSource.Token.IsCancellationRequested)
Expand Down