[HDInsight] Replace the referenced HDInsight .NET SDK from Microsoft. Azure. Management. HDInsight to Azure. ResourceManager. HDInsight by yuc-Li · Pull Request #22428 · Azure/azure-powershell

yuc-Li · 2023-07-26T06:19:14Z

Description

Replace the referenced HDInsight .NET SDK from Microsoft.Azure.Management.HDInsight to Azure.ResourceManager.HDInsight(Here are some break changes).
New feature: added parameter EnableSecureChannel enable secure channel when create a cluster.
Fix bug: fixed cannot get storage account info when use gen2 type.

Fewer code changes for bug fix and new features, so opening more PR will not reduce the number of changed files.

Checklist

Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
SHOULD make the title of PR clear and informative, and in the present imperative tense.
SHOULD update ChangeLog.md file(s) appropriately
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
- Create new module from scratch
- Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
- Create new resource type which name doesn't use module name as prefix
- Have design question before implementation
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT introduce breaking changes in Az minor release except preview version.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2023-07-26T06:19:16Z

️✔️Az.Accounts

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

❌Az.HDInsight

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Breaking Change Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Signature Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Help Example Check

⚠️PowerShell Core - Windows

Type Cmdlet Example Line RuleName Description Extent Remediation

⚠️ New-AzHDInsightCluster 9 20 Mismatched_Parameter_Value_Type ConvertTo-SecureString -[-String] $domainPassword is not an expected parameter value type. $domainPassword Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command).

⚠️ New-AzHDInsightCluster 9 48 Mismatched_Parameter_Value_Type New-AzHDInsightCluster -SecurityProfile $config.SecurityProfile is not an expected parameter value type. -SecurityProfile Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.HDInsight.Models.AzureHDInsightSecurityProfile. Now the type is .(Command).

⚠️ New-AzHDInsightCluster 11 25 Unassigned_Variable New-AzHDInsightIPConfiguration -SubnetId $subnetId is a null-valued parameter value. -SubnetId Assign value for $subnetId.

⚠️ New-AzHDInsightCluster 12 23 Mismatched_Parameter_Value_Type ConvertTo-SecureString -[-String] $databasePassword is not an expected parameter value type. $databasePassword Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command).

⚠️ New-AzHDInsightClusterConfig 1 23 Unassigned_Variable Add-AzHDInsightStorage -StorageAccountKey $key2 is a null-valued parameter value. -StorageAccountKey Assign value for $key2.

⚠️Windows PowerShell - Windows

Type Cmdlet Example Line RuleName Description Extent Remediation

⚠️ New-AzHDInsightCluster 9 20 Mismatched_Parameter_Value_Type ConvertTo-SecureString -[-String] $domainPassword is not an expected parameter value type. $domainPassword Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command).

⚠️ New-AzHDInsightCluster 9 48 Mismatched_Parameter_Value_Type New-AzHDInsightCluster -SecurityProfile $config.SecurityProfile is not an expected parameter value type. -SecurityProfile Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.HDInsight.Models.AzureHDInsightSecurityProfile. Now the type is .(Command).

⚠️ New-AzHDInsightCluster 11 25 Unassigned_Variable New-AzHDInsightIPConfiguration -SubnetId $subnetId is a null-valued parameter value. -SubnetId Assign value for $subnetId.

⚠️ New-AzHDInsightCluster 12 23 Mismatched_Parameter_Value_Type ConvertTo-SecureString -[-String] $databasePassword is not an expected parameter value type. $databasePassword Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command).

⚠️ New-AzHDInsightClusterConfig 1 23 Unassigned_Variable Add-AzHDInsightStorage -StorageAccountKey $key2 is a null-valued parameter value. -StorageAccountKey Assign value for $key2.

️✔️Help File Existence Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️File Change Check

⚠️PowerShell Core - Windows

Type Cmdlet Description Remediation

⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.

⚠️Windows PowerShell - Windows

Type Cmdlet Description Remediation

⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.

️✔️UX Metadata Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

❌Generated Sdk Check

❌PowerShell Core - Windows

Type Module Sdk Description Remediation

❌ Az.HDInsight src/HDInsight/HDInsight.Management.Sdk Generated code for Az.HDInsight is not up to date or you have updated generated Sdk. You may need to rebase on the latest main, regenerate code accroding to README.md file under src/HDInsight/HDInsight.Management.Sdk, and make sure no more updates based on generated files.

❌Windows PowerShell - Windows

Type Module Sdk Description Remediation

❌ Az.HDInsight src/HDInsight/HDInsight.Management.Sdk Generated code for Az.HDInsight is not up to date or you have updated generated Sdk. You may need to rebase on the latest main, regenerate code accroding to README.md file under src/HDInsight/HDInsight.Management.Sdk, and make sure no more updates based on generated files.

⚠️Test

⚠️ - Linux

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 0.00 % Test coverage for the module cannot be lower than 50%.

⚠️ - MacOS

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.

⚠️PowerShell Core - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.

⚠️Windows PowerShell - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.

️✔️Az.ManagedServiceIdentity

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.OperationalInsights

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Storage

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

aim-for-better · 2023-08-04T06:23:55Z

src/HDInsight/HDInsight/ManagementCommands/RemoveAzureHDInsightClusterCommand.cs

            }

-            HDInsightManagementClient.DeleteCluster(ResourceGroupName, ClusterName);
+            HDInsightManagementClient.DeleteClusterAsync(ResourceGroupName, ClusterName);


please use the sync method to keep the same behavior with previous

The behavior is the same as before, and the two names have been changed back

YanaXu · 2023-08-11T11:39:14Z

Hi @yuc-Li, there are breaking changes in this PR. Could you hold this PR to the next major release and now add the breaking changes warnings?

yuc-Li · 2023-08-14T01:18:57Z

Sure, I will first submit a PR to add warning messages.

yuc-Li · 2023-10-27T07:30:45Z

Hi @YanaXu, please review this PR, we plan to complete it in the upcoming major release.

…c-Li/azure-powershell into hdinsight-new-version-2023-04

…o hdinsight-new-version-2023-04

v-yuchenli and others added 4 commits June 29, 2023 13:37

Update Azure.Core from 1.31.0 to 1.33.0

32c85b8

replace models

d1a1de3

Merge branch 'Azure:main' into main

c3645c3

replace package

09482d8

v-yuchenli added 11 commits July 31, 2023 15:35

Update test and records

66c0cc0

update

4804e09

update test records

11ac3d9

update

3c14add

review update

d457514

update

22e6fd3

fix test

85fb3c7

update test

b23f0b8

break change exce[tion

fd711d3

skip living test

de4dd90

update help doc

e69995d

aim-for-better reviewed Aug 4, 2023

View reviewed changes

revert method name

814f10c

yuc-Li changed the title ~~Hdinsight new api version 2023-04~~ [HDInsight] Replace the referenced HDInsight .NET SDK from Microsoft. Azure. Management. HDInsight to Azure. ResourceManager. HDInsight Aug 4, 2023

yuc-Li marked this pull request as ready for review August 7, 2023 01:27

YanaXu added the Contains Breaking Change This PR contains breaking change label Aug 8, 2023

v-yuchenli and others added 3 commits August 10, 2023 09:41

Update test and revert param `Location

01e8cd8

Update Azure.Core to 1.34.0 to solve pipeline error

f5eda2a

Merge branch 'Azure:main' into main

8ec6cd1

yuc-Li mentioned this pull request Aug 15, 2023

[HDInsight] Add warning message for break changes which plan to release in Nov. #22578

Merged

1 task

yuc-Li and others added 2 commits August 18, 2023 09:38

Merge branch 'Azure:main' into main

e9c5306

Merge branch 'main' into hdinsight-new-version-2023-04

0071962

YanaXu added the Do Not Merge 🚫 label Aug 18, 2023

yuc-Li and others added 4 commits August 22, 2023 09:37

Merge branch 'main' into hdinsight-new-version-2023-04

c803f9e

merge main update

35e0868

update refrence

562cdf2

Merge branch 'Azure:main' into main

f4bf080

yuc-Li removed the Do Not Merge 🚫 label Oct 27, 2023

aim-for-better added this to the Az 11.0.0 (November 2023, 2023-11-14)❗ Breaking change release ❗ milestone Oct 27, 2023

v-yuchenli and others added 4 commits October 30, 2023 13:44

Remove break changes warning messages.

ce54d0f

Merge branch 'main' into hdinsight-new-version-2023-04

e04f84e

Remove azure.core version item

8d0f0c3

Merge branch 'hdinsight-new-version-2023-04' of https://github.com/yu…

c1d2a60

…c-Li/azure-powershell into hdinsight-new-version-2023-04

VeryEarly self-assigned this Oct 30, 2023

v-yuchenli and others added 5 commits October 31, 2023 17:02

Update help doc.

2d283fb

Revert some changes.

e100d02

Merge branch 'Azure:main' into main

678716f

Merge branch 'main' of https://github.com/yuc-Li/azure-powershell int…

e6e7fea

…o hdinsight-new-version-2023-04

generate track 1 code

6acc327

yuc-Li closed this Nov 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HDInsight] Replace the referenced HDInsight .NET SDK from Microsoft. Azure. Management. HDInsight to Azure. ResourceManager. HDInsight#22428

[HDInsight] Replace the referenced HDInsight .NET SDK from Microsoft. Azure. Management. HDInsight to Azure. ResourceManager. HDInsight#22428
yuc-Li wants to merge 34 commits intoAzure:mainfrom
yuc-Li:hdinsight-new-version-2023-04

yuc-Li commented Jul 26, 2023 •

edited

Loading

Uh oh!

azure-client-tools-bot-prd bot commented Jul 26, 2023 •

edited

Loading

Uh oh!

aim-for-better Aug 4, 2023

Uh oh!

yuc-Li Aug 7, 2023

Uh oh!

YanaXu commented Aug 11, 2023

Uh oh!

yuc-Li commented Aug 14, 2023

Uh oh!

yuc-Li commented Oct 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

yuc-Li commented Jul 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Jul 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aim-for-better Aug 4, 2023

Choose a reason for hiding this comment

Uh oh!

yuc-Li Aug 7, 2023

Choose a reason for hiding this comment

Uh oh!

YanaXu commented Aug 11, 2023

Uh oh!

yuc-Li commented Aug 14, 2023

Uh oh!

yuc-Li commented Oct 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yuc-Li commented Jul 26, 2023 •

edited

Loading

azure-client-tools-bot-prd bot commented Jul 26, 2023 •

edited

Loading