Skip to content

Comments

Migrate Migrate from generation to main#22025

Merged
vidai-msft merged 3 commits intomainfrom
codegen/Migrate
Jun 9, 2023
Merged

Migrate Migrate from generation to main#22025
vidai-msft merged 3 commits intomainfrom
codegen/Migrate

Conversation

@azure-powershell-bot
Copy link
Collaborator

Description

Migrate Migrate from generation to main

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 8, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.Migrate
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ 1 6 Mismatched_Parameter_Value_Type New-AzMigrateReplicationPolicy -ProviderSpecificInput $providerSpecificPolicy is not an expected parameter value type. -ProviderSpecificInput Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Migrate.Models.Api202301.IPolicyProviderSpecificInput. Now the type is .(Type).
⚠️ 1 10 Mismatched_Parameter_Value_Type New-AzMigrateReplicationProtectionContainerMapping -ProviderSpecificInput $providerSpecificInput is not an expected parameter value type. -ProviderSpecificInput Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Migrate.Models.Api202301.IReplicationProviderSpecificContainerMappingInput. Now the type is .(Type).
⚠️ 2 1 Unassigned_Variable Get-AzMigrateServerReplication -TargetObjectID $env.srsMachineId is a null-valued parameter value. -TargetObjectID Assign value for $env.srsMachineId.
⚠️ 2 1 Unassigned_Variable Get-AzMigrateServerReplication -SubscriptionId $env.srsSubscriptionId is a null-valued parameter value. -SubscriptionId Assign value for $env.srsSubscriptionId.
⚠️ 2 1 Unassigned_Variable Get-AzMigrateServerReplication -TargetObjectID $env.srsMachineId is a null-valued parameter value. -TargetObjectID Assign value for $env.srsMachineId.
⚠️ 2 1 Unassigned_Variable Get-AzMigrateServerReplication -SubscriptionId $env.srsSubscriptionId is a null-valued parameter value. -SubscriptionId Assign value for $env.srsSubscriptionId.
⚠️ 2 2 Unassigned_Variable Start-AzMigrateTestMigrationCleanup -InputObject $ob is a null-valued parameter value. -InputObject Assign value for $ob.
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ 1 6 Mismatched_Parameter_Value_Type New-AzMigrateReplicationPolicy -ProviderSpecificInput $providerSpecificPolicy is not an expected parameter value type. -ProviderSpecificInput Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Migrate.Models.Api202301.IPolicyProviderSpecificInput. Now the type is .(Type).
⚠️ 1 10 Mismatched_Parameter_Value_Type New-AzMigrateReplicationProtectionContainerMapping -ProviderSpecificInput $providerSpecificInput is not an expected parameter value type. -ProviderSpecificInput Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Migrate.Models.Api202301.IReplicationProviderSpecificContainerMappingInput. Now the type is .(Type).
⚠️ 2 1 Unassigned_Variable Get-AzMigrateServerReplication -TargetObjectID $env.srsMachineId is a null-valued parameter value. -TargetObjectID Assign value for $env.srsMachineId.
⚠️ 2 1 Unassigned_Variable Get-AzMigrateServerReplication -SubscriptionId $env.srsSubscriptionId is a null-valued parameter value. -SubscriptionId Assign value for $env.srsSubscriptionId.
⚠️ 2 1 Unassigned_Variable Get-AzMigrateServerReplication -TargetObjectID $env.srsMachineId is a null-valued parameter value. -TargetObjectID Assign value for $env.srsMachineId.
⚠️ 2 1 Unassigned_Variable Get-AzMigrateServerReplication -SubscriptionId $env.srsSubscriptionId is a null-valued parameter value. -SubscriptionId Assign value for $env.srsSubscriptionId.
⚠️ 2 2 Unassigned_Variable Start-AzMigrateTestMigrationCleanup -InputObject $ob is a null-valued parameter value. -InputObject Assign value for $ob.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Test
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
️✔️PowerShell Core - Linux
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@vidai-msft vidai-msft merged commit 24d1131 into main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants