Skip to content

Add denpendencies in Compute to resolve the CVE #21649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yeming Liu (isra-fel) merged 3 commits into from
Apr 28, 2023
Merged

Add denpendencies in Compute to resolve the CVE #21649

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3717b81
Add denpendencies in Compute to resolve the CVE
NoriZC Apr 26, 2023
f7dfaa3
Update System.Security.Permissions from 4.5.0 to 4.7.0
NoriZC Apr 26, 2023
997cf1e
Update System.Security.Permissions from 4.5.0 to 4.7.0
NoriZC Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Compute/Compute/Compute.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@
<PackageReference Include="Microsoft.Azure.PowerShell.AutoMapper" Version="6.2.2" />
<PackageReference Include="Microsoft.Azure.Management.ResourceGraph" Version="2.1.0" />
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="60.0.0" />
<PackageReference Include="System.Security.Permissions" Version="4.5.0" />
<PackageReference Include="System.Security.Permissions" Version="4.7.0" />

@isra-fel Yeming Liu (isra-fel) Apr 26, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this package referenced by other projects? We should update them as well if so.

@NoriZC NoriZC Apr 26, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it appears in another 8 projects including Az.Accounts. I will check them one by one. Thanks for reminding

@isra-fel Yeming Liu (isra-fel) Apr 26, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I just noticed System.Security.Permissions is a common dependency, we should follow the similar process of updating Azure.Core

@NoriZC NoriZC Apr 27, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated all the files, if this works I will update related changelogs in projects where updated dlls are included.

<PackageReference Include="System.ServiceModel.Primitives" Version="4.7.0" />
<PackageReference Include="WindowsAzure.Storage" Version="9.3.0" />
<PackageReference Include="System.Management" Version="4.5.0" />
<!-- Include the following DLLs for security issue -->
<!-- PackageReference Include="System.Security.Cryptography.Xml" Version="4.7.1" /-->
<PackageReference Include="System.Security.Cryptography.Xml" Version="4.7.1" />
</ItemGroup>

<ItemGroup>
Expand Down