Skip to content

Update Az Predictor version with new telemetry property name #21615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isra-fel merged 4 commits into from
Apr 24, 2023
Merged

Update Az Predictor version with new telemetry property name #21615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1613e3e
Add more test cases
kceiw Apr 17, 2023
634945b
Rename the two property names
kceiw Apr 19, 2023
8241b43
Update the version
kceiw Apr 20, 2023
079176b
Add more test cases
kceiw Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions tools/Az.Tools.Predictor/Az.Tools.Predictor.Test/AzPredictorTelemetryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,12 @@ public AzPredictorTelemetryTests(ModelFixture modelFixture)
[InlineData(@"C:\Users\MyName\exe")]
[InlineData(@"az storage")]
[InlineData(@"get")]
[InlineData(@"-StorageAccountKey""xxx""NewAzStorageContainer -context xxx")]
[InlineData(@"-StorageAccountKey\""xxx\""NewAzStorageContainer -context xxx")]
[InlineData(@"-StorageAccountKey""xxx""New-AzStorageContainer -context xxx")]
[InlineData(@"New-AzureStorageContext-StorageAccountName ""xxx"" -StorageAccountKey ""xxx""")]
[InlineData(@"sig=xxxxxxxxxxx/Sensor-Azure")]
[InlineData(@"sig=Signature/Test-Sensor-Azu")]
public async Task VerifyOnCommandLineAcceptedForOneUnsupportedCommandHistory(string inputData)
{
var expectedTelemetryCount = 2;
Expand Down Expand Up @@ -151,6 +157,7 @@ public async Task VerifyOnCommandLineAcceptedForOneSupportedCommandWithoutParame
[InlineData("Get-AzRoleAssignment -ObjectId ***", "Remove-AzRoleAssignment -RoleDefinitionId (Get-AzRoleAssignment -ObjectId xxxx)")]
[InlineData("Get-AzResourceGroup -Location:***", "Get-AzResourceGroup rg1 -Location:WestUS3")]
[InlineData("Get-AzResourceGroup", "Get-AzResourceGroup rg1 WestUS3")]
[InlineData("New-AzureStorageContext -StorageAccountKey *** -StorageAccountName ***", @"New-AzureStorageContext -StorageAccountName ""accountName"" -StorageAccountKey ""accountKey""")]
public async Task VerifyOnCommandLineAcceptedForOneSupportedCommandWithParameter(string expectedValue, string inputData)
{
var expectedTelemetryCount = 2;
Expand Down Expand Up @@ -556,8 +563,15 @@ public async Task VerifyOnCommandLineAcceptedException()
[InlineData("Set-Az", "Set-Az")]
[InlineData("Get-azR", "Get-azR")]
[InlineData("start_of_snippet", "NonVerb-AzResource")]
[InlineData("start_of_snippet", "Get")]
[InlineData("start_of_snippet", "Set-")]
[InlineData("Get", "Get")]
[InlineData("Set-", "Set-")]
[InlineData("New-AzureStorageContext -StorageAccountKey *** -StorageAccountName ***", @"New-AzureStorageContext -StorageAccountName ""accountName"" -StorageAccountKey ""accountKey""")]
[InlineData("start_of_snippet", @"-StorageAccountKey""xxx""NewAzStorageContainer -context xxx")]
[InlineData("start_of_snippet", @"-StorageAccountKey\""xxx\""NewAzStorageContainer -context xxx")]
[InlineData("start_of_snippet", @"-StorageAccountKey""xxx""New-AzStorageContainer -context xxx")]
[InlineData("start_of_snippet", @"New-AzureStorageContext-StorageAccountName ""xxx"" -StorageAccountKey ""xxx""")]
[InlineData("start_of_snippet", @"sig=xxxxxxxxxxx/Sensor-Azure")]
[InlineData("start_of_snippet", @"sig=Signature/Test-Sensor-Azu")]
public void VerifyUserInputInGetSuggestionEvent(string expectedUserInput, string input)
{
var expectedTelemetryCount = 1;
Expand Down
2 changes: 1 addition & 1 deletion tools/Az.Tools.Predictor/Az.Tools.Predictor/Az.Tools.Predictor.psd1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
RootModule = 'Az.Tools.Predictor.psm1'

# Version number of this module.
ModuleVersion = '1.1.0'
ModuleVersion = '1.1.1'

# Supported PSEditions
CompatiblePSEditions = 'Core'
Expand Down
3 changes: 3 additions & 0 deletions tools/Az.Tools.Predictor/Az.Tools.Predictor/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
-->
## Upcoming Release

## Version 1.1.1
* Updated data collection mechanism

## Version 1.1.0
* Updated data collection mechanism

Expand Down
2 changes: 1 addition & 1 deletion tools/Az.Tools.Predictor/Az.Tools.Predictor/Telemetry/GetSuggestionTelemetryData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public sealed class GetSuggestionTelemetryData : ITelemetryData
/// <summary>
/// The telemetry property name for "Prediction".
/// </summary>
public const string PropertyNamePrediction = "Prediction";
public const string PropertyNamePrediction = "Prediction2";

/// <summary>
/// The telemetry property name for "SuggestionSessionId".
Expand Down
2 changes: 1 addition & 1 deletion tools/Az.Tools.Predictor/Az.Tools.Predictor/Telemetry/HistoryTelemetryData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public sealed class HistoryTelemetryData : ITelemetryData
/// <summary>
/// The telemetry property name for "Command".
/// </summary>
public const string PropertyNameCommand = "Command";
public const string PropertyNameCommand = "Command2";

/// <summary>
/// The telemetry property name for "Success".
Expand Down
2 changes: 1 addition & 1 deletion tools/Az.Tools.Predictor/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<TargetFramework>net6.0</TargetFramework>
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<Version>1.1.0</Version>
<Version>1.1.1</Version>
<Authors>Microsoft Corporation</Authors>
<Company>Microsoft Corporation</Company>
<Copyright>Microsoft Corporation. All rights reserved.</Copyright>
Expand Down