[MobileNetwork] Fixissue mobile network logic for New-Az*#21147
Merged
wyunchi-ms merged 13 commits intogenerationfrom Apr 10, 2023
Merged
[MobileNetwork] Fixissue mobile network logic for New-Az*#21147wyunchi-ms merged 13 commits intogenerationfrom
wyunchi-ms merged 13 commits intogenerationfrom
Conversation
️✔️Az.Accounts
|
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| Get-AzMobileNetwork | Get-AzMobileNetwork Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzMobileNetwork | Get-AzMobileNetwork changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzMobileNetworkAttachedDataNetwork | Get-AzMobileNetworkAttachedDataNetwork Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzMobileNetworkAttachedDataNetwork | Get-AzMobileNetworkAttachedDataNetwork changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzMobileNetworkDataNetwork | Get-AzMobileNetworkDataNetwork Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzMobileNetworkDataNetwork | Get-AzMobileNetworkDataNetwork changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzMobileNetworkPacketCoreControlPlane | Get-AzMobileNetworkPacketCoreControlPlane Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzMobileNetworkPacketCoreControlPlane | Get-AzMobileNetworkPacketCoreControlPlane changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzMobileNetworkPacketCoreControlPlaneVersion | Get-AzMobileNetworkPacketCoreControlPlaneVersion Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzMobileNetworkPacketCoreControlPlaneVersion | Get-AzMobileNetworkPacketCoreControlPlaneVersion changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzMobileNetworkPacketCoreDataPlane | Get-AzMobileNetworkPacketCoreDataPlane Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzMobileNetworkPacketCoreDataPlane | Get-AzMobileNetworkPacketCoreDataPlane changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzMobileNetworkService | Get-AzMobileNetworkService Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzMobileNetworkService | Get-AzMobileNetworkService changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzMobileNetworkSim | Get-AzMobileNetworkSim Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzMobileNetworkSim | Get-AzMobileNetworkSim changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzMobileNetworkSimGroup | Get-AzMobileNetworkSimGroup Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzMobileNetworkSimGroup | Get-AzMobileNetworkSimGroup changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzMobileNetworkSimPolicy | Get-AzMobileNetworkSimPolicy Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzMobileNetworkSimPolicy | Get-AzMobileNetworkSimPolicy changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzMobileNetworkSite | Get-AzMobileNetworkSite Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzMobileNetworkSite | Get-AzMobileNetworkSite changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzMobileNetworkSlice | Get-AzMobileNetworkSlice Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzMobileNetworkSlice | Get-AzMobileNetworkSlice changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzMobileNetworkDataNetworkConfigurationObject | New-AzMobileNetworkDataNetworkConfigurationObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| New-AzMobileNetworkDataNetworkConfigurationObject | New-AzMobileNetworkDataNetworkConfigurationObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzMobileNetworkPccRuleConfigurationObject | New-AzMobileNetworkPccRuleConfigurationObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| New-AzMobileNetworkPccRuleConfigurationObject | New-AzMobileNetworkPccRuleConfigurationObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzMobileNetworkServiceDataFlowTemplateObject | New-AzMobileNetworkServiceDataFlowTemplateObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| New-AzMobileNetworkServiceDataFlowTemplateObject | New-AzMobileNetworkServiceDataFlowTemplateObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzMobileNetworkServiceResourceIdObject | New-AzMobileNetworkServiceResourceIdObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| New-AzMobileNetworkServiceResourceIdObject | New-AzMobileNetworkServiceResourceIdObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzMobileNetworkSimStaticIPPropertiesObject | New-AzMobileNetworkSimStaticIPPropertiesObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| New-AzMobileNetworkSimStaticIPPropertiesObject | New-AzMobileNetworkSimStaticIPPropertiesObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzMobileNetworkSiteResourceIdObject | New-AzMobileNetworkSiteResourceIdObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| New-AzMobileNetworkSiteResourceIdObject | New-AzMobileNetworkSiteResourceIdObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzMobileNetworkSliceConfigurationObject | New-AzMobileNetworkSliceConfigurationObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| New-AzMobileNetworkSliceConfigurationObject | New-AzMobileNetworkSliceConfigurationObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️ File Change Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.MobileNetwork. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
wyunchi-ms
reviewed
Apr 6, 2023
|
|
||
| process { | ||
| try { | ||
| $dataBase = Get-AzMobileNetworkAttachedDataNetwork -PacketCoreControlPlaneName $PSBoundParameters.PacketCoreControlPlaneName -PacketCoreDataPlaneName $PSBoundParameters.PacketCoreDataPlaneName -ResourceGroupName $PSBoundParameters.ResourceGroupName -Name $PSBoundParameters.AttachedDataNetworkName |
Contributor
There was a problem hiding this comment.
The variable should be named as attachedDataNetwork
|
|
||
| process { | ||
| try { | ||
| $dataBase = Get-AzMobileNetworkPacketCoreControlPlane -ResourceGroupName $PSBoundParameters.ResourceGroupName -Name $PSBoundParameters.PacketCoreControlPlaneName |
Contributor
There was a problem hiding this comment.
The variable should named as packetCoreControlPlane.
|
|
||
| process { | ||
| try { | ||
| $dataBase = Get-AzMobileNetworkPacketCoreDataPlane -PacketCoreControlPlaneName $PSBoundParameters.PacketCoreControlPlaneName -ResourceGroupName $PSBoundParameters.ResourceGroupName -Name $PSBoundParameters.PacketCoreDataPlaneName |
Contributor
There was a problem hiding this comment.
The variable should named as packetCoreDataPlane.
|
|
||
| process { | ||
| try { | ||
| $dataBase = Get-AzMobileNetworkService -MobileNetworkName $PSBoundParameters.MobileNetworkName -ResourceGroupName $PSBoundParameters.ResourceGroupName -Name $PSBoundParameters.ServiceName |
Contributor
There was a problem hiding this comment.
The variable should named as service.
| CreateExpanded = 'Az.MobileNetwork.private\New-AzMobileNetworkSimGroup_CreateExpanded'; | ||
| process { | ||
| try { | ||
| $dataBase = Get-AzMobileNetworkSimGroup -ResourceGroupName $PSBoundParameters.ResourceGroupName -Name $PSBoundParameters.SimGroupName |
Contributor
There was a problem hiding this comment.
The variable should named as simGroup.
|
|
||
| process { | ||
| try { | ||
| $dataBase = Get-AzMobileNetworkSimPolicy -MobileNetworkName $PSBoundParameters.MobileNetworkName -ResourceGroupName $PSBoundParameters.ResourceGroupName -Name $PSBoundParameters.SimPolicyName |
Contributor
There was a problem hiding this comment.
The variable should named as simPolicy.
|
|
||
| process { | ||
| try { | ||
| $dataBase = Get-AzMobileNetworkSlice -MobileNetworkName $PSBoundParameters.MobileNetworkName -ResourceGroupName $PSBoundParameters.ResourceGroupName -SliceName $PSBoundParameters.SliceName |
Contributor
There was a problem hiding this comment.
The variable should named as slice or mobileNetworkSlice.
wyunchi-ms
approved these changes
Apr 10, 2023
1 task
qinzhouxu
pushed a commit
to qinzhouxu/azure-powershell
that referenced
this pull request
Jun 12, 2023
* update cmdlet logic for new-az* * update cmdlet logic for new-az* * update * update * update custom logic * update custom logic * Create 'UX' folder * update some logic * update some logic * Create 'UX' folder and update changelog * Delete 'ux' folder * Create 'UX' folder * Change variable name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue: Azure/autorest.powershell#1114
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.