Register Microsoft.Monitor RP in Network cmdlets

[GokulPrasad-Work]

Description

Adding Microsoft.Monitor RP in Network PrivateLinkService cmdlet

Microsoft.Monitor RP supports

• List Private Link Resource API
• Get Private Endpoint Connection API
• List Private Endpoint Connection API

It doesn't support Get Private Link Resource API yet

Checklist

• [*] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

• SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
• SHOULD make the title of PR clear and informative, and in the present imperative tense.
• SHOULD update ChangeLog.md file(s) appropriately
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
  • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
• SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
  • Create new module from scratch
  • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
  • Create new resource type which name doesn't use module name as prefix
  • Have design question before implementation
• SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
• SHOULD have proper test coverage for changes in pull request.
• SHOULD NOT introduce breaking changes in Az minor release except preview version.
• SHOULD NOT adjust version of module manually in pull request

[BethanyZhou]

Looks good to me

[BethanyZhou]

/azp run azure-powershell - security-tools

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[GokulPrasad-Work]

Hello, Is there a way for us to take the intermediate build and install it in local machine to validate the new changes?

[BethanyZhou]

Yes, we do have.

• If you just want to test during the implementation, try https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/azure-powershell-developer-guide.md#enable-running-powershell-when-debugging
• If you want to install new build in local, please follow this guide to Create unsigned nuget packages locally.

[GokulPrasad-Work]

Hello @BethanyZhou, After the release, I tried to execute the Approve-AzPrivateEndpointConnection -ResourceId , but I am getting the below error:
Approve-AzPrivateEndpointConnection: Value cannot be null. (Parameter 'Id')
StatusCode: 400
ReasonPhrase: Bad Request
ErrorCode: BadArgument
ErrorMessage: Value cannot be null. (Parameter 'Id')
OperationID : 17228718-d310-4a95-bceb-cc20f19d0aba

Looks like the request is not populated with the id field which is given as "PrivateEndpointConnectionResourceId" in the cmdlet input.
Expected request payload is like below:
{
"id": "/subscriptions/{subscriptionId}/resourceGroups/{groupName}/providers/Microsoft.[Service]/{resourceType}/{resourceName}/privateEndpointConnections/{privateEndpointConnectionName}",
"properties":
{ "privateLinkServiceConnectionState":
{
"status": "Approved",
"description": "Approved by [email protected]"
}
}
}

Can you please help in debugging this issue?

[BethanyZhou]

@GokulPrasad-Work , please provide the command and its parameters you used when hit this issue to allow me reproduce this issue.

[GokulPrasad-Work]

@GokulPrasad-Work , please provide the command and its parameters you used when hit this issue to allow me reproduce this issue.

@BethanyZhou
Please see the below snapshot where the Approve private endpoint connection command is failing. Service expects Id parameter to be populated in the request. Looks like it is not getting populated in Powershell module which is causing this bad request failure from the service. Please feel free to ping me to discuss more on this issue. Thank you!

Command: AzPrivateEndpointConnection -ResourceId /subscriptions/{subId}/resourcegroups/{rgName}/providers/microsoft.monitor/accounts/{AccountName}/privateEndpointConnections/{peConnectionName} -Description Approved